* [PATCH] i915/HuC: Add an extra check for platforms that do not have HUC
@ 2017-03-01 19:58 Anusha Srivatsa
2017-03-01 21:48 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Anusha Srivatsa @ 2017-03-01 19:58 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi, Ander Conselvan De Oliveira
Return silently without producing much noise on platforms
that have a HuC but the firmware is absent.
Cc: Ander Conselvan De Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@itel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
drivers/gpu/drm/i915/intel_huc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_huc.c b/drivers/gpu/drm/i915/intel_huc.c
index c28543d..e660109 100644
--- a/drivers/gpu/drm/i915/intel_huc.c
+++ b/drivers/gpu/drm/i915/intel_huc.c
@@ -181,12 +181,14 @@ void intel_huc_init(struct drm_i915_private *dev_priv)
}
huc_fw->path = fw_path;
+
+ if (huc_fw->path == NULL)
+ return;
+
huc_fw->fetch_status = INTEL_UC_FIRMWARE_PENDING;
DRM_DEBUG_DRIVER("HuC firmware pending, path %s\n", fw_path);
- WARN(huc_fw->path == NULL, "HuC present but no fw path\n");
-
intel_uc_fw_fetch(dev_priv, huc_fw);
}
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for i915/HuC: Add an extra check for platforms that do not have HUC
2017-03-01 19:58 [PATCH] i915/HuC: Add an extra check for platforms that do not have HUC Anusha Srivatsa
@ 2017-03-01 21:48 ` Patchwork
2017-03-02 11:17 ` ✓ Fi.CI.BAT: success " Patchwork
2017-03-02 14:14 ` [PATCH] " Ander Conselvan De Oliveira
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-03-01 21:48 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: i915/HuC: Add an extra check for platforms that do not have HUC
URL : https://patchwork.freedesktop.org/series/20482/
State : failure
== Summary ==
Series 20482v1 i915/HuC: Add an extra check for platforms that do not have HUC
https://patchwork.freedesktop.org/api/1.0/series/20482/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
dmesg-warn -> PASS (fi-bxt-t5700)
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
pass -> FAIL (fi-skl-6770hq) fdo#99739
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-c:
pass -> FAIL (fi-skl-6770hq)
fdo#99739 https://bugs.freedesktop.org/show_bug.cgi?id=99739
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11
fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19
fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20
fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16
fi-ilk-650 total:278 pass:192 dwarn:36 dfail:0 fail:0 skip:50
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18
fi-kbl-7500u total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10
fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17
fi-skl-6700k total:278 pass:216 dwarn:44 dfail:0 fail:0 skip:18
fi-skl-6770hq total:278 pass:266 dwarn:0 dfail:0 fail:2 skip:10
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29
a777f02a6f1fbe44b42f245d6397b3f960a0a257 drm-tip: 2017y-03m-01d-20h-32m-24s UTC integration manifest
60ac8ba i915/HuC: Add an extra check for platforms that do not have HUC
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4023/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for i915/HuC: Add an extra check for platforms that do not have HUC
2017-03-01 19:58 [PATCH] i915/HuC: Add an extra check for platforms that do not have HUC Anusha Srivatsa
2017-03-01 21:48 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-03-02 11:17 ` Patchwork
2017-03-02 14:18 ` Ander Conselvan De Oliveira
2017-03-02 14:14 ` [PATCH] " Ander Conselvan De Oliveira
2 siblings, 1 reply; 5+ messages in thread
From: Patchwork @ 2017-03-02 11:17 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: i915/HuC: Add an extra check for platforms that do not have HUC
URL : https://patchwork.freedesktop.org/series/20482/
State : success
== Summary ==
Series 20482v1 i915/HuC: Add an extra check for platforms that do not have HUC
https://patchwork.freedesktop.org/api/1.0/series/20482/revisions/1/mbox/
Test pm_rpm:
Subgroup basic-pci-d3-state:
incomplete -> PASS (fi-byt-n2820) fdo#99740
fdo#99740 https://bugs.freedesktop.org/show_bug.cgi?id=99740
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11
fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19
fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20
fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18
fi-kbl-7500u total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10
fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29
b3c4a574937b2256a716b23037c8b94ffebd7c8a drm-tip: 2017y-03m-02d-08h-59m-08s UTC integration manifest
51adfd1 i915/HuC: Add an extra check for platforms that do not have HUC
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4030/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i915/HuC: Add an extra check for platforms that do not have HUC
2017-03-01 19:58 [PATCH] i915/HuC: Add an extra check for platforms that do not have HUC Anusha Srivatsa
2017-03-01 21:48 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-03-02 11:17 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2017-03-02 14:14 ` Ander Conselvan De Oliveira
2 siblings, 0 replies; 5+ messages in thread
From: Ander Conselvan De Oliveira @ 2017-03-02 14:14 UTC (permalink / raw)
To: Anusha Srivatsa, intel-gfx; +Cc: Rodrigo Vivi
On Wed, 2017-03-01 at 11:58 -0800, Anusha Srivatsa wrote:
> Return silently without producing much noise on platforms
> that have a HuC but the firmware is absent.
Matches what's done for GuC.
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
> Cc: Ander Conselvan De Oliveira <ander.conselvan.de.oliveira@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@itel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> drivers/gpu/drm/i915/intel_huc.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_huc.c b/drivers/gpu/drm/i915/intel_huc.c
> index c28543d..e660109 100644
> --- a/drivers/gpu/drm/i915/intel_huc.c
> +++ b/drivers/gpu/drm/i915/intel_huc.c
> @@ -181,12 +181,14 @@ void intel_huc_init(struct drm_i915_private *dev_priv)
> }
>
> huc_fw->path = fw_path;
> +
> + if (huc_fw->path == NULL)
> + return;
> +
> huc_fw->fetch_status = INTEL_UC_FIRMWARE_PENDING;
>
> DRM_DEBUG_DRIVER("HuC firmware pending, path %s\n", fw_path);
>
> - WARN(huc_fw->path == NULL, "HuC present but no fw path\n");
> -
> intel_uc_fw_fetch(dev_priv, huc_fw);
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ✓ Fi.CI.BAT: success for i915/HuC: Add an extra check for platforms that do not have HUC
2017-03-02 11:17 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2017-03-02 14:18 ` Ander Conselvan De Oliveira
0 siblings, 0 replies; 5+ messages in thread
From: Ander Conselvan De Oliveira @ 2017-03-02 14:18 UTC (permalink / raw)
To: intel-gfx, Anusha Srivatsa
On Thu, 2017-03-02 at 11:17 +0000, Patchwork wrote:
> == Series Details ==
>
> Series: i915/HuC: Add an extra check for platforms that do not have HUC
> URL : https://patchwork.freedesktop.org/series/20482/
> State : success
Pushed. Thanks for the patch.
Ander
>
> == Summary ==
>
> Series 20482v1 i915/HuC: Add an extra check for platforms that do not have HUC
> https://patchwork.freedesktop.org/api/1.0/series/20482/revisions/1/mbox/
>
> Test pm_rpm:
> Subgroup basic-pci-d3-state:
> incomplete -> PASS (fi-byt-n2820) fdo#99740
>
> fdo#99740 https://bugs.freedesktop.org/show_bug.cgi?id=99740
>
> fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11
> fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39
> fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19
> fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20
> fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27
> fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31
> fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16
> fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16
> fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50
> fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18
> fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18
> fi-kbl-7500u total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18
> fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10
> fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17
> fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18
> fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10
> fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28
> fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29
>
> b3c4a574937b2256a716b23037c8b94ffebd7c8a drm-tip: 2017y-03m-02d-08h-59m-08s UTC integration manifest
> 51adfd1 i915/HuC: Add an extra check for platforms that do not have HUC
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4030/
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-02 14:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-01 19:58 [PATCH] i915/HuC: Add an extra check for platforms that do not have HUC Anusha Srivatsa
2017-03-01 21:48 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-03-02 11:17 ` ✓ Fi.CI.BAT: success " Patchwork
2017-03-02 14:18 ` Ander Conselvan De Oliveira
2017-03-02 14:14 ` [PATCH] " Ander Conselvan De Oliveira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.