From: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Greta Zhang <greta.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled
Date: Thu, 23 Jul 2015 19:37:03 +0200 [thread overview]
Message-ID: <1488521.5eJqASov2O@ubix> (raw)
In-Reply-To: <1437630551-39650-3-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Thursday, July 23, 2015 01:49:11 PM Eddie Huang wrote:
> From: Greta Zhang <greta.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>
> Without .shutdown(), watchdog might reset the system during power off.
> For example, if watchdog's timeout is set to 30s, then it is reset to
> zero by mtk_wdt_ping(). During power off, no app will ping watchdog,
> but watchdog is still running and may trigger reset.
>
> Signed-off-by: Greta Zhang <greta.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> drivers/watchdog/mtk_wdt.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Acked-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Eddie Huang <eddie.huang@mediatek.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
Greta Zhang <greta.zhang@mediatek.com>
Subject: Re: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled
Date: Thu, 23 Jul 2015 19:37:03 +0200 [thread overview]
Message-ID: <1488521.5eJqASov2O@ubix> (raw)
In-Reply-To: <1437630551-39650-3-git-send-email-eddie.huang@mediatek.com>
On Thursday, July 23, 2015 01:49:11 PM Eddie Huang wrote:
> From: Greta Zhang <greta.zhang@mediatek.com>
>
> Without .shutdown(), watchdog might reset the system during power off.
> For example, if watchdog's timeout is set to 30s, then it is reset to
> zero by mtk_wdt_ping(). During power off, no app will ping watchdog,
> but watchdog is still running and may trigger reset.
>
> Signed-off-by: Greta Zhang <greta.zhang@mediatek.com>
> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
> ---
> drivers/watchdog/mtk_wdt.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled
Date: Thu, 23 Jul 2015 19:37:03 +0200 [thread overview]
Message-ID: <1488521.5eJqASov2O@ubix> (raw)
In-Reply-To: <1437630551-39650-3-git-send-email-eddie.huang@mediatek.com>
On Thursday, July 23, 2015 01:49:11 PM Eddie Huang wrote:
> From: Greta Zhang <greta.zhang@mediatek.com>
>
> Without .shutdown(), watchdog might reset the system during power off.
> For example, if watchdog's timeout is set to 30s, then it is reset to
> zero by mtk_wdt_ping(). During power off, no app will ping watchdog,
> but watchdog is still running and may trigger reset.
>
> Signed-off-by: Greta Zhang <greta.zhang@mediatek.com>
> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
> ---
> drivers/watchdog/mtk_wdt.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
next prev parent reply other threads:[~2015-07-23 17:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 5:49 [PATCH v2 0/2] Add Mediatek watchdog suspend resume and shutdown Eddie Huang
2015-07-23 5:49 ` Eddie Huang
2015-07-23 5:49 ` Eddie Huang
[not found] ` <1437630551-39650-1-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-07-23 5:49 ` [PATCH v2 1/2] watchdog: add wdt suspend/resume support Eddie Huang
2015-07-23 5:49 ` Eddie Huang
2015-07-23 5:49 ` Eddie Huang
[not found] ` <1437630551-39650-2-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-07-23 16:10 ` Guenter Roeck
2015-07-23 16:10 ` Guenter Roeck
2015-07-23 16:10 ` Guenter Roeck
2015-07-23 17:36 ` Matthias Brugger
2015-07-23 17:36 ` Matthias Brugger
2015-07-23 17:36 ` Matthias Brugger
2015-07-23 5:49 ` [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled Eddie Huang
2015-07-23 5:49 ` Eddie Huang
2015-07-23 5:49 ` Eddie Huang
[not found] ` <1437630551-39650-3-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-07-23 16:12 ` Guenter Roeck
2015-07-23 16:12 ` Guenter Roeck
2015-07-23 16:12 ` Guenter Roeck
2015-07-23 17:37 ` Matthias Brugger [this message]
2015-07-23 17:37 ` Matthias Brugger
2015-07-23 17:37 ` Matthias Brugger
2015-08-11 4:28 ` Daniel Kurtz
2015-08-11 4:28 ` Daniel Kurtz
2015-08-11 4:28 ` Daniel Kurtz
[not found] ` <CAGS+omD1UYSTfJ4-vZSE_BYuvGcTvpbC7T4ukaV10xuQxkCChg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-11 4:42 ` Guenter Roeck
2015-08-11 4:42 ` Guenter Roeck
2015-08-11 4:42 ` Guenter Roeck
2015-08-11 7:38 ` Daniel Kurtz
2015-08-11 7:38 ` Daniel Kurtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488521.5eJqASov2O@ubix \
--to=matthias.bgg-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=greta.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.