[nvmet/nvmetcli]- bug/break in setting a host on NVMe Target?

[nvmet/nvmetcli]- bug/break in setting a host on NVMe Target?

[J Freyensee]

Christoph,

I think something might have broke being able to use nvmetcli to set up a host
nqn name interactively?

Just following a simple example with mainline 4.10 kernel (tag - v4.10):

[stg at localhost nvmetcli]$ sudo ./nvmetcli?
/> cd /hosts
/hosts> create hostnqn
'module' object has no attribute 'Host'
/hosts>?

but if I hand-write the equivalent JSON file and load the target with that
there seems to be no issue:

[stg at localhost nvmetcli]$ sudo cat test.json?
{
? "hosts": [
? {
	"nqn": "hostnqn"
? }
? ],?
? "ports": [],?
? "subsystems": [
????{
????}
? ]
}

[stg at localhost nvmetcli]$ sudo ./nvmetcli restore test.json?
[stg at localhost nvmetcli]$ sudo ./nvmetcli?
/hosts> ls
o- hosts .................................................................
[...]
? o- hostnqn .............................................................
[...]
/hosts>?

Setting up a subsystem interactively is no issue:
[stg at localhost nvmetcli]$ sudo ./nvmetcli clear
[stg at localhost nvmetcli]$ sudo ./nvmetcli
/hosts> ls
o- hosts .................................................................
[...]
/hosts> cd ../subsystems?
/subsystems> create testnqn
/subsystems> ls
o- subsystems ............................................................
[...]
? o- testnqn .............................................................
[...]
????o- allowed_hosts .....................................................
[...]
????o- namespaces ........................................................
[...]
/subsystems>?

I haven't figured what is causing the problem yet.

[nvmet/nvmetcli]- bug/break in setting a host on NVMe Target?

[J Freyensee]

On Fri, 2017-03-03@17:33 -0800, J Freyensee wrote:
> Christoph,
> 
> I think something might have broke being able to use nvmetcli to set up a
> host
> nqn name interactively?

Also seeing a similar issue for /ports, I didn't have a problem setting ports/
by hand-writing a .json file but ./nvmetcli is having a problem doing it
interactively.

[nvmet/nvmetcli]- bug/break in setting a host on NVMe Target?

[Mauro Rodrigues]

Hi James!

I just sent, earlier today, a couple of patches[0] to fix the issue to
setup Hosts and Ports interactively. There are also some other fixes in
the patch series.

[0] - http://lists.infradead.org/pipermail/linux-nvme/2017-March/008940.html

--
Mauro Rodrigues

[nvmet/nvmetcli]- bug/break in setting a host on NVMe Target?

[Sagi Grimberg]

On 27/03/17 21:44, Mauro Rodrigues wrote:
> Hi James!
>
> I just sent, earlier today, a couple of patches[0] to fix the issue to
> setup Hosts and Ports interactively. There are also some other fixes in
> the patch series.
>
> [0] - http://lists.infradead.org/pipermail/linux-nvme/2017-March/008940.html

Christoph, care to take it?

Tested-by: Sagi Grimberg <sagi at grimberg.me>