[PATCH] gcc-runtime: Add libmpx supprt for x86

[PATCH] gcc-runtime: Add libmpx supprt for x86

[Richard Purdie]

Enabling building the Intel Memory Protection Extension library for x86.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-devtools/gcc/gcc-runtime.inc | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc b/meta/recipes-devtools/gcc/gcc-runtime.inc
index 745cf74..614b070 100644
--- a/meta/recipes-devtools/gcc/gcc-runtime.inc
+++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
@@ -24,8 +24,8 @@ RUNTIMELIBITM_microblaze = ""
 RUNTIMETARGET = "libssp libstdc++-v3 libgomp libatomic ${RUNTIMELIBITM} \
     ${@bb.utils.contains_any('FORTRAN', [',fortran',',f77'], 'libquadmath', '', d)} \
 "
+RUNTIMETARGET_append_x86 = " libmpx"
 
-#  ?
 # libiberty
 # libmudflap
 # libgfortran needs separate recipe due to libquadmath dependency
@@ -139,6 +139,11 @@ PACKAGES = "\
     libitm-dev \
     libitm-staticdev \
 "
+PACKAGES_append_x86 = "\
+    libmpx \
+    libmpx-dev \
+    libmpx-staticdev \
+"
 
 # The base package doesn't exist, so we clear the recommends.
 RRECOMMENDS_${PN}-dbg = ""
@@ -243,6 +248,19 @@ SUMMARY_libitm-dev = "GNU transactional memory support library - development fil
 FILES_libitm-staticdev = "${libdir}/libitm.a"
 SUMMARY_libitm-staticdev = "GNU transactional memory support library - static development files"
 
+
+FILES_libmpx = "${libdir}/libmpx.so.* ${libdir}/libmpxwrappers.so.*"
+SUMMARY_libmpx = "Intel Memory Protection Extension library"
+FILES_libmpx-dev = "\
+    ${libdir}/libmpxwrappers.so \
+    ${libdir}/libmpx.so \
+    ${libdir}/libmpx.la \
+    ${libdir}/libmpx.spec \
+"
+SUMMARY_libmpx-dev = "Intel Memory Protection Extension library - development files"
+FILES_libmpx-staticdev = "${libdir}/libmpx.a ${libdir}/libmpxwrappers.a"
+SUMMARY_libmpx-staticdev = "Intel Memory Protection Extension library - static development files"
+
 do_package_write_ipk[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
 do_package_write_deb[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
 do_package_write_rpm[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
-- 
2.7.4

Re: [PATCH] gcc-runtime: Add libmpx supprt for x86

[Khem Raj]

On Fri, Mar 3, 2017 at 3:54 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Enabling building the Intel Memory Protection Extension library for x86.
>

hope this works on amd chips as well ?

> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-devtools/gcc/gcc-runtime.inc | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc b/meta/recipes-devtools/gcc/gcc-runtime.inc
> index 745cf74..614b070 100644
> --- a/meta/recipes-devtools/gcc/gcc-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
> @@ -24,8 +24,8 @@ RUNTIMELIBITM_microblaze = ""
>  RUNTIMETARGET = "libssp libstdc++-v3 libgomp libatomic ${RUNTIMELIBITM} \
>      ${@bb.utils.contains_any('FORTRAN', [',fortran',',f77'], 'libquadmath', '', d)} \
>  "
> +RUNTIMETARGET_append_x86 = " libmpx"
>
> -#  ?
>  # libiberty
>  # libmudflap
>  # libgfortran needs separate recipe due to libquadmath dependency
> @@ -139,6 +139,11 @@ PACKAGES = "\
>      libitm-dev \
>      libitm-staticdev \
>  "
> +PACKAGES_append_x86 = "\
> +    libmpx \
> +    libmpx-dev \
> +    libmpx-staticdev \
> +"
>
>  # The base package doesn't exist, so we clear the recommends.
>  RRECOMMENDS_${PN}-dbg = ""
> @@ -243,6 +248,19 @@ SUMMARY_libitm-dev = "GNU transactional memory support library - development fil
>  FILES_libitm-staticdev = "${libdir}/libitm.a"
>  SUMMARY_libitm-staticdev = "GNU transactional memory support library - static development files"
>
> +
> +FILES_libmpx = "${libdir}/libmpx.so.* ${libdir}/libmpxwrappers.so.*"
> +SUMMARY_libmpx = "Intel Memory Protection Extension library"
> +FILES_libmpx-dev = "\
> +    ${libdir}/libmpxwrappers.so \
> +    ${libdir}/libmpx.so \
> +    ${libdir}/libmpx.la \
> +    ${libdir}/libmpx.spec \
> +"
> +SUMMARY_libmpx-dev = "Intel Memory Protection Extension library - development files"
> +FILES_libmpx-staticdev = "${libdir}/libmpx.a ${libdir}/libmpxwrappers.a"
> +SUMMARY_libmpx-staticdev = "Intel Memory Protection Extension library - static development files"
> +
>  do_package_write_ipk[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
>  do_package_write_deb[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
>  do_package_write_rpm[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] gcc-runtime: Add libmpx supprt for x86

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

On 3 March 2017 at 21:39, Khem Raj <raj.khem@gmail.com> wrote:

> > Enabling building the Intel Memory Protection Extension library for x86.
> >
>
> hope this works on amd chips as well ?


https://en.wikipedia.org/wiki/Intel_MPX

It depends on new instructions, so you'll have to ask AMD. :)

Ross

[-- Attachment #2: Type: text/html, Size: 892 bytes --]

Re: [PATCH] gcc-runtime: Add libmpx supprt for x86

[Khem Raj]

On Fri, Mar 3, 2017 at 2:54 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 3 March 2017 at 21:39, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> > Enabling building the Intel Memory Protection Extension library for x86.
>> >
>>
>> hope this works on amd chips as well ?
>
>
> https://en.wikipedia.org/wiki/Intel_MPX
>
> It depends on new instructions, so you'll have to ask AMD. :)

OK if its not so then perhaps a bbappend in meta-intel is more appropriate.

>
> Ross

Re: [PATCH] gcc-runtime: Add libmpx supprt for x86

[Richard Purdie]

On Fri, 2017-03-03 at 14:58 -0800, Khem Raj wrote:
> On Fri, Mar 3, 2017 at 2:54 PM, Burton, Ross <ross.burton@intel.com>
> wrote:
> > 
> > 
> > On 3 March 2017 at 21:39, Khem Raj <raj.khem@gmail.com> wrote:
> > > 
> > > 
> > > > 
> > > > Enabling building the Intel Memory Protection Extension library
> > > > for x86.
> > > > 
> > > hope this works on amd chips as well ?
> > 
> > https://en.wikipedia.org/wiki/Intel_MPX
> > 
> > It depends on new instructions, so you'll have to ask AMD. :)
> OK if its not so then perhaps a bbappend in meta-intel is more
> appropriate.

Well, its part of gcc, not something meta-intel is patching in and its
a standard which other arches can implement, maybe in their own library
so I believe the recipe is the better place for this to live. I just
copied the description from the code iirc.

Incidentally, this fails to build on musl so I've just disabled it on
musl for now.

Cheers,

Richard

Re: [PATCH] gcc-runtime: Add libmpx supprt for x86

[Khem Raj]

On Sat, Mar 4, 2017 at 2:54 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2017-03-03 at 14:58 -0800, Khem Raj wrote:
>> On Fri, Mar 3, 2017 at 2:54 PM, Burton, Ross <ross.burton@intel.com>
>> wrote:
>> >
>> >
>> > On 3 March 2017 at 21:39, Khem Raj <raj.khem@gmail.com> wrote:
>> > >
>> > >
>> > > >
>> > > > Enabling building the Intel Memory Protection Extension library
>> > > > for x86.
>> > > >
>> > > hope this works on amd chips as well ?
>> >
>> > https://en.wikipedia.org/wiki/Intel_MPX
>> >
>> > It depends on new instructions, so you'll have to ask AMD. :)
>> OK if its not so then perhaps a bbappend in meta-intel is more
>> appropriate.
>
> Well, its part of gcc, not something meta-intel is patching in and its
> a standard which other arches can implement, maybe in their own library
> so I believe the recipe is the better place for this to live. I just
> copied the description from the code iirc.
>

I think its ok on second thought if its the case where it will be used
more often then probably a provision to be able to remove it from a
soc layer
would be enough

> Incidentally, this fails to build on musl so I've just disabled it on
> musl for now.
>

OK

> Cheers,
>
> Richard

Re: [PATCH] gcc-runtime: Add libmpx supprt for x86

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2104 bytes --]

Seems to cause following QA issue for DISTROs which don't
inherit remove-libtool.bbclass

ERROR: gcc-runtime-6.3.0-r0 do_package: QA Issue: gcc-runtime:
Files/directories were installed but not shipped in any package:
  /usr/lib/libmpxwrappers.la
Please set FILES such that these items are packaged. Alternatively if they
are unneeded, avoid installing them or delete them within do_install.
gcc-runtime: 1 installed and not shipped files. [installed-vs-shipped]


On Sat, Mar 4, 2017 at 7:58 PM, Khem Raj <raj.khem@gmail.com> wrote:

> On Sat, Mar 4, 2017 at 2:54 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2017-03-03 at 14:58 -0800, Khem Raj wrote:
> >> On Fri, Mar 3, 2017 at 2:54 PM, Burton, Ross <ross.burton@intel.com>
> >> wrote:
> >> >
> >> >
> >> > On 3 March 2017 at 21:39, Khem Raj <raj.khem@gmail.com> wrote:
> >> > >
> >> > >
> >> > > >
> >> > > > Enabling building the Intel Memory Protection Extension library
> >> > > > for x86.
> >> > > >
> >> > > hope this works on amd chips as well ?
> >> >
> >> > https://en.wikipedia.org/wiki/Intel_MPX
> >> >
> >> > It depends on new instructions, so you'll have to ask AMD. :)
> >> OK if its not so then perhaps a bbappend in meta-intel is more
> >> appropriate.
> >
> > Well, its part of gcc, not something meta-intel is patching in and its
> > a standard which other arches can implement, maybe in their own library
> > so I believe the recipe is the better place for this to live. I just
> > copied the description from the code iirc.
> >
>
> I think its ok on second thought if its the case where it will be used
> more often then probably a provision to be able to remove it from a
> soc layer
> would be enough
>
> > Incidentally, this fails to build on musl so I've just disabled it on
> > musl for now.
> >
>
> OK
>
> > Cheers,
> >
> > Richard
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3373 bytes --]

Re: [PATCH] gcc-runtime: Add libmpx supprt for x86

[Richard Purdie]

On Wed, 2017-03-08 at 01:00 +0100, Martin Jansa wrote:
> Seems to cause following QA issue for DISTROs which don't
> inherit remove-libtool.bbclass
> 
> ERROR: gcc-runtime-6.3.0-r0 do_package: QA Issue: gcc-runtime:
> Files/directories were installed but not shipped in any package:
>   /usr/lib/libmpxwrappers.la
> Please set FILES such that these items are packaged. Alternatively if
> they are unneeded, avoid installing them or delete them within
> do_install.
> gcc-runtime: 1 installed and not shipped files. [installed-vs-
> shipped]

Sorry, thanks for the fix.

Cheers,

Richard