From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: use correct node for handling cache domain eviction
Date: Mon, 06 Mar 2017 20:34:48 +0200 [thread overview]
Message-ID: <1488825288.4701.2.camel@linux.intel.com> (raw)
In-Reply-To: <20170303181818.GJ5997@nuc-i3427.alporthouse.com>
On pe, 2017-03-03 at 18:18 +0000, Chris Wilson wrote:
> On Fri, Mar 03, 2017 at 06:03:34PM +0000, Matthew Auld wrote:
> >
> > It looks like we were incorrectly comparing vma->node against itself
> > instead of the target node, when evicting for a node on systems where we
> > need guard pages between regions with different cache domains. As a
> > consequence we can end up trying to needlessly evict neighbouring nodes,
> > even if they have the same cache domain, and if they were pinned we
> > would fail the eviction.
> >
> > Fixes: 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a helper")
> > Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> /o\
> -Chris
Good catch, will merge the series once the comments on patch 2 are
addressed.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-06 18:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 18:03 [PATCH 1/2] drm/i915: use correct node for handling cache domain eviction Matthew Auld
2017-03-03 18:03 ` [PATCH 2/2] drm/i915/selftests: exercise " Matthew Auld
2017-03-03 18:28 ` Chris Wilson
2017-03-03 18:18 ` [PATCH 1/2] drm/i915: use correct node for handling " Chris Wilson
2017-03-06 18:34 ` Joonas Lahtinen [this message]
2017-03-03 18:48 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488825288.4701.2.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.