[PATCH 1/2] xf86-video-imxfb-vivante: silence xorg-abi- warning

[PATCH 1/2] xf86-video-imxfb-vivante: silence xorg-abi- warning

[Max Krummenacher]

xf86-video-imxfb-vivante is built against the X-Server's sources, thus there
is no need to check if the correct ABI is used between driver and server.

This inhibits:
WARNING: xf86-video-imxfb-vivante-3_5.0.11.p8.6-r0 do_package_qa: QA Issue:
  Package xf86-video-imxfb-vivante contains Xorg driver (vivante_drv.so)
  but no xorg-abi- dependencies [xorg-driver-abi]

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
 recipes-graphics/xorg-driver/xf86-video-imxfb-vivante.inc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante.inc b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante.inc
index 8bac151..c34ab9d 100644
--- a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante.inc
+++ b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante.inc
@@ -15,6 +15,9 @@ LIC_FILES_CHKSUM = "file://COPYING-MIT;md5=b5e9d9f5c02ea831ab3ecf802bb7c4f3"
 SRC_URI = "${FSL_MIRROR}/xserver-xorg-video-imx-viv-${PV}.tar.gz \
             file://rc.autohdmi"
 
+# We build against the xserver sources, so the correct ABI is used.
+INSANE_SKIP_${PN} = "xorg-driver-abi"
+
 INITSCRIPT_PACKAGES = "xserver-xorg-extension-viv-autohdmi"
 INITSCRIPT_NAME = "rc.autohdmi"
 INITSCRIPT_PARAMS = "start 99 2 3 4 5 ."
-- 
2.6.6

[PATCH 2/2] xf86-video-imxfb-vivante: cleanup

[Max Krummenacher]

The build starts since commit meta-fsl-arm da0581341a58dfe393a829b3c402330c73589963
with the make file in ${S} which is actually named Makefile, thus there is no
need to override base.do_compile or pass the directory and name of the
make file in EXTRA_OEMAKE.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
 recipes-graphics/xorg-driver/xf86-video-imxfb-vivante.inc | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante.inc b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante.inc
index c34ab9d..8c3489b 100644
--- a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante.inc
+++ b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante.inc
@@ -22,7 +22,7 @@ INITSCRIPT_PACKAGES = "xserver-xorg-extension-viv-autohdmi"
 INITSCRIPT_NAME = "rc.autohdmi"
 INITSCRIPT_PARAMS = "start 99 2 3 4 5 ."
 
-EXTRA_OEMAKE += "-C ${S} -f Makefile prefix=${D}/usr \
+EXTRA_OEMAKE += "prefix=${D}/usr \
                  sysroot=${STAGING_DIR_TARGET} \
                  LFLAGS="${LDFLAGS}" \
                  BUSID_HAS_NUMBER=1 \
@@ -45,13 +45,6 @@ do_configure_prepend () {
             ${S}EXA/src/makefile.linux
 }
 
-# FIXME: This is need as Freescale didn't use standard Makefile filename
-#        thus oe_runmame thinks nothing is need to be done, use ln to
-#        workaround it.
-base_do_compile () {
-    oe_runmake || die "make failed"
-}
-
 do_install_append () {
 	install -d ${D}${includedir}
 	cp -axr ${S}/EXA/src/vivante_gal/vivante_priv.h ${D}${includedir}
-- 
2.6.6

Re: [PATCH 1/2] xf86-video-imxfb-vivante: silence xorg-abi- warning

[Otavio Salvador]

On Sat, Feb 25, 2017 at 1:43 PM, Max Krummenacher <max.oss.09@gmail.com> wrote:
> xf86-video-imxfb-vivante is built against the X-Server's sources, thus there
> is no need to check if the correct ABI is used between driver and server.
>
> This inhibits:
> WARNING: xf86-video-imxfb-vivante-3_5.0.11.p8.6-r0 do_package_qa: QA Issue:
>   Package xf86-video-imxfb-vivante contains Xorg driver (vivante_drv.so)
>   but no xorg-abi- dependencies [xorg-driver-abi]
>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

Wrong. We should add the dependencies. It is specially important to
support package feeds.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH 1/2] xf86-video-imxfb-vivante: silence xorg-abi- warning

[Max Krummenacher]

Am Montag, den 06.03.2017, 10:23 -0300 schrieb Otavio Salvador:
> On Sat, Feb 25, 2017 at 1:43 PM, Max Krummenacher <max.oss.09@gmail.com> wrote:
> > xf86-video-imxfb-vivante is built against the X-Server's sources, thus there
> > is no need to check if the correct ABI is used between driver and server.
> > 
> > This inhibits:
> > WARNING: xf86-video-imxfb-vivante-3_5.0.11.p8.6-r0 do_package_qa: QA Issue:
> >   Package xf86-video-imxfb-vivante contains Xorg driver (vivante_drv.so)
> >   but no xorg-abi- dependencies [xorg-driver-abi]
> > 
> > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Wrong. We should add the dependencies. It is specially important to
> support package feeds.

Ok.

I found the culprit. Will send a V2 shortly.

Max