From: Ley Foon Tan <ley.foon.tan@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 15/20] drivers: Makefile: include fpga build in SPL
Date: Tue, 07 Mar 2017 10:52:58 +0800 [thread overview]
Message-ID: <1488855178.2433.26.camel@intel.com> (raw)
In-Reply-To: <a1b50330-4de2-03e8-41fc-3b9860c7c828@xilinx.com>
On Isn, 2017-02-27 at 17:06 +0100, Michal Simek wrote:
> On 25.2.2017 22:44, Marek Vasut wrote:
> >
> > On 02/22/2017 10:47 AM, Ley Foon Tan wrote:
> > >
> > > Arria 10 SPL needs the drivers/fpga.
> > >
> > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> > > ---
> > > drivers/Makefile | 1 +
> > +CC Michal and Moritz, they did some FPGA/SPL work too.
> >
> > >
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/Makefile b/drivers/Makefile
> > > index 34c55bf..6e7a2c3 100644
> > > --- a/drivers/Makefile
> > > +++ b/drivers/Makefile
> > > @@ -47,6 +47,7 @@ obj-$(CONFIG_OMAP_USB_PHY) += usb/phy/
> > > obj-$(CONFIG_SPL_SATA_SUPPORT) += block/
> > > obj-$(CONFIG_SPL_USB_HOST_SUPPORT) += block/
> > > obj-$(CONFIG_SPL_MMC_SUPPORT) += block/
> > > +obj-$(CONFIG_FPGA) += fpga/
> > > endif
> > >
> > > ifdef CONFIG_TPL_BUILD
> > >
> >
> I prefer if you can separate these fpga stuff out of this huge
> series.
> This patch doesn't make sense without content.
>
> I can't see that code which requires this.
> The biggest questions here are where are you calling fpga code and
> where
> are you taking bitstream from?
>
> Thanks,
> Michal
>
>
Okay, will drop this patch from this series.
Thanks.
Regards
Ley Foon
next prev parent reply other threads:[~2017-03-07 2:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 9:47 [U-Boot] [PATCH 00/20] Add Intel Arria 10 SoC support Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 01/20] arm: socfpga: restructure clock manager driver Ley Foon Tan
2017-02-25 21:18 ` Marek Vasut
2017-02-27 8:36 ` Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 02/20] arm: socfpga: restructure reset " Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 03/20] arm: socfpga: restructure misc driver Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 04/20] arm: socfpga: restructure system manager Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 05/20] arm: socfpga: add A10 defines Ley Foon Tan
2017-02-25 21:20 ` Marek Vasut
[not found] ` <1488188711.2424.10.camel@intel.com>
2017-02-27 10:00 ` Marek Vasut
2017-02-22 9:47 ` [U-Boot] [PATCH 06/20] arm: socfpga: add reset driver support for Arria 10 Ley Foon Tan
2017-02-25 21:28 ` Marek Vasut
2017-02-27 10:14 ` Ley Foon Tan
2017-02-27 10:19 ` Marek Vasut
2017-02-28 2:31 ` Ley Foon Tan
2017-02-28 8:27 ` Ley Foon Tan
2017-02-28 8:39 ` Marek Vasut
2017-02-22 9:47 ` [U-Boot] [PATCH 07/20] arm: socfpga: add clock driver " Ley Foon Tan
2017-02-25 21:35 ` Marek Vasut
2017-03-06 7:10 ` Ley Foon Tan
2017-03-07 3:48 ` Marek Vasut
2017-02-22 9:47 ` [U-Boot] [PATCH 08/20] arm: socfpga: add system manager " Ley Foon Tan
2017-02-25 21:36 ` Marek Vasut
2017-03-06 7:39 ` Ley Foon Tan
2017-03-07 3:49 ` Marek Vasut
2017-03-07 9:07 ` Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 09/20] arm: socfpga: add sdram header file " Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 10/20] arm: socfpga: add misc support " Ley Foon Tan
2017-02-25 21:40 ` Marek Vasut
2017-03-06 8:00 ` Ley Foon Tan
2017-03-07 3:50 ` Marek Vasut
2017-02-22 9:47 ` [U-Boot] [PATCH 11/20] arm: socfpga: add pinmux " Ley Foon Tan
2017-02-25 21:41 ` Marek Vasut
2017-03-06 8:08 ` Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 12/20] fdt: add compatible strings " Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 13/20] arm: dts: add dts and dtsi " Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 14/20] arm: socfpga: add SPL support " Ley Foon Tan
2017-02-25 21:43 ` Marek Vasut
2017-02-27 5:36 ` Chee, Tien Fong
2017-03-07 2:51 ` Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 15/20] drivers: Makefile: include fpga build in SPL Ley Foon Tan
2017-02-25 21:44 ` Marek Vasut
2017-02-27 16:06 ` Michal Simek
2017-03-07 2:52 ` Ley Foon Tan [this message]
2017-02-22 9:47 ` [U-Boot] [PATCH 16/20] drivers: fpga: add compile switch for Gen5 only registers Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 17/20] arm: socfpga: convert Altera ddr driver to use Kconfig Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 18/20] arm: socfpga: add config and defconfig for Arria 10 Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 19/20] arm: socfpga: add board files for the Arria10 Ley Foon Tan
2017-02-22 9:47 ` [U-Boot] [PATCH 20/20] arm: socfpga: enable build for Arria 10 Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488855178.2433.26.camel@intel.com \
--to=ley.foon.tan@intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.