From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] i2c: meson: fix wrong variable usage in meson_i2c_put_data
Date: Wed, 08 Mar 2017 10:17:03 +0100 [thread overview]
Message-ID: <1488964623.2514.7.camel@baylibre.com> (raw)
In-Reply-To: <7ecc4542-a6ca-f266-5c34-057b3f5a33bf@gmail.com>
On Tue, 2017-03-07 at 21:06 +0100, Heiner Kallweit wrote:
> Most likely a copy & paste error.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> ?drivers/i2c/busses/i2c-meson.c | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
> index 2aa61bbb..73b97c71 100644
> --- a/drivers/i2c/busses/i2c-meson.c
> +++ b/drivers/i2c/busses/i2c-meson.c
> @@ -175,7 +175,7 @@ static void meson_i2c_put_data(struct meson_i2c *i2c, char *buf, int len)
> ? wdata1 |= *buf++ << ((i - 4) * 8);
> ?
> ? writel(wdata0, i2c->regs + REG_TOK_WDATA0);
> - writel(wdata0, i2c->regs + REG_TOK_WDATA1);
> + writel(wdata1, i2c->regs + REG_TOK_WDATA1);
> ?
> ? dev_dbg(i2c->dev, "%s: data %08x %08x len %d\n", __func__,
> ? wdata0, wdata1, len);
Good catch, Strange it did not show up before.
You are just missing the Fixes tag.
Fixes: 30021e3707a7 ("i2c: add support for Amlogic Meson I2C controller")
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>,
Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: meson: fix wrong variable usage in meson_i2c_put_data
Date: Wed, 08 Mar 2017 10:17:03 +0100 [thread overview]
Message-ID: <1488964623.2514.7.camel@baylibre.com> (raw)
In-Reply-To: <7ecc4542-a6ca-f266-5c34-057b3f5a33bf@gmail.com>
On Tue, 2017-03-07 at 21:06 +0100, Heiner Kallweit wrote:
> Most likely a copy & paste error.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/i2c/busses/i2c-meson.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
> index 2aa61bbb..73b97c71 100644
> --- a/drivers/i2c/busses/i2c-meson.c
> +++ b/drivers/i2c/busses/i2c-meson.c
> @@ -175,7 +175,7 @@ static void meson_i2c_put_data(struct meson_i2c *i2c, char *buf, int len)
> wdata1 |= *buf++ << ((i - 4) * 8);
>
> writel(wdata0, i2c->regs + REG_TOK_WDATA0);
> - writel(wdata0, i2c->regs + REG_TOK_WDATA1);
> + writel(wdata1, i2c->regs + REG_TOK_WDATA1);
>
> dev_dbg(i2c->dev, "%s: data %08x %08x len %d\n", __func__,
> wdata0, wdata1, len);
Good catch, Strange it did not show up before.
You are just missing the Fixes tag.
Fixes: 30021e3707a7 ("i2c: add support for Amlogic Meson I2C controller")
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
next prev parent reply other threads:[~2017-03-08 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 20:06 [PATCH] i2c: meson: fix wrong variable usage in meson_i2c_put_data Heiner Kallweit
2017-03-07 20:06 ` Heiner Kallweit
2017-03-08 9:17 ` Jerome Brunet [this message]
2017-03-08 9:17 ` Jerome Brunet
2017-03-09 14:41 ` Wolfram Sang
2017-03-09 14:41 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488964623.2514.7.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.