Re: [PATCH -mm -v6 2/9] mm, memcg: Support to charge/uncharge multiple swap entries

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Balbir Singh <bsingharora@gmail.com>
To: "Huang, Ying" <ying.huang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrea Arcangeli <aarcange@redhat.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>, Tejun Heo <tj@kernel.org>,
	cgroups@vger.kernel.org
Subject: Re: [PATCH -mm -v6 2/9] mm, memcg: Support to charge/uncharge multiple swap entries
Date: Wed, 08 Mar 2017 22:37:56 +1100	[thread overview]
Message-ID: <1488973076.13674.5.camel@gmail.com> (raw)
In-Reply-To: <20170308072613.17634-3-ying.huang@intel.com>

On Wed, 2017-03-08 at 15:26 +0800, Huang, Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
> 
> This patch make it possible to charge or uncharge a set of continuous
> swap entries in the swap cgroup.  The number of swap entries is
> specified via an added parameter.
> 
> This will be used for the THP (Transparent Huge Page) swap support.
> Where a swap cluster backing a THP may be allocated and freed as a
> whole.  So a set of (HPAGE_PMD_NR) continuous swap entries backing one
> THP need to be charged or uncharged together.  This will batch the
> cgroup operations for the THP swap too.

A quick look at the patches makes it look sane. I wonder if we would
make sense to track THP swapout separately as well
(from a memory.stat perspective)

Balbir Singh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)

From: Balbir Singh <bsingharora@gmail.com>
To: "Huang, Ying" <ying.huang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrea Arcangeli <aarcange@redhat.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>, Tejun Heo <tj@kernel.org>,
	cgroups@vger.kernel.org
Subject: Re: [PATCH -mm -v6 2/9] mm, memcg: Support to charge/uncharge multiple swap entries
Date: Wed, 08 Mar 2017 22:37:56 +1100	[thread overview]
Message-ID: <1488973076.13674.5.camel@gmail.com> (raw)
In-Reply-To: <20170308072613.17634-3-ying.huang@intel.com>

On Wed, 2017-03-08 at 15:26 +0800, Huang, Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
>A 
> This patch make it possible to charge or uncharge a set of continuous
> swap entries in the swap cgroup.A A The number of swap entries is
> specified via an added parameter.
>A 
> This will be used for the THP (Transparent Huge Page) swap support.
> Where a swap cluster backing a THP may be allocated and freed as a
> whole.A A So a set of (HPAGE_PMD_NR) continuous swap entries backing one
> THP need to be charged or uncharged together.A A This will batch the
> cgroup operations for the THP swap too.

A quick look at the patches makes it look sane. I wonder if we would
make sense to track THP swapout separately as well
(from a memory.stat perspective)

Balbir Singh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)

From: Balbir Singh <bsingharora@gmail.com>
To: "Huang, Ying" <ying.huang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrea Arcangeli <aarcange@redhat.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>, Tejun Heo <tj@kernel.org>,
	cgroups@vger.kernel.org
Subject: Re: [PATCH -mm -v6 2/9] mm, memcg: Support to charge/uncharge multiple swap entries
Date: Wed, 08 Mar 2017 22:37:56 +1100	[thread overview]
Message-ID: <1488973076.13674.5.camel@gmail.com> (raw)
In-Reply-To: <20170308072613.17634-3-ying.huang@intel.com>

On Wed, 2017-03-08 at 15:26 +0800, Huang, Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
> 
> This patch make it possible to charge or uncharge a set of continuous
> swap entries in the swap cgroup.  The number of swap entries is
> specified via an added parameter.
> 
> This will be used for the THP (Transparent Huge Page) swap support.
> Where a swap cluster backing a THP may be allocated and freed as a
> whole.  So a set of (HPAGE_PMD_NR) continuous swap entries backing one
> THP need to be charged or uncharged together.  This will batch the
> cgroup operations for the THP swap too.

A quick look at the patches makes it look sane. I wonder if we would
make sense to track THP swapout separately as well
(from a memory.stat perspective)

Balbir Singh

next prev parent reply	other threads:[~2017-03-08 11:37 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08  7:26 [PATCH -v6 0/9] THP swap: Delay splitting THP during swapping out Huang, Ying
2017-03-08  7:26 ` Huang, Ying
2017-03-08  7:26 ` [PATCH -mm -v6 1/9] mm, swap: Make swap cluster size same of THP size on x86_64 Huang, Ying
2017-03-08  7:26   ` Huang, Ying
2017-03-08 12:56   ` Matthew Wilcox
2017-03-08 12:56     ` Matthew Wilcox
2017-03-09  1:45     ` Huang, Ying
2017-03-09  1:45       ` Huang, Ying
2017-03-08  7:26 ` [PATCH -mm -v6 2/9] mm, memcg: Support to charge/uncharge multiple swap entries Huang, Ying
2017-03-08  7:26   ` Huang, Ying
2017-03-08 11:37   ` Balbir Singh [this message]
2017-03-08 11:37     ` Balbir Singh
2017-03-08 11:37     ` Balbir Singh
2017-03-09  1:28     ` Huang, Ying
2017-03-09  1:28       ` Huang, Ying
2017-03-09  1:28       ` Huang, Ying
2017-03-09 21:22       ` Balbir Singh
2017-03-09 21:22         ` Balbir Singh
2017-03-08  7:26 ` [PATCH -mm -v6 3/9] mm, THP, swap: Add swap cluster allocate/free functions Huang, Ying
2017-03-08  7:26   ` Huang, Ying
2017-03-14 23:13   ` Tim Chen
2017-03-14 23:13     ` Tim Chen
2017-03-15  1:19     ` Huang, Ying
2017-03-15  1:19       ` Huang, Ying
2017-03-15 17:15       ` Tim Chen
2017-03-15 17:15         ` Tim Chen
2017-03-16  6:31         ` Huang, Ying
2017-03-16  6:31           ` Huang, Ying
2017-03-08  7:26 ` [PATCH -mm -v6 4/9] mm, THP, swap: Add get_huge_swap_page() Huang, Ying
2017-03-08  7:26   ` Huang, Ying
2017-03-14 23:40   ` Tim Chen
2017-03-14 23:40     ` Tim Chen
2017-03-15  1:08     ` Huang, Ying
2017-03-15  1:08       ` Huang, Ying
2017-03-08  7:26 ` [PATCH -mm -v6 5/9] mm, THP, swap: Support to clear SWAP_HAS_CACHE for huge page Huang, Ying
2017-03-08  7:26   ` Huang, Ying
2017-03-15  0:14   ` Tim Chen
2017-03-15  0:14     ` Tim Chen
2017-03-15  0:54     ` Huang, Ying
2017-03-15  0:54       ` Huang, Ying
2017-03-08  7:26 ` [PATCH -mm -v6 6/9] mm, THP, swap: Support to add/delete THP to/from swap cache Huang, Ying
2017-03-08  7:26   ` Huang, Ying
2017-03-08  7:26 ` [PATCH -mm -v6 7/9] mm, THP: Add can_split_huge_page() Huang, Ying
2017-03-08  7:26   ` Huang, Ying
2017-03-08  7:26 ` [PATCH -mm -v6 8/9] mm, THP, swap: Support to split THP in swap cache Huang, Ying
2017-03-08  7:26   ` Huang, Ying
2017-03-08  7:26 ` [PATCH -mm -v6 9/9] mm, THP, swap: Delay splitting THP during swap out Huang, Ying
2017-03-08  7:26   ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488973076.13674.5.camel@gmail.com \
    --to=bsingharora@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=tj@kernel.org \
    --cc=vdavydov@virtuozzo.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.