* [PATCH] drm: qxl: add missing return check
@ 2017-03-14 7:54 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-03-14 7:54 UTC (permalink / raw)
To: Dave Airlie, Gabriel Krisman Bertazi
Cc: kernel-janitors, Gerd Hoffmann, dri-devel, virtualization
My static checker complains that "release" is uninitialized if
qxl_alloc_release_reserved() fails, so let's add a check for that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 9548bb58d3bc..058340a002c2 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -572,6 +572,8 @@ static void qxl_cursor_atomic_update(struct drm_plane *plane,
ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
QXL_RELEASE_CURSOR_CMD,
&release, NULL);
+ if (ret)
+ return;
cmd = (struct qxl_cursor_cmd *) qxl_release_map(qdev, release);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm: qxl: add missing return check
@ 2017-03-14 7:54 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-03-14 7:54 UTC (permalink / raw)
To: Dave Airlie, Gabriel Krisman Bertazi
Cc: kernel-janitors, Gerd Hoffmann, dri-devel, virtualization
My static checker complains that "release" is uninitialized if
qxl_alloc_release_reserved() fails, so let's add a check for that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 9548bb58d3bc..058340a002c2 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -572,6 +572,8 @@ static void qxl_cursor_atomic_update(struct drm_plane *plane,
ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
QXL_RELEASE_CURSOR_CMD,
&release, NULL);
+ if (ret)
+ return;
cmd = (struct qxl_cursor_cmd *) qxl_release_map(qdev, release);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: qxl: add missing return check
2017-03-14 7:54 ` Dan Carpenter
@ 2017-03-14 11:02 ` Gerd Hoffmann
-1 siblings, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2017-03-14 11:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: kernel-janitors, dri-devel, virtualization, Dave Airlie,
Gabriel Krisman Bertazi
On Di, 2017-03-14 at 10:54 +0300, Dan Carpenter wrote:
> My static checker complains that "release" is uninitialized if
> qxl_alloc_release_reserved() fails, so let's add a check for that.
applied to drm-misc-next.
thanks,
Gerd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: qxl: add missing return check
2017-03-14 7:54 ` Dan Carpenter
(?)
(?)
@ 2017-03-14 11:02 ` Gerd Hoffmann
-1 siblings, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2017-03-14 11:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, kernel-janitors, dri-devel, virtualization,
Dave Airlie, Gabriel Krisman Bertazi
On Di, 2017-03-14 at 10:54 +0300, Dan Carpenter wrote:
> My static checker complains that "release" is uninitialized if
> qxl_alloc_release_reserved() fails, so let's add a check for that.
applied to drm-misc-next.
thanks,
Gerd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm: qxl: add missing return check
@ 2017-03-14 7:54 Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-03-14 7:54 UTC (permalink / raw)
To: Dave Airlie, Gabriel Krisman Bertazi
Cc: David Airlie, kernel-janitors, dri-devel, virtualization
My static checker complains that "release" is uninitialized if
qxl_alloc_release_reserved() fails, so let's add a check for that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 9548bb58d3bc..058340a002c2 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -572,6 +572,8 @@ static void qxl_cursor_atomic_update(struct drm_plane *plane,
ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
QXL_RELEASE_CURSOR_CMD,
&release, NULL);
+ if (ret)
+ return;
cmd = (struct qxl_cursor_cmd *) qxl_release_map(qdev, release);
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-14 11:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-14 7:54 [PATCH] drm: qxl: add missing return check Dan Carpenter
2017-03-14 7:54 ` Dan Carpenter
2017-03-14 11:02 ` Gerd Hoffmann
2017-03-14 11:02 ` Gerd Hoffmann
2017-03-14 11:02 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2017-03-14 7:54 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.