From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"tom.leiming@gmail.com" <tom.leiming@gmail.com>,
"axboe@fb.com" <axboe@fb.com>
Cc: "yizhan@redhat.com" <yizhan@redhat.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler
Date: Thu, 16 Mar 2017 21:37:23 +0000 [thread overview]
Message-ID: <1489700230.2574.18.camel@sandisk.com> (raw)
In-Reply-To: <1489064578-17305-3-git-send-email-tom.leiming@gmail.com>
On Thu, 2017-03-09 at 21:02 +0800, Ming Lei wrote:
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 159187a28d66..0aff380099d5 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -697,17 +697,8 @@ static void blk_mq_check_expired(struct blk_mq_hw_ct=
x *hctx,
> {
> struct blk_mq_timeout_data *data =3D priv;
> =20
> - if (!test_bit(REQ_ATOM_STARTED, &rq->atomic_flags)) {
> - /*
> - * If a request wasn't started before the queue was
> - * marked dying, kill it here or it'll go unnoticed.
> - */
> - if (unlikely(blk_queue_dying(rq->q))) {
> - rq->errors =3D -EIO;
> - blk_mq_end_request(rq, rq->errors);
> - }
> + if (!test_bit(REQ_ATOM_STARTED, &rq->atomic_flags))
> return;
> - }
> =20
> if (time_after_eq(jiffies, rq->deadline)) {
> if (!blk_mark_rq_complete(rq))
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>=
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"tom.leiming@gmail.com" <tom.leiming@gmail.com>,
"axboe@fb.com" <axboe@fb.com>
Cc: "yizhan@redhat.com" <yizhan@redhat.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler
Date: Thu, 16 Mar 2017 21:37:23 +0000 [thread overview]
Message-ID: <1489700230.2574.18.camel@sandisk.com> (raw)
In-Reply-To: <1489064578-17305-3-git-send-email-tom.leiming@gmail.com>
On Thu, 2017-03-09 at 21:02 +0800, Ming Lei wrote:
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 159187a28d66..0aff380099d5 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -697,17 +697,8 @@ static void blk_mq_check_expired(struct blk_mq_hw_ctx *hctx,
> {
> struct blk_mq_timeout_data *data = priv;
>
> - if (!test_bit(REQ_ATOM_STARTED, &rq->atomic_flags)) {
> - /*
> - * If a request wasn't started before the queue was
> - * marked dying, kill it here or it'll go unnoticed.
> - */
> - if (unlikely(blk_queue_dying(rq->q))) {
> - rq->errors = -EIO;
> - blk_mq_end_request(rq, rq->errors);
> - }
> + if (!test_bit(REQ_ATOM_STARTED, &rq->atomic_flags))
> return;
> - }
>
> if (time_after_eq(jiffies, rq->deadline)) {
> if (!blk_mark_rq_complete(rq))
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
next prev parent reply other threads:[~2017-03-16 21:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 13:02 [PATCH 0/2] blk-mq: dying queue fix & improvement Ming Lei
2017-03-09 13:02 ` Ming Lei
2017-03-09 13:02 ` [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler Ming Lei
2017-03-15 0:07 ` Bart Van Assche
2017-03-15 0:07 ` Bart Van Assche
2017-03-15 12:18 ` Ming Lei
2017-03-15 12:40 ` Ming Lei
2017-03-15 15:36 ` Bart Van Assche
2017-03-15 15:36 ` Bart Van Assche
2017-03-15 16:22 ` Ming Lei
2017-03-15 16:22 ` Ming Lei
2017-03-15 16:46 ` Ming Lei
2017-03-15 21:35 ` Bart Van Assche
2017-03-15 21:35 ` Bart Van Assche
2017-03-16 0:07 ` Ming Lei
2017-03-16 0:07 ` Ming Lei
2017-03-16 21:35 ` Bart Van Assche
2017-03-16 21:35 ` Bart Van Assche
2017-03-17 0:07 ` Ming Lei
2017-03-15 21:34 ` Bart Van Assche
2017-03-15 21:34 ` Bart Van Assche
2017-03-15 23:41 ` Ming Lei
2017-03-15 14:11 ` Yi Zhang
2017-03-16 21:37 ` Bart Van Assche [this message]
2017-03-16 21:37 ` Bart Van Assche
2017-03-09 13:02 ` [PATCH 2/2] blk-mq: start to freeze queue just after setting dying Ming Lei
2017-03-09 16:58 ` Bart Van Assche
2017-03-09 16:58 ` Bart Van Assche
2017-03-10 2:16 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489700230.2574.18.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tom.leiming@gmail.com \
--cc=yizhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.