Re: [PATCH v7] xen: Allow a default compiled-in command line using Kconfig

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1308 bytes --]

On Tue, 2017-03-21 at 16:43 +0800, Zhongze Liu wrote:
> This allows downstreams to set their defaults without modifying the
> source code
> all over the place. Also probably useful for the embedded space.
> (See Also: https://xenproject.atlassian.net/browse/XEN-41)
> 
> Added 2 new config entries in common/Kconfig:
>     CMDLINE and CMDLINE_OVERRIDE
> Modified common/kernel.c:cmdline_parse().
> 
> The 2 new entries enable an embedded command line to be compiled
> in the hypervisor. CMDLINE depends on EXPERT = "y", and
> CMDLINE_OVERRIDE
> depends on CMDLINE != "".
> 
Well, Jan also said:

"albeit I think the commit message should have what is now the 4th
paragraph first, with what are currently 1st and 2nd paragraphs
dropped altogether."

And those "1st and 2nd paragraphs" refers to, in this version, the text
that goes from "Added 2 new..." to "...depends on CMDLINE != """,
which, for what is worth, I agree does not add much and should be
dropped.

Although it's probably not a super big deal...

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel