Re: [PATCH v1] leds: lp3952: Remove ACPI support for lp3952

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Tue, 2017-03-21 at 21:17 +0100, Pavel Machek wrote:
> On Tue 2017-03-21 21:33:15, Andy Shevchenko wrote:
> > In ACPI world any ID should be carefully chosen and registered
> > officially. The discussion as I read it gets to wilful assignment an
> > ID
> > for non-existing real DSDT example.
> > 
> > Rafael already told [2] how this device would be enumerated using
> > compatible string.
> > 
> > Based on above, remove non-official ACPI IDs and enumeration from
> > the
> > driver.
> 
> Hmm. Do any "real users" have hardware with TXNW3952 ACPI ID?

I googled for it and found only discussions I put links to (besides few
mention of the driver code itself). So, it makes me to be confident
there is quite unlikely existing one in the wild (esp. TI answers).

> 
> 									
> Pavel
> 
> > -static const struct acpi_device_id lp3952_acpi_match[] = {
> > -	{"TXNW3952", 0},
> > -	{}
> > -};
> > -
> > -MODULE_DEVICE_TABLE(acpi, lp3952_acpi_match);
> > -#endif
> > -
> >  static struct i2c_driver lp3952_i2c_driver = {
> >  	.driver = {
> >  			.name = LP3952_NAME,
> > -			.acpi_match_table =
> > ACPI_PTR(lp3952_acpi_match),
> >  	},
> >  	.probe = lp3952_probe,
> >  	.remove = lp3952_remove,
> 
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy