Re: [PATCH v1] leds: lp3952: Remove ACPI support for lp3952

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

On Tue 2017-03-21 21:33:15, Andy Shevchenko wrote:
> In ACPI world any ID should be carefully chosen and registered
> officially. The discussion as I read it gets to wilful assignment an ID
> for non-existing real DSDT example.
> 
> Rafael already told [2] how this device would be enumerated using
> compatible string.
> 
> Based on above, remove non-official ACPI IDs and enumeration from the
> driver.

Hmm. Do any "real users" have hardware with TXNW3952 ACPI ID?

									Pavel

> -static const struct acpi_device_id lp3952_acpi_match[] = {
> -	{"TXNW3952", 0},
> -	{}
> -};
> -
> -MODULE_DEVICE_TABLE(acpi, lp3952_acpi_match);
> -#endif
> -
>  static struct i2c_driver lp3952_i2c_driver = {
>  	.driver = {
>  			.name = LP3952_NAME,
> -			.acpi_match_table = ACPI_PTR(lp3952_acpi_match),
>  	},
>  	.probe = lp3952_probe,
>  	.remove = lp3952_remove,

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]