* [PATCH] native.bbclass: clear MACHINE_FEATURES
@ 2017-03-22 22:47 Andre McCurdy
2017-03-23 9:06 ` Mike Looijmans
0 siblings, 1 reply; 5+ messages in thread
From: Andre McCurdy @ 2017-03-22 22:47 UTC (permalink / raw)
To: openembedded-core
Try to avoid native recipes accidentally being dependent on
MACHINE_FEATURES. This simple change doesn't prevent MACHINE_FEATURES
set via MACHINE_FEATURES_BACKFILL sneaking through, but it's better
than nothing.
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
meta/classes/native.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/native.bbclass b/meta/classes/native.bbclass
index 6becf82..1919fbc 100644
--- a/meta/classes/native.bbclass
+++ b/meta/classes/native.bbclass
@@ -112,6 +112,7 @@ PKG_CONFIG_SYSTEM_INCLUDE_PATH[unexport] = "1"
LIBCOVERRIDE = ""
CLASSOVERRIDE = "class-native"
MACHINEOVERRIDES = ""
+MACHINE_FEATURES = ""
PATH_prepend = "${COREBASE}/scripts/native-intercept:"
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] native.bbclass: clear MACHINE_FEATURES
2017-03-22 22:47 [PATCH] native.bbclass: clear MACHINE_FEATURES Andre McCurdy
@ 2017-03-23 9:06 ` Mike Looijmans
2017-03-23 18:59 ` Andre McCurdy
0 siblings, 1 reply; 5+ messages in thread
From: Mike Looijmans @ 2017-03-23 9:06 UTC (permalink / raw)
To: openembedded-core
On 22-03-17 23:47, Andre McCurdy wrote:
> Try to avoid native recipes accidentally being dependent on
> MACHINE_FEATURES. This simple change doesn't prevent MACHINE_FEATURES
> set via MACHINE_FEATURES_BACKFILL sneaking through, but it's better
> than nothing.
Maybe this would work:
MACHINE_FEATURES_BACKFILL_CONSIDERED = "${MACHINE_FEATURES_BACKFILL}"
>
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
> meta/classes/native.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/native.bbclass b/meta/classes/native.bbclass
> index 6becf82..1919fbc 100644
> --- a/meta/classes/native.bbclass
> +++ b/meta/classes/native.bbclass
> @@ -112,6 +112,7 @@ PKG_CONFIG_SYSTEM_INCLUDE_PATH[unexport] = "1"
> LIBCOVERRIDE = ""
> CLASSOVERRIDE = "class-native"
> MACHINEOVERRIDES = ""
> +MACHINE_FEATURES = ""
>
> PATH_prepend = "${COREBASE}/scripts/native-intercept:"
>
>
Kind regards,
Mike Looijmans
System Expert
TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com
Please consider the environment before printing this e-mail
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] native.bbclass: clear MACHINE_FEATURES
2017-03-23 9:06 ` Mike Looijmans
@ 2017-03-23 18:59 ` Andre McCurdy
2017-03-23 19:09 ` Patrick Ohly
0 siblings, 1 reply; 5+ messages in thread
From: Andre McCurdy @ 2017-03-23 18:59 UTC (permalink / raw)
To: Mike Looijmans; +Cc: OE Core mailing list
On Thu, Mar 23, 2017 at 2:06 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote:
> On 22-03-17 23:47, Andre McCurdy wrote:
>>
>> Try to avoid native recipes accidentally being dependent on
>> MACHINE_FEATURES. This simple change doesn't prevent MACHINE_FEATURES
>> set via MACHINE_FEATURES_BACKFILL sneaking through, but it's better
>> than nothing.
>
> Maybe this would work:
>
> MACHINE_FEATURES_BACKFILL_CONSIDERED = "${MACHINE_FEATURES_BACKFILL}"
I guess it doesn't work if MACHINE_FEATURES_BACKFILL_CONSIDERED is set
elsewhere using _append.
The real solution would probably be to skip backfilling
MACHINE_FEATURES entirely for class-native?
>>
>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>> meta/classes/native.bbclass | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/classes/native.bbclass b/meta/classes/native.bbclass
>> index 6becf82..1919fbc 100644
>> --- a/meta/classes/native.bbclass
>> +++ b/meta/classes/native.bbclass
>> @@ -112,6 +112,7 @@ PKG_CONFIG_SYSTEM_INCLUDE_PATH[unexport] = "1"
>> LIBCOVERRIDE = ""
>> CLASSOVERRIDE = "class-native"
>> MACHINEOVERRIDES = ""
>> +MACHINE_FEATURES = ""
>>
>> PATH_prepend = "${COREBASE}/scripts/native-intercept:"
>>
>>
>
>
>
> Kind regards,
>
> Mike Looijmans
> System Expert
>
> TOPIC Products
> Materiaalweg 4, NL-5681 RJ Best
> Postbus 440, NL-5680 AK Best
> Telefoon: +31 (0) 499 33 69 79
> E-mail: mike.looijmans@topicproducts.com
> Website: www.topicproducts.com
>
> Please consider the environment before printing this e-mail
>
>
>
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] native.bbclass: clear MACHINE_FEATURES
2017-03-23 18:59 ` Andre McCurdy
@ 2017-03-23 19:09 ` Patrick Ohly
2017-03-23 19:26 ` Andre McCurdy
0 siblings, 1 reply; 5+ messages in thread
From: Patrick Ohly @ 2017-03-23 19:09 UTC (permalink / raw)
To: Andre McCurdy; +Cc: Mike Looijmans, OE Core mailing list
On Thu, 2017-03-23 at 11:59 -0700, Andre McCurdy wrote:
> On Thu, Mar 23, 2017 at 2:06 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote:
> > On 22-03-17 23:47, Andre McCurdy wrote:
> >>
> >> Try to avoid native recipes accidentally being dependent on
> >> MACHINE_FEATURES. This simple change doesn't prevent MACHINE_FEATURES
> >> set via MACHINE_FEATURES_BACKFILL sneaking through, but it's better
> >> than nothing.
> >
> > Maybe this would work:
> >
> > MACHINE_FEATURES_BACKFILL_CONSIDERED = "${MACHINE_FEATURES_BACKFILL}"
>
> I guess it doesn't work if MACHINE_FEATURES_BACKFILL_CONSIDERED is set
> elsewhere using _append.
>
> The real solution would probably be to skip backfilling
> MACHINE_FEATURES entirely for class-native?
Perhaps set MACHINE_FEATURES_forcevariable = "" in native.bbclass?
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] native.bbclass: clear MACHINE_FEATURES
2017-03-23 19:09 ` Patrick Ohly
@ 2017-03-23 19:26 ` Andre McCurdy
0 siblings, 0 replies; 5+ messages in thread
From: Andre McCurdy @ 2017-03-23 19:26 UTC (permalink / raw)
To: Patrick Ohly; +Cc: Mike Looijmans, OE Core mailing list
On Thu, Mar 23, 2017 at 12:09 PM, Patrick Ohly <patrick.ohly@intel.com> wrote:
> On Thu, 2017-03-23 at 11:59 -0700, Andre McCurdy wrote:
>> On Thu, Mar 23, 2017 at 2:06 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote:
>> > On 22-03-17 23:47, Andre McCurdy wrote:
>> >>
>> >> Try to avoid native recipes accidentally being dependent on
>> >> MACHINE_FEATURES. This simple change doesn't prevent MACHINE_FEATURES
>> >> set via MACHINE_FEATURES_BACKFILL sneaking through, but it's better
>> >> than nothing.
>> >
>> > Maybe this would work:
>> >
>> > MACHINE_FEATURES_BACKFILL_CONSIDERED = "${MACHINE_FEATURES_BACKFILL}"
>>
>> I guess it doesn't work if MACHINE_FEATURES_BACKFILL_CONSIDERED is set
>> elsewhere using _append.
>>
>> The real solution would probably be to skip backfilling
>> MACHINE_FEATURES entirely for class-native?
>
> Perhaps set MACHINE_FEATURES_forcevariable = "" in native.bbclass?
Over-riding MACHINE_FEATURES doesn't work, presumably because the
ConfigParsed event handler which does the backfilling runs after
over-rides have been applied?
> --
> Best Regards, Patrick Ohly
>
> The content of this message is my personal opinion only and although
> I am an employee of Intel, the statements I make here in no way
> represent Intel's position on the issue, nor am I authorized to speak
> on behalf of Intel on this matter.
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-23 19:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-22 22:47 [PATCH] native.bbclass: clear MACHINE_FEATURES Andre McCurdy
2017-03-23 9:06 ` Mike Looijmans
2017-03-23 18:59 ` Andre McCurdy
2017-03-23 19:09 ` Patrick Ohly
2017-03-23 19:26 ` Andre McCurdy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.