All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval" has been added to the 4.4-stable tree
@ 2017-03-27 16:38 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-03-27 16:38 UTC (permalink / raw)
  To: rogerq, felipe.balbi, gregkh, laurent.pinchart; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-gadget-f_uvc-fix-superspeed-companion-descriptor-s-wbytesperinterval.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 09424c50b7dff40cb30011c09114404a4656e023 Mon Sep 17 00:00:00 2001
From: Roger Quadros <rogerq@ti.com>
Date: Wed, 8 Mar 2017 16:05:43 +0200
Subject: usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval

From: Roger Quadros <rogerq@ti.com>

commit 09424c50b7dff40cb30011c09114404a4656e023 upstream.

The streaming_maxburst module parameter is 0 offset (0..15)
so we must add 1 while using it for wBytesPerInterval
calculation for the SuperSpeed companion descriptor.

Without this host uvcvideo driver will always see the wrong
wBytesPerInterval for SuperSpeed uvc gadget and may not find
a suitable video interface endpoint.
e.g. for streaming_maxburst = 0 case it will always
fail as wBytePerInterval was evaluating to 0.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/gadget/function/f_uvc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/gadget/function/f_uvc.c
+++ b/drivers/usb/gadget/function/f_uvc.c
@@ -625,7 +625,7 @@ uvc_function_bind(struct usb_configurati
 	uvc_ss_streaming_comp.bMaxBurst = opts->streaming_maxburst;
 	uvc_ss_streaming_comp.wBytesPerInterval =
 		cpu_to_le16(max_packet_size * max_packet_mult *
-			    opts->streaming_maxburst);
+			    (opts->streaming_maxburst + 1));
 
 	/* Allocate endpoints. */
 	ep = usb_ep_autoconfig(cdev->gadget, &uvc_control_ep);


Patches currently in stable-queue which might be from rogerq@ti.com are

queue-4.4/usb-gadget-f_uvc-fix-superspeed-companion-descriptor-s-wbytesperinterval.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-27 16:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-27 16:38 Patch "usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval" has been added to the 4.4-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.