From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org, "Koskinen, Ilkka" <ilkka.koskinen@intel.com>
Subject: Re: [PATCH REGRESSION-FIX resend] pwm: lpss: Set enable-bit before waiting for update-bit
Date: Tue, 28 Mar 2017 17:45:27 +0300 [thread overview]
Message-ID: <1490712327.708.30.camel@linux.intel.com> (raw)
In-Reply-To: <20170325140658.26868-1-hdegoede@redhat.com>
On Sat, 2017-03-25 at 15:06 +0100, Hans de Goede wrote:
> Hi Andy, Thierry,
>
> This patch fixes a regression with the pwm-lpss driver in 4.11,
> where it once turned off will not turn back on again on some
> machines. Yet it has been silent around this patch for some
> time now. Can you please review this and get it queued as a fix
> for 4.11 ?
I have tested this patch (*) on 3 boards:
1) internal development board (ApolloLake)
2) MinnowBoard MAX (BayTrail)
3) Intel Edison / Arduino break out (Tangier)
4) ...not yet... (CherryTrail / Braswell)
So, the patch *broke* functionality on 1), while 2) and 3) are survived.
(*) The base is my eds branch (https://github.com/andy-shev/linux/tree/e
ds, v4.11-rc4 based) + few pin control related patches to enable PWM
output.
P.S. I'll continue looking for CherryTrail / Braswell based board to
have some coverage there in the future.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-03-28 14:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 14:06 [PATCH REGRESSION-FIX resend] pwm: lpss: Set enable-bit before waiting for update-bit Hans de Goede
2017-03-25 14:06 ` [PATCH v2 resend] pwm: lpss: Set enable-bit before waiting for update-bit to go low Hans de Goede
2017-03-26 12:25 ` [PATCH REGRESSION-FIX resend] pwm: lpss: Set enable-bit before waiting for update-bit Andy Shevchenko
2017-03-26 14:44 ` Hans de Goede
2017-03-27 22:14 ` Ilkka Koskinen
2017-03-28 14:45 ` Andy Shevchenko [this message]
2017-03-28 17:20 ` Hans de Goede
2017-03-28 17:28 ` Andy Shevchenko
2017-03-28 17:33 ` Andy Shevchenko
2017-03-28 19:16 ` Hans de Goede
2017-03-29 11:24 ` Andy Shevchenko
2017-03-29 12:42 ` Hans de Goede
2017-03-29 17:41 ` Andy Shevchenko
2017-03-29 18:25 ` Hans de Goede
2017-03-31 20:07 ` Andy Shevchenko
2017-03-31 20:52 ` Hans de Goede
2017-04-03 14:22 ` Andy Shevchenko
2017-04-03 14:32 ` Hans de Goede
2017-04-04 16:20 ` Andy Shevchenko
2017-04-04 17:02 ` Hans de Goede
2017-04-04 17:23 ` Andy Shevchenko
2017-03-29 4:50 ` Ilkka Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490712327.708.30.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilkka.koskinen@intel.com \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.