From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org, "Koskinen, Ilkka" <ilkka.koskinen@intel.com>
Subject: Re: [PATCH REGRESSION-FIX resend] pwm: lpss: Set enable-bit before waiting for update-bit
Date: Fri, 31 Mar 2017 23:07:04 +0300 [thread overview]
Message-ID: <1490990824.708.90.camel@linux.intel.com> (raw)
In-Reply-To: <d399a9cb-7f73-08cd-47b5-f25aee416a6e@redhat.com>
On Wed, 2017-03-29 at 20:25 +0200, Hans de Goede wrote:
> Hi,
>
> On 29-03-17 19:41, Andy Shevchenko wrote:
> > On Wed, 2017-03-29 at 14:42 +0200, Hans de Goede wrote:
Thanks for your patience and valuable input.
So, I found CharryTrail with enabled PWM (UP board v0.4) and confirm the
bug.
Moreover, I have re-tested again all 4 platforms with and without your
fix, and I dunno how I did not notice this before, but looks like either
mine (though commit message shows that I have tested on 3 platforms at
least, so, I can re-test for sure) or Ilkka's patch broke it on all
platforms except Broxton / Apollo Lake.
So, summurize what we need is a quirk for Broxton / Apollo Lake. I need
to check Gemini Lake also to be sure.
And we definitely need this as a fix for stable. I would appreciate if
you can figure out which patch from previous series (b14e8ceff034
or 10d56a4cb1c6) broke it.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-03-31 20:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 14:06 [PATCH REGRESSION-FIX resend] pwm: lpss: Set enable-bit before waiting for update-bit Hans de Goede
2017-03-25 14:06 ` [PATCH v2 resend] pwm: lpss: Set enable-bit before waiting for update-bit to go low Hans de Goede
2017-03-26 12:25 ` [PATCH REGRESSION-FIX resend] pwm: lpss: Set enable-bit before waiting for update-bit Andy Shevchenko
2017-03-26 14:44 ` Hans de Goede
2017-03-27 22:14 ` Ilkka Koskinen
2017-03-28 14:45 ` Andy Shevchenko
2017-03-28 17:20 ` Hans de Goede
2017-03-28 17:28 ` Andy Shevchenko
2017-03-28 17:33 ` Andy Shevchenko
2017-03-28 19:16 ` Hans de Goede
2017-03-29 11:24 ` Andy Shevchenko
2017-03-29 12:42 ` Hans de Goede
2017-03-29 17:41 ` Andy Shevchenko
2017-03-29 18:25 ` Hans de Goede
2017-03-31 20:07 ` Andy Shevchenko [this message]
2017-03-31 20:52 ` Hans de Goede
2017-04-03 14:22 ` Andy Shevchenko
2017-04-03 14:32 ` Hans de Goede
2017-04-04 16:20 ` Andy Shevchenko
2017-04-04 17:02 ` Hans de Goede
2017-04-04 17:23 ` Andy Shevchenko
2017-03-29 4:50 ` Ilkka Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490990824.708.90.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilkka.koskinen@intel.com \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.