From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: ARM CLCD: fix dma allocation size
Date: Tue, 28 Mar 2017 17:25:59 +0000 [thread overview]
Message-ID: <1490721959.24147.3.camel@gmail.com> (raw)
In-Reply-To: <20170308145805.1325-1-slemieux.tyco@gmail.com>
ping
On Wed, 2017-03-08 at 09:58 -0500, Sylvain Lemieux wrote:
> From: Liam Beguin <lbeguin@tycoint.com>
>
> This patch forces the frambuffer size to be aligned on kernel pages.
>
> During the board startup, the splash screed did appear;
> the "ts_test" program or our application were not able to start.
>
> The following error message was reported:
> error: failed to map framebuffer device to memory.
> LinuxFB: driver cannot connect
>
> The issue was discovered, on the LPC32xx platform, during the migration
> of the LCD definition from the board file to the device tree.
>
> Signed-off-by: Liam Beguin <lbeguin@tycoint.com>
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> ---
> drivers/video/fbdev/amba-clcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
> index 0fab92c62828..ffc2c33c6cef 100644
> --- a/drivers/video/fbdev/amba-clcd.c
> +++ b/drivers/video/fbdev/amba-clcd.c
> @@ -881,8 +881,8 @@ static int clcdfb_of_dma_setup(struct clcd_fb *fb)
> if (err)
> return err;
>
> - framesize = fb->panel->mode.xres * fb->panel->mode.yres *
> - fb->panel->bpp / 8;
> + framesize = PAGE_ALIGN(fb->panel->mode.xres * fb->panel->mode.yres *
> + fb->panel->bpp / 8);
> fb->fb.screen_base = dma_alloc_coherent(&fb->dev->dev, framesize,
> &dma, GFP_KERNEL);
> if (!fb->fb.screen_base)
WARNING: multiple messages have this Message-ID (diff)
From: slemieux.tyco@gmail.com (Sylvain Lemieux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] video: ARM CLCD: fix dma allocation size
Date: Tue, 28 Mar 2017 13:25:59 -0400 [thread overview]
Message-ID: <1490721959.24147.3.camel@gmail.com> (raw)
In-Reply-To: <20170308145805.1325-1-slemieux.tyco@gmail.com>
ping
On Wed, 2017-03-08 at 09:58 -0500, Sylvain Lemieux wrote:
> From: Liam Beguin <lbeguin@tycoint.com>
>
> This patch forces the frambuffer size to be aligned on kernel pages.
>
> During the board startup, the splash screed did appear;
> the "ts_test" program or our application were not able to start.
>
> The following error message was reported:
> error: failed to map framebuffer device to memory.
> LinuxFB: driver cannot connect
>
> The issue was discovered, on the LPC32xx platform, during the migration
> of the LCD definition from the board file to the device tree.
>
> Signed-off-by: Liam Beguin <lbeguin@tycoint.com>
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> ---
> drivers/video/fbdev/amba-clcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
> index 0fab92c62828..ffc2c33c6cef 100644
> --- a/drivers/video/fbdev/amba-clcd.c
> +++ b/drivers/video/fbdev/amba-clcd.c
> @@ -881,8 +881,8 @@ static int clcdfb_of_dma_setup(struct clcd_fb *fb)
> if (err)
> return err;
>
> - framesize = fb->panel->mode.xres * fb->panel->mode.yres *
> - fb->panel->bpp / 8;
> + framesize = PAGE_ALIGN(fb->panel->mode.xres * fb->panel->mode.yres *
> + fb->panel->bpp / 8);
> fb->fb.screen_base = dma_alloc_coherent(&fb->dev->dev, framesize,
> &dma, GFP_KERNEL);
> if (!fb->fb.screen_base)
next prev parent reply other threads:[~2017-03-28 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170407143202epcas5p337f2b743793c97abbb5e0c441eaae163@epcas5p3.samsung.com>
2017-03-08 14:58 ` [PATCH] video: ARM CLCD: fix dma allocation size Sylvain Lemieux
2017-03-08 14:58 ` Sylvain Lemieux
2017-03-28 17:25 ` Sylvain Lemieux [this message]
2017-03-28 17:25 ` Sylvain Lemieux
2017-04-07 14:31 ` Bartlomiej Zolnierkiewicz
2017-04-07 14:31 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490721959.24147.3.camel@gmail.com \
--to=slemieux.tyco@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.