From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "tj@kernel.org" <tj@kernel.org>,
"paolo.valente@linaro.org" <paolo.valente@linaro.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"samuele.zecchini92@gmail.com" <samuele.zecchini92@gmail.com>,
"fchecconi@gmail.com" <fchecconi@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"avanzini.arianna@gmail.com" <avanzini.arianna@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"riccardo.pizzetti@gmail.com" <riccardo.pizzetti@gmail.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: Re: [PATCH V2 11/16] block, bfq: reduce idling only in symmetric scenarios
Date: Fri, 31 Mar 2017 15:20:29 +0000 [thread overview]
Message-ID: <1490973609.2587.3.camel@sandisk.com> (raw)
In-Reply-To: <20170331124743.3530-12-paolo.valente@linaro.org>
On Fri, 2017-03-31 at 14:47 +0200, Paolo Valente wrote:
> +=A0=A0=A0=A0=A0=A0=A0entity->weight_counter =3D kzalloc(sizeof(struct bf=
q_weight_counter),
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 GFP_ATOMIC);
> +=A0=A0=A0=A0=A0=A0=A0entity->weight_counter->weight =3D entity->weight;
GFP_ATOMIC allocations are more likely to fail than GFP_KERNEL allocations.
What will happen if kzalloc() returns NULL?
Bart.=
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "tj@kernel.org" <tj@kernel.org>,
"paolo.valente@linaro.org" <paolo.valente@linaro.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"samuele.zecchini92@gmail.com" <samuele.zecchini92@gmail.com>,
"fchecconi@gmail.com" <fchecconi@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"avanzini.arianna@gmail.com" <avanzini.arianna@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"riccardo.pizzetti@gmail.com" <riccardo.pizzetti@gmail.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: Re: [PATCH V2 11/16] block, bfq: reduce idling only in symmetric scenarios
Date: Fri, 31 Mar 2017 15:20:29 +0000 [thread overview]
Message-ID: <1490973609.2587.3.camel@sandisk.com> (raw)
In-Reply-To: <20170331124743.3530-12-paolo.valente@linaro.org>
On Fri, 2017-03-31 at 14:47 +0200, Paolo Valente wrote:
> + entity->weight_counter = kzalloc(sizeof(struct bfq_weight_counter),
> + GFP_ATOMIC);
> + entity->weight_counter->weight = entity->weight;
GFP_ATOMIC allocations are more likely to fail than GFP_KERNEL allocations.
What will happen if kzalloc() returns NULL?
Bart.
next prev parent reply other threads:[~2017-03-31 15:20 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 12:47 [PATCH V2 00/16] Introduce the BFQ I/O scheduler Paolo Valente
2017-03-31 12:47 ` [PATCH V2 01/16] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler Paolo Valente
2017-03-31 12:47 ` [PATCH V2 02/16] block, bfq: add full hierarchical scheduling and cgroups support Paolo Valente
2017-03-31 12:47 ` [PATCH V2 03/16] block, bfq: improve throughput boosting Paolo Valente
2017-03-31 12:47 ` [PATCH V2 04/16] block, bfq: modify the peak-rate estimator Paolo Valente
2017-03-31 15:31 ` Bart Van Assche
2017-03-31 15:31 ` Bart Van Assche
2017-04-04 10:42 ` Paolo Valente
2017-04-04 10:42 ` Paolo Valente
2017-04-04 15:28 ` Bart Van Assche
2017-04-04 15:28 ` Bart Van Assche
2017-04-06 19:37 ` Paolo Valente
2017-04-06 19:37 ` Paolo Valente
2017-03-31 12:47 ` [PATCH V2 05/16] block, bfq: add more fairness with writes and slow processes Paolo Valente
2017-03-31 12:47 ` [PATCH V2 06/16] block, bfq: improve responsiveness Paolo Valente
2017-03-31 12:47 ` [PATCH V2 07/16] block, bfq: reduce I/O latency for soft real-time applications Paolo Valente
2017-03-31 12:47 ` [PATCH V2 08/16] block, bfq: preserve a low latency also with NCQ-capable drives Paolo Valente
2017-03-31 12:47 ` [PATCH V2 09/16] block, bfq: reduce latency during request-pool saturation Paolo Valente
2017-03-31 12:47 ` [PATCH V2 10/16] block, bfq: add Early Queue Merge (EQM) Paolo Valente
2017-03-31 12:47 ` [PATCH V2 11/16] block, bfq: reduce idling only in symmetric scenarios Paolo Valente
2017-03-31 15:20 ` Bart Van Assche [this message]
2017-03-31 15:20 ` Bart Van Assche
2017-04-07 7:47 ` Paolo Valente
2017-04-07 7:47 ` Paolo Valente
2017-03-31 12:47 ` [PATCH V2 12/16] block, bfq: boost the throughput on NCQ-capable flash-based devices Paolo Valente
2017-03-31 12:47 ` [PATCH V2 13/16] block, bfq: boost the throughput with random I/O on NCQ-capable HDDs Paolo Valente
2017-03-31 12:47 ` [PATCH V2 14/16] block, bfq: handle bursts of queue activations Paolo Valente
2017-03-31 12:47 ` [PATCH V2 15/16] block, bfq: remove all get and put of I/O contexts Paolo Valente
2017-03-31 12:47 ` [PATCH V2 16/16] block, bfq: split bfq-iosched.c into multiple source files Paolo Valente
2017-04-02 10:02 ` kbuild test robot
2017-04-11 11:00 ` Paolo Valente
2017-04-11 11:00 ` Paolo Valente
2017-04-12 8:39 ` [kbuild-all] " Ye Xiaolong
2017-04-12 9:24 ` Paolo Valente
2017-04-12 9:24 ` Paolo Valente
2017-04-12 16:05 ` Paolo Valente
2017-04-12 16:05 ` Paolo Valente
2017-04-10 16:56 ` [PATCH V2 00/16] Introduce the BFQ I/O scheduler Bart Van Assche
2017-04-10 16:56 ` Bart Van Assche
2017-04-11 8:43 ` Paolo Valente
2017-04-11 8:43 ` Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490973609.2587.3.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=avanzini.arianna@gmail.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=fchecconi@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=riccardo.pizzetti@gmail.com \
--cc=samuele.zecchini92@gmail.com \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.