From: Joe Perches <joe@perches.com>
To: Matthias Kaehlcke <mka@chromium.org>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com
Cc: Michael Davidson <md@google.com>,
Grant Grundler <grundler@chromium.org>,
linux-kernel@vger.kernel.org,
Greg Hackmann <ghackmann@google.com>,
linux-raid@vger.kernel.org, Shaohua Li <shli@kernel.org>
Subject: Re: [PATCH] dm ioctl: Remove double parentheses
Date: Fri, 31 Mar 2017 19:07:33 -0700 [thread overview]
Message-ID: <1491012453.27353.25.camel@perches.com> (raw)
In-Reply-To: <20170401015019.GA13986@google.com>
On Fri, 2017-03-31 at 18:50 -0700, Matthias Kaehlcke wrote:
> El Thu, Mar 16, 2017 at 09:48:30AM -0700 Matthias Kaehlcke ha dit:
>
> > The extra pair of parantheses is not needed and causes clang to generate
> > the following warning:
> >
> > drivers/md/dm-ioctl.c:1776:11: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
> > if ((cmd == DM_DEV_CREATE_CMD)) {
> > ~~~~^~~~~~~~~~~~~~~~~~~~
> > drivers/md/dm-ioctl.c:1776:11: note: remove extraneous parentheses around the comparison to silence this warning
> > if ((cmd == DM_DEV_CREATE_CMD)) {
> > ~ ^ ~
> > drivers/md/dm-ioctl.c:1776:11: note: use '=' to turn this equality comparison into an assignment
> > if ((cmd == DM_DEV_CREATE_CMD)) {
There are dozens of these comparisons in the kernel.
Are you fixing them all or just this one?
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Matthias Kaehlcke <mka@chromium.org>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com
Cc: Shaohua Li <shli@kernel.org>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
Grant Grundler <grundler@chromium.org>,
Michael Davidson <md@google.com>,
Greg Hackmann <ghackmann@google.com>
Subject: Re: [PATCH] dm ioctl: Remove double parentheses
Date: Fri, 31 Mar 2017 19:07:33 -0700 [thread overview]
Message-ID: <1491012453.27353.25.camel@perches.com> (raw)
In-Reply-To: <20170401015019.GA13986@google.com>
On Fri, 2017-03-31 at 18:50 -0700, Matthias Kaehlcke wrote:
> El Thu, Mar 16, 2017 at 09:48:30AM -0700 Matthias Kaehlcke ha dit:
>
> > The extra pair of parantheses is not needed and causes clang to generate
> > the following warning:
> >
> > drivers/md/dm-ioctl.c:1776:11: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
> > if ((cmd == DM_DEV_CREATE_CMD)) {
> > ~~~~^~~~~~~~~~~~~~~~~~~~
> > drivers/md/dm-ioctl.c:1776:11: note: remove extraneous parentheses around the comparison to silence this warning
> > if ((cmd == DM_DEV_CREATE_CMD)) {
> > ~ ^ ~
> > drivers/md/dm-ioctl.c:1776:11: note: use '=' to turn this equality comparison into an assignment
> > if ((cmd == DM_DEV_CREATE_CMD)) {
There are dozens of these comparisons in the kernel.
Are you fixing them all or just this one?
next prev parent reply other threads:[~2017-04-01 2:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 16:48 [PATCH] dm ioctl: Remove double parentheses Matthias Kaehlcke
2017-04-01 1:50 ` Matthias Kaehlcke
2017-04-01 2:07 ` Joe Perches [this message]
2017-04-01 2:07 ` Joe Perches
2017-04-03 16:56 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491012453.27353.25.camel@perches.com \
--to=joe@perches.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ghackmann@google.com \
--cc=grundler@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=md@google.com \
--cc=mka@chromium.org \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.