From: Gerd Hoffmann <kraxel@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: lvivier@redhat.com, open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create
Date: Mon, 03 Apr 2017 11:02:15 +0200 [thread overview]
Message-ID: <1491210135.17505.31.camel@redhat.com> (raw)
In-Reply-To: <20170403075353.jqxrqshygfidn4f3@phenom.ffwll.local>
On Mo, 2017-04-03 at 09:53 +0200, Daniel Vetter wrote:
> On Mon, Apr 03, 2017 at 09:08:45AM +0200, Gerd Hoffmann wrote:
> > Lookup format using virtio_gpu_translate_format()
> > instead of hardcoding it. Fixes xorg display on
> > bigendian guests (i.e. ppc64).
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> ow ... :(
>
> With what kind of client have you tested this? fbdev? kms native?
text console (fbcon) is fine, xorg (modesetting driver) fails.
> Should we patch drm_fourcc.h and essentially state that _all_ drm_fourcc
> are in native endian, don't dare mixing things up?
Well, I don't think this needs clarification. I never assumed that
fourcc is something else than native endian. It really was just an
oversight in the virtio driver.
One code path (which creates the framebuffer for fbdev emulation) did
proper drm_fourcc -> virtio format mapping, including endianness
handling. Patch 1/2 of this series factors this code out into a helper
function so we can easily reuse it.
The other code path (for creating dumb buffers) had the virtio format
hardcoded which happened to work correctly in the little endian case.
cheers,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, lvivier@redhat.com,
open list <linux-kernel@vger.kernel.org>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create
Date: Mon, 03 Apr 2017 11:02:15 +0200 [thread overview]
Message-ID: <1491210135.17505.31.camel@redhat.com> (raw)
In-Reply-To: <20170403075353.jqxrqshygfidn4f3@phenom.ffwll.local>
On Mo, 2017-04-03 at 09:53 +0200, Daniel Vetter wrote:
> On Mon, Apr 03, 2017 at 09:08:45AM +0200, Gerd Hoffmann wrote:
> > Lookup format using virtio_gpu_translate_format()
> > instead of hardcoding it. Fixes xorg display on
> > bigendian guests (i.e. ppc64).
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> ow ... :(
>
> With what kind of client have you tested this? fbdev? kms native?
text console (fbcon) is fine, xorg (modesetting driver) fails.
> Should we patch drm_fourcc.h and essentially state that _all_ drm_fourcc
> are in native endian, don't dare mixing things up?
Well, I don't think this needs clarification. I never assumed that
fourcc is something else than native endian. It really was just an
oversight in the virtio driver.
One code path (which creates the framebuffer for fbdev emulation) did
proper drm_fourcc -> virtio format mapping, including endianness
handling. Patch 1/2 of this series factors this code out into a helper
function so we can easily reuse it.
The other code path (for creating dumb buffers) had the virtio format
hardcoded which happened to work correctly in the little endian case.
cheers,
Gerd
next prev parent reply other threads:[~2017-04-03 9:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 7:08 [PATCH 0/2] virtio: fix virtio_gpu_mode_dumb_create Gerd Hoffmann
2017-04-03 7:08 ` [PATCH 1/2] drm: virtio: add virtio_gpu_translate_format Gerd Hoffmann
2017-04-03 7:08 ` Gerd Hoffmann
2017-04-03 7:51 ` Daniel Vetter
2017-04-03 7:51 ` Daniel Vetter
2017-04-03 9:05 ` Gerd Hoffmann
2017-04-03 9:05 ` Gerd Hoffmann
2017-04-03 9:05 ` Gerd Hoffmann
2017-04-03 7:51 ` Daniel Vetter
2017-04-03 7:08 ` [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create Gerd Hoffmann
2017-04-03 7:08 ` Gerd Hoffmann
2017-04-03 7:08 ` Gerd Hoffmann
2017-04-03 7:45 ` Dave Airlie
2017-04-03 7:45 ` Dave Airlie
2017-04-03 7:53 ` Daniel Vetter
2017-04-03 7:53 ` Daniel Vetter
2017-04-03 9:02 ` Gerd Hoffmann [this message]
2017-04-03 9:02 ` Gerd Hoffmann
2017-04-03 9:02 ` Gerd Hoffmann
2017-04-03 7:53 ` Daniel Vetter
2017-04-03 8:31 ` [PATCH 0/2] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491210135.17505.31.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.