All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata()
Date: Wed, 05 Apr 2017 15:10:14 +0000	[thread overview]
Message-ID: <1491405013.2787.3.camel@sandisk.com> (raw)
In-Reply-To: <b5bc4160-aace-b919-7fe2-a4742d03c4ba-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>

On Wed, 2017-04-05 at 15:55 +0200, SF Markus Elfring wrote:
> -	size = sizeof(struct ib_cc_congestion_setting_attr);
> -	ppd->congestion_entries_shadow = kzalloc(size, GFP_KERNEL);
> +	ppd->congestion_entries_shadow = kzalloc(sizeof(*ppd
> +							->congestion_entries_shadow),
> +						 GFP_KERNEL);

The way how the above line has been split looks really weird. Please
move the entire kzalloc() call to the next line such that "*ppd" and
"->congestion_entries_shadow" appear on the same line.

Thanks,

Bart.

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata()
Date: Wed, 5 Apr 2017 15:10:14 +0000	[thread overview]
Message-ID: <1491405013.2787.3.camel@sandisk.com> (raw)
In-Reply-To: <b5bc4160-aace-b919-7fe2-a4742d03c4ba-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>

On Wed, 2017-04-05 at 15:55 +0200, SF Markus Elfring wrote:
> -	size = sizeof(struct ib_cc_congestion_setting_attr);
> -	ppd->congestion_entries_shadow = kzalloc(size, GFP_KERNEL);
> +	ppd->congestion_entries_shadow = kzalloc(sizeof(*ppd
> +							->congestion_entries_shadow),
> +						 GFP_KERNEL);

The way how the above line has been split looks really weird. Please
move the entire kzalloc() call to the next line such that "*ppd" and
"->congestion_entries_shadow" appear on the same line.

Thanks,

Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hal.rosenstock@gmail.com" <hal.rosenstock@gmail.com>,
	"elfring@users.sourceforge.net" <elfring@users.sourceforge.net>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"infinipath@intel.com" <infinipath@intel.com>,
	"dledford@redhat.com" <dledford@redhat.com>,
	"sean.hefty@intel.com" <sean.hefty@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata()
Date: Wed, 5 Apr 2017 15:10:14 +0000	[thread overview]
Message-ID: <1491405013.2787.3.camel@sandisk.com> (raw)
In-Reply-To: <b5bc4160-aace-b919-7fe2-a4742d03c4ba@users.sourceforge.net>

On Wed, 2017-04-05 at 15:55 +0200, SF Markus Elfring wrote:
> -	size = sizeof(struct ib_cc_congestion_setting_attr);
> -	ppd->congestion_entries_shadow = kzalloc(size, GFP_KERNEL);
> +	ppd->congestion_entries_shadow = kzalloc(sizeof(*ppd
> +							->congestion_entries_shadow),
> +						 GFP_KERNEL);

The way how the above line has been split looks really weird. Please
move the entire kzalloc() call to the next line such that "*ppd" and
"->congestion_entries_shadow" appear on the same line.

Thanks,

Bart.

  parent reply	other threads:[~2017-04-05 15:10 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 13:50 [PATCH 0/5] IB/qib: Fine-tuning for four function implementations SF Markus Elfring
2017-04-05 13:50 ` SF Markus Elfring
2017-04-05 13:51 ` [PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs() SF Markus Elfring
2017-04-05 13:51   ` SF Markus Elfring
     [not found]   ` <5e5e00d3-b6a4-7371-65be-c5fe387d26b3-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-05 14:34     ` Yuval Shaia
2017-04-05 14:34       ` Yuval Shaia
2017-04-05 14:34       ` Yuval Shaia
2017-04-05 14:54       ` SF Markus Elfring
2017-04-05 14:54         ` SF Markus Elfring
2017-04-05 15:06         ` Johannes Thumshirn
2017-04-05 15:06           ` Johannes Thumshirn
2017-04-05 15:17           ` Yuval Shaia
2017-04-05 15:17             ` Yuval Shaia
2017-04-05 13:52 ` [PATCH 2/5] IB/qib: Use kmalloc_array() in qib_init_7322_variables() SF Markus Elfring
2017-04-05 13:52   ` SF Markus Elfring
2017-04-05 14:21   ` Yuval Shaia
2017-04-05 14:21     ` Yuval Shaia
2017-04-05 13:53 ` [PATCH 3/5] IB/qib: Use kcalloc() in qib_alloc_devdata() SF Markus Elfring
2017-04-05 13:53   ` SF Markus Elfring
     [not found] ` <c16b18ac-287f-5faf-b79a-c86e2adfa22c-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-05 13:54   ` [PATCH 4/5] IB/qib: Use kcalloc() in qib_init_pportdata() SF Markus Elfring
2017-04-05 13:54     ` SF Markus Elfring
2017-04-05 13:54     ` SF Markus Elfring
2017-04-06  0:37   ` [PATCH 0/5] IB/qib: Fine-tuning for four function implementations Dennis Dalessandro
2017-04-06  0:37     ` Dennis Dalessandro
2017-04-06  0:37     ` Dennis Dalessandro
2017-04-05 13:55 ` [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata() SF Markus Elfring
2017-04-05 13:55   ` SF Markus Elfring
2017-04-05 14:32   ` Yuval Shaia
2017-04-05 14:32     ` Yuval Shaia
2017-04-05 15:04     ` SF Markus Elfring
2017-04-05 15:04       ` SF Markus Elfring
2017-04-05 15:15       ` Yuval Shaia
2017-04-05 15:15         ` Yuval Shaia
2017-04-05 15:21         ` SF Markus Elfring
2017-04-05 15:21           ` SF Markus Elfring
     [not found]           ` <c3885f83-8239-e21d-74fc-bf4fe03dd5dc-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-06 19:48             ` Yuval Shaia
2017-04-06 19:48               ` Yuval Shaia
2017-04-06 19:48               ` Yuval Shaia
2017-04-06 20:33               ` SF Markus Elfring
2017-04-06 20:33                 ` SF Markus Elfring
2017-04-06 20:33                 ` SF Markus Elfring
     [not found]   ` <b5bc4160-aace-b919-7fe2-a4742d03c4ba-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-05 15:10     ` Bart Van Assche [this message]
2017-04-05 15:10       ` [PATCH 5/5] " Bart Van Assche
2017-04-05 15:10       ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491405013.2787.3.camel@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.