From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Romain Perier <romain.perier@collabora.com>, liezhi.yang@windriver.com
Cc: yocto@yoctoproject.org, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] logrotate: Bump to 3.11.0
Date: Thu, 06 Apr 2017 12:38:40 +0100 [thread overview]
Message-ID: <1491478720.17200.35.camel@linuxfoundation.org> (raw)
In-Reply-To: <20170405150521.19160-2-romain.perier@collabora.com>
On Wed, 2017-04-05 at 17:05 +0200, Romain Perier wrote:
> This commit updates the recipe to the last upstream tag. Then, as the
> tarball no longer contains the pre-generated Makefile, inherit from
> autotools
>
> [...]
> -PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'acl
> selinux', d)}"
> +PACKAGECONFIG ?= "\
> + ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux',
> '', d)} \
> +"
I'm not sure the above should be there, it reverts someone else's
change?
I am a little nervous of taking this at this point in the release
too...
Cheers,
Richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Romain Perier <romain.perier@collabora.com>, liezhi.yang@windriver.com
Cc: yocto@yoctoproject.org, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 1/2] logrotate: Bump to 3.11.0
Date: Thu, 06 Apr 2017 12:38:40 +0100 [thread overview]
Message-ID: <1491478720.17200.35.camel@linuxfoundation.org> (raw)
In-Reply-To: <20170405150521.19160-2-romain.perier@collabora.com>
On Wed, 2017-04-05 at 17:05 +0200, Romain Perier wrote:
> This commit updates the recipe to the last upstream tag. Then, as the
> tarball no longer contains the pre-generated Makefile, inherit from
> autotools
>
> [...]
> -PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'acl
> selinux', d)}"
> +PACKAGECONFIG ?= "\
> + ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux',
> '', d)} \
> +"
I'm not sure the above should be there, it reverts someone else's
change?
I am a little nervous of taking this at this point in the release
too...
Cheers,
Richard
next prev parent reply other threads:[~2017-04-06 11:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 15:05 [PATCH 0/2] logrotate: systemd support Romain Perier
2017-04-05 15:05 ` [PATCH 1/2] logrotate: Bump to 3.11.0 Romain Perier
2017-04-06 11:38 ` Richard Purdie [this message]
2017-04-06 11:38 ` [OE-core] " Richard Purdie
2017-04-06 12:20 ` Romain Perier
2017-04-06 12:20 ` [OE-core] " Romain Perier
2017-04-11 12:37 ` [yocto] " Romain Perier
2017-04-11 12:37 ` [OE-core] " Romain Perier
2017-04-05 15:05 ` [PATCH 2/2] logrotate: Add systemd support Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491478720.17200.35.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=romain.perier@collabora.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.