From: Your Name <you@example.com>
To: linux-kernel@vger.kernel.org
Cc: Jeffy Chen <jeffy.chen@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>, David Airlie <airlied@linux.ie>,
Your Name <you@example.com>,
briannorris@chromium.org, dianders@chromium.org,
dri-devel@lists.freedesktop.org, tfiga@chromium.org,
linux-rockchip@lists.infradead.org, seanpaul@chromium.org,
zyw@rock-chips.com, linux-arm-kernel@lists.infradead.org,
mark.yao@rock-chips.com
Subject: [PATCH v4 05/12] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded
Date: Thu, 6 Apr 2017 20:22:16 +0800 [thread overview]
Message-ID: <1491481343-11025-6-git-send-email-you@example.com> (raw)
In-Reply-To: <1491481343-11025-1-git-send-email-you@example.com>
From: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Your Name <you@example.com>
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 4e55d63..ee4195d 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1053,6 +1053,7 @@ static int cdn_dp_bind(struct device *dev, struct device *master, void *data)
dp->connected = false;
dp->active = false;
dp->active_port = -1;
+ dp->fw_loaded = false;
INIT_WORK(&dp->event_work, cdn_dp_pd_event_work);
@@ -1133,7 +1134,8 @@ static void cdn_dp_unbind(struct device *dev, struct device *master, void *data)
connector->funcs->destroy(connector);
pm_runtime_disable(dev);
- release_firmware(dp->fw);
+ if (dp->fw_loaded)
+ release_firmware(dp->fw);
kfree(dp->edid);
dp->edid = NULL;
}
--
2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: you@example.com (Your Name)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 05/12] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded
Date: Thu, 6 Apr 2017 20:22:16 +0800 [thread overview]
Message-ID: <1491481343-11025-6-git-send-email-you@example.com> (raw)
In-Reply-To: <1491481343-11025-1-git-send-email-you@example.com>
From: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Your Name <you@example.com>
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 4e55d63..ee4195d 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1053,6 +1053,7 @@ static int cdn_dp_bind(struct device *dev, struct device *master, void *data)
dp->connected = false;
dp->active = false;
dp->active_port = -1;
+ dp->fw_loaded = false;
INIT_WORK(&dp->event_work, cdn_dp_pd_event_work);
@@ -1133,7 +1134,8 @@ static void cdn_dp_unbind(struct device *dev, struct device *master, void *data)
connector->funcs->destroy(connector);
pm_runtime_disable(dev);
- release_firmware(dp->fw);
+ if (dp->fw_loaded)
+ release_firmware(dp->fw);
kfree(dp->edid);
dp->edid = NULL;
}
--
2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: Your Name <you@example.com>
To: linux-kernel@vger.kernel.org
Cc: briannorris@chromium.org, dianders@chromium.org,
tfiga@chromium.org, seanpaul@chromium.org, zyw@rock-chips.com,
mark.yao@rock-chips.com, Jeffy Chen <jeffy.chen@rock-chips.com>,
Your Name <you@example.com>, Heiko Stuebner <heiko@sntech.de>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
David Airlie <airlied@linux.ie>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 05/12] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded
Date: Thu, 6 Apr 2017 20:22:16 +0800 [thread overview]
Message-ID: <1491481343-11025-6-git-send-email-you@example.com> (raw)
In-Reply-To: <1491481343-11025-1-git-send-email-you@example.com>
From: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Your Name <you@example.com>
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 4e55d63..ee4195d 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1053,6 +1053,7 @@ static int cdn_dp_bind(struct device *dev, struct device *master, void *data)
dp->connected = false;
dp->active = false;
dp->active_port = -1;
+ dp->fw_loaded = false;
INIT_WORK(&dp->event_work, cdn_dp_pd_event_work);
@@ -1133,7 +1134,8 @@ static void cdn_dp_unbind(struct device *dev, struct device *master, void *data)
connector->funcs->destroy(connector);
pm_runtime_disable(dev);
- release_firmware(dp->fw);
+ if (dp->fw_loaded)
+ release_firmware(dp->fw);
kfree(dp->edid);
dp->edid = NULL;
}
--
2.1.4
next prev parent reply other threads:[~2017-04-06 12:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 12:22 [PATCH v4 00/12] drm: rockchip: Fix rockchip drm unbind crash error Your Name
2017-04-06 12:22 ` Your Name
2017-04-06 12:22 ` [PATCH v4 01/12] drm: bridge: analogix: Detach panel when unbinding analogix dp Your Name
2017-04-06 12:22 ` [PATCH v4 02/12] drm: bridge: analogix: Unregister dp aux when unbinding Your Name
2017-04-06 12:22 ` [PATCH v4 03/12] drm: bridge: analogix: Disable clock " Your Name
2017-04-06 12:22 ` [PATCH v4 04/12] drm: bridge: analogix: Destroy connector & encoder " Your Name
2017-04-06 12:22 ` Your Name [this message]
2017-04-06 12:22 ` [PATCH v4 05/12] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded Your Name
2017-04-06 12:22 ` Your Name
2017-04-06 12:22 ` [PATCH v4 06/12] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding Your Name
2017-04-06 12:22 ` Your Name
2017-04-06 12:22 ` [PATCH v4 07/12] drm/rockchip: vop: Enable pm domain before vop_initial Your Name
2017-04-06 12:22 ` Your Name
2017-04-06 12:22 ` Your Name
2017-04-06 12:22 ` [PATCH v4 08/12] drm/rockchip: vop: Unprepare clocks when unbinding Your Name
2017-04-06 12:22 ` Your Name
2017-04-06 12:22 ` [PATCH v4 09/12] drm/rockchip: analogix_dp: Disable clock " Your Name
2017-04-06 12:22 ` Your Name
2017-04-06 12:22 ` Your Name
2017-04-06 12:22 ` [PATCH v4 10/12] drm/rockchip: Reoder drm bind/unbind sequence Your Name
2017-04-06 12:22 ` Your Name
2017-04-06 12:22 ` [PATCH v4 11/12] drm/rockchip: Shutdown all crtcs when unbinding drm Your Name
2017-04-06 12:22 ` Your Name
2017-04-06 12:22 ` [PATCH v4 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered Your Name
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491481343-11025-6-git-send-email-you@example.com \
--to=you@example.com \
--cc=airlied@linux.ie \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.yao@rock-chips.com \
--cc=seanpaul@chromium.org \
--cc=tfiga@chromium.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.