Re: [PATCH v2 1/7] xen: credit1: simplify csched_runq_steal() a little bit.

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1086 bytes --]

On Fri, 2017-04-07 at 11:45 +0100, George Dunlap wrote:
> On 06/04/17 09:16, Dario Faggioli wrote:
> > Since we're holding the lock on the pCPU from which we
> > are trying to steal, it can't have disappeared, so we
> > can drop the check for that (and convert it in an
> > ASSERT()).
> > 
> > And since we try to steal only from busy pCPUs, it's
> > unlikely for such pCPU to be idle, so we mark it as
> > such (and bail early if it unfortunately is).
> 
> Oh, you mean "mark the test as unlikely".  I initially parsed this
> as,
> "Mark the pcpu as idle", which confused me.
> 
> Can I change this to, "tell the compiler that it's unlikely"?
> 
Indeed. AFAICS, I'll have to resend, so I will do this myself.

> Either way:
> 
> Reviewed-by; George Dunlap <george.dunlap@citrix.com>
> 
Thanks,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel