Re: [PATCH v2 5/7] xen: credit1: increase efficiency and scalability of load balancing.

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1500 bytes --]

On Fri, 2017-04-07 at 16:17 +0100, George Dunlap wrote:
> On 07/04/17 15:49, Dario Faggioli wrote:
> > Ok. I'm not sure I see what you mean with 'accounting' in this
> > context,
> > but, yeah, go ahead and let me know. :-)
> 
> Well I don't like having the increase_* and decrease_* all over the
> place, *almost* corresponding with __runq_insert() and
> __runq_remove(),
> but not quite.  
>
Ah, I see what you mean now.

Personally, I don't dislike it, but most important, I'm not sure I can
do much better. :-/

> It seems like trying to sort out most of the refcounting
> inside fo those two functions (perhaps with runq_insert() which did
> reference counting, and __runq_insert() that didn't, or
> something  like
> that) would be a better approach.
>
Right. I've tried already, but without success, and I had to stop an
resort to what's in this patch.

As I said, I am ok with this approach, so I just went for it. I can try
to think harder at whether it is really possible to do something like
you suggest above... lemme try.

> If you're going to re-send the series, maybe it would be best if you
> sent this patch last, so we can commit the rest?
> 
Yep, will do.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel