* Re: Changes to special character escaping?
2017-04-07 22:56 Changes to special character escaping? Mark Fox
@ 2017-04-10 7:49 ` Ian Kent
2017-04-10 8:07 ` Ian Kent
1 sibling, 0 replies; 3+ messages in thread
From: Ian Kent @ 2017-04-10 7:49 UTC (permalink / raw)
To: Mark Fox, autofs
On Fri, 2017-04-07 at 16:56 -0600, Mark Fox wrote:
> Has something changed regarding escaping of special characters? The
> methods used to deal with special characters in maps that are included
> in distributions (ie. Ubuntu 16.04.2, so automount 5.1.1) no longer
> seem to work.
There was at least one change related to escaping, didn't expect it to break
this though.
TBH, the escaping is difficult and this is probably an example of fixing one
thing and breaking another.
>
> Without special characters, autofs works wonderfully on all sorts of
> CIFS shares. However, with a CIFS administrative share (C$), or a
> share with an ampersand, I've had no luck. The shares work fine
> through smbclient or when mounted by hand, but I haven't stumbled onto
> how to get it working under autofs.
>
> My problem setup is simple:
>
> --- /etc/auto.master ---
> +auto.master
> /cifs /etc/auto.cifs --timeout=300 --ghost
> ------
>
> --- /etc/auto.cifs ---
> CDC1 -fstype=cifs,rw,noperm,credentials=/etc/creds/CDC1 \
> "/C$" "://CDC1/C\$"
> ------
>
> It doesn't work as configured above. The output from 'automount -f -v' is:
Can you get a full debug log of this please.
Use the -d instead of the -v.
>
> ------
> attempting to mount entry /cifs/CDC1/C$
> > > Retrying with upper case share name
> > > mount error(6): No such device or address
> > > Refer to the mount.cifs(8) manual page (e.g. man mount.cifs)
>
> mount(generic): failed to mount //CDC1/C\$ (type cifs) on
> /cifs/CDC1/C$
> failed to mount /cifs/CDC1/C$
That "/cifs/CDC1/C$" looks ok and the log entry says it's trying to mount
"//CDC1/C\$" which might have become the problem.
Ian
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Changes to special character escaping?
2017-04-07 22:56 Changes to special character escaping? Mark Fox
2017-04-10 7:49 ` Ian Kent
@ 2017-04-10 8:07 ` Ian Kent
1 sibling, 0 replies; 3+ messages in thread
From: Ian Kent @ 2017-04-10 8:07 UTC (permalink / raw)
To: Mark Fox, autofs
On Fri, 2017-04-07 at 16:56 -0600, Mark Fox wrote:
> Has something changed regarding escaping of special characters? The
> methods used to deal with special characters in maps that are included
> in distributions (ie. Ubuntu 16.04.2, so automount 5.1.1) no longer
> seem to work.
The problem is probably this patch, as you can see from the description
(spelling mistakes and all) there's a conflict depending on how the map entry
key is obtained, not sure what to do about it yet since I think this will be (at
least) the third time cifs escaping has been a problem .... lets look at a log.
autofs-5.1.0 - revert special case cifs escapes
From: Ian Kent <ikent@redhat.com>
The patch this reverts added an additional dquote on the mount location
to revolve "\"s but this causes inconsistent quoting between the lookup
key and the mount location when it is substituted using the &.
As described in the original patch:
"Since "\" is a valid seperator for cifs shares it can't be used to escape
characters in the share name passed to mount.cifs. So we have no choice
but to require that the seperator we use is "/" and de-quote the string
before sending it to mount.cifs."
We do need to require that the seperator "/" is used which alone should
eliminate the need for an additional dequote and expect that invalid
share name mounts will fail.
---
CHANGELOG | 1 +
modules/mount_generic.c | 36 ++++++------------------------------
2 files changed, 7 insertions(+), 30 deletions(-)
diff --git a/CHANGELOG b/CHANGELOG
index 8080743..e21752b 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -46,6 +46,7 @@
- add config option to force use of program map stdvars.
- fix incorrect check in parse_mount().
- handle duplicates in multi mounts.
+- revert special case cifs escapes.
04/06/2014 autofs-5.1.0
=======================
diff --git a/modules/mount_generic.c b/modules/mount_generic.c
index 2473b80..c4108e6 100644
--- a/modules/mount_generic.c
+++ b/modules/mount_generic.c
@@ -39,7 +39,6 @@ int mount_mount(struct autofs_point *ap, const char *root, const char *name, int
{
char fullpath[PATH_MAX];
char buf[MAX_ERR_BUF];
- char *loc;
int err;
int len, status, existed = 1;
@@ -75,44 +74,22 @@ int mount_mount(struct autofs_point *ap, const char *root, const char *name, int
if (!status)
existed = 0;
- /*
- * Special case quoting for cifs share names.
- *
- * Since "\" is a valid seperator for cifs shares it can't be
- * used to escape characters in the share name passed to
- * mount.cifs. So we have no choice but to require that the
- * seperator we use is "/" and de-quote the string before
- * sending it to mount.cifs.
- */
- loc = NULL;
- if (strcmp(fstype, "cifs"))
- loc = strdup(what);
- else
- loc = dequote(what, strlen(what), ap->logopt);
- if (!loc) {
- error(ap->logopt,
- MODPREFIX "failed to alloc buffer for mount location");
- return 1;
- }
-
if (options && options[0]) {
debug(ap->logopt,
MODPREFIX "calling mount -t %s -o %s %s %s",
- fstype, options, loc, fullpath);
+ fstype, options, what, fullpath);
err = spawn_mount(ap->logopt, "-t", fstype,
- "-o", options, loc, fullpath, NULL);
+ "-o", options, what, fullpath, NULL);
} else {
debug(ap->logopt, MODPREFIX "calling mount -t %s %s %s",
- fstype, loc, fullpath);
- err = spawn_mount(ap->logopt, "-t", fstype, loc, fullpath, NULL);
+ fstype, what, fullpath);
+ err = spawn_mount(ap->logopt, "-t", fstype, what, fullpath, NULL);
}
if (err) {
info(ap->logopt, MODPREFIX "failed to mount %s (type %s) on %s",
- loc, fstype, fullpath);
-
- free(loc);
+ what, fstype, fullpath);
if (ap->type != LKP_INDIRECT)
return 1;
@@ -123,8 +100,7 @@ int mount_mount(struct autofs_point *ap, const char *root, const char *name, int
return 1;
} else {
debug(ap->logopt, MODPREFIX "mounted %s type %s on %s",
- loc, fstype, fullpath);
- free(loc);
+ what, fstype, fullpath);
return 0;
}
}
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
^ permalink raw reply related [flat|nested] 3+ messages in thread