From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@techsingularity.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm, numa: Fix bad pmd by atomically check for pmd_trans_huge when marking page tables prot_numa
Date: Mon, 10 Apr 2017 08:38:24 -0400 [thread overview]
Message-ID: <1491827904.8850.178.camel@redhat.com> (raw)
In-Reply-To: <20170410094825.2yfo5zehn7pchg6a@techsingularity.net>
On Mon, 2017-04-10 at 10:48 +0100, Mel Gorman wrote:
>
> While this could be fixed with heavy locking, it's only necessary to
> make a copy of the PMD on the stack during change_pmd_range and avoid
> races. A new helper is created for this as the check if quite subtle
> and the
> existing similar helpful is not suitable. This passed 154 hours of
> testing
> (usually triggers between 20 minutes and 24 hours) without detecting
> bad
> PMDs or corruption. A basic test of an autonuma-intensive workload
> showed
> no significant change in behaviour.
>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> Cc: stable@vger.kernel.org
Acked-by: Rik van Riel <riel@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@techsingularity.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm, numa: Fix bad pmd by atomically check for pmd_trans_huge when marking page tables prot_numa
Date: Mon, 10 Apr 2017 08:38:24 -0400 [thread overview]
Message-ID: <1491827904.8850.178.camel@redhat.com> (raw)
In-Reply-To: <20170410094825.2yfo5zehn7pchg6a@techsingularity.net>
On Mon, 2017-04-10 at 10:48 +0100, Mel Gorman wrote:
>
> While this could be fixed with heavy locking, it's only necessary to
> make a copy of the PMD on the stack during change_pmd_range and avoid
> races. A new helper is created for this as the check if quite subtle
> and the
> existing similar helpful is not suitable. This passed 154 hours of
> testing
> (usually triggers between 20 minutes and 24 hours) without detecting
> bad
> PMDs or corruption. A basic test of an autonuma-intensive workload
> showed
> no significant change in behaviour.
>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> Cc: stable@vger.kernel.org
Acked-by: Rik van Riel <riel@redhat.com>
next prev parent reply other threads:[~2017-04-10 12:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 9:48 [PATCH] mm, numa: Fix bad pmd by atomically check for pmd_trans_huge when marking page tables prot_numa Mel Gorman
2017-04-10 9:48 ` Mel Gorman
2017-04-10 10:03 ` Vlastimil Babka
2017-04-10 10:03 ` Vlastimil Babka
2017-04-10 12:19 ` Mel Gorman
2017-04-10 12:19 ` Mel Gorman
2017-04-10 12:38 ` Rik van Riel [this message]
2017-04-10 12:38 ` Rik van Riel
2017-04-10 13:53 ` Michal Hocko
2017-04-10 13:53 ` Michal Hocko
2017-04-10 17:38 ` Mel Gorman
2017-04-10 17:38 ` Mel Gorman
2017-04-10 16:45 ` Zi Yan
2017-04-10 17:20 ` Mel Gorman
2017-04-10 17:20 ` Mel Gorman
2017-04-10 17:49 ` Zi Yan
2017-04-10 18:07 ` Mel Gorman
2017-04-10 18:07 ` Mel Gorman
2017-04-10 22:09 ` Andrew Morton
2017-04-10 22:09 ` Andrew Morton
2017-04-10 22:28 ` Zi Yan
2017-04-11 6:35 ` Vlastimil Babka
2017-04-11 6:35 ` Vlastimil Babka
2017-04-11 21:44 ` Andrew Morton
2017-04-11 21:44 ` Andrew Morton
2017-04-11 8:29 ` Mel Gorman
2017-04-11 8:29 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2020-02-16 19:18 [PATCH] mm, numa: fix " Rafael Aquini
2020-02-16 23:32 ` Mel Gorman
2020-03-07 2:40 ` Qian Cai
2020-03-07 3:05 ` Rafael Aquini
2020-03-08 3:20 ` Qian Cai
2020-03-08 23:14 ` Rafael Aquini
2020-03-09 3:27 ` Qian Cai
2020-03-09 15:05 ` Rafael Aquini
2020-03-11 0:04 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491827904.8850.178.camel@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.