* [PATCH] drivers/dax: Avoiding potential deadlock
@ 2017-04-11 4:45 Pushkar Jambhlekar
2017-04-11 4:55 ` Dan Williams
0 siblings, 1 reply; 3+ messages in thread
From: Pushkar Jambhlekar @ 2017-04-11 4:45 UTC (permalink / raw)
To: Dan Williams, Dave Jiang, Andrew Morton, Johannes Thumshirn,
Ross Zwisler
Cc: linux-kernel, Pushkar Jambhlekar
dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
rc = __dax_dev_pud_fault(dax_dev, vmf);
break;
default:
- return VM_FAULT_FALLBACK;
+ rc = VM_FAULT_FALLBACK;
}
rcu_read_unlock();
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/dax: Avoiding potential deadlock
2017-04-11 4:45 [PATCH] drivers/dax: Avoiding potential deadlock Pushkar Jambhlekar
@ 2017-04-11 4:55 ` Dan Williams
2017-04-11 5:27 ` Pushkar Jambhlekar
0 siblings, 1 reply; 3+ messages in thread
From: Dan Williams @ 2017-04-11 4:55 UTC (permalink / raw)
To: Pushkar Jambhlekar
Cc: Dave Jiang, Andrew Morton, Johannes Thumshirn, Ross Zwisler,
linux-kernel@vger.kernel.org
On Mon, Apr 10, 2017 at 9:45 PM, Pushkar Jambhlekar
<pushkar.iit@gmail.com> wrote:
> dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/dax/dax.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
> index 0d1ca24..fd9c4db 100644
> --- a/drivers/dax/dax.c
> +++ b/drivers/dax/dax.c
> @@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
> rc = __dax_dev_pud_fault(dax_dev, vmf);
> break;
> default:
> - return VM_FAULT_FALLBACK;
> + rc = VM_FAULT_FALLBACK;
Thanks for the fix! Luckily we never take that branch, but we should
fix it so we don't trip over it in some future where there are more
fault sizes than pte, pmd, and pud. However, it should be setting rc
to VM_FAULT_SIGBUS on an unknown / unsupported fault size.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/dax: Avoiding potential deadlock
2017-04-11 4:55 ` Dan Williams
@ 2017-04-11 5:27 ` Pushkar Jambhlekar
0 siblings, 0 replies; 3+ messages in thread
From: Pushkar Jambhlekar @ 2017-04-11 5:27 UTC (permalink / raw)
To: Dan Williams
Cc: Dave Jiang, Andrew Morton, Johannes Thumshirn, Ross Zwisler,
linux-kernel@vger.kernel.org
Sent out another patch to correct return value.
On Tue, Apr 11, 2017 at 10:25 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Mon, Apr 10, 2017 at 9:45 PM, Pushkar Jambhlekar
> <pushkar.iit@gmail.com> wrote:
>> dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation
>>
>> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
>> ---
>> drivers/dax/dax.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
>> index 0d1ca24..fd9c4db 100644
>> --- a/drivers/dax/dax.c
>> +++ b/drivers/dax/dax.c
>> @@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
>> rc = __dax_dev_pud_fault(dax_dev, vmf);
>> break;
>> default:
>> - return VM_FAULT_FALLBACK;
>> + rc = VM_FAULT_FALLBACK;
>
> Thanks for the fix! Luckily we never take that branch, but we should
> fix it so we don't trip over it in some future where there are more
> fault sizes than pte, pmd, and pud. However, it should be setting rc
> to VM_FAULT_SIGBUS on an unknown / unsupported fault size.
--
Jambhlekar Pushkar Arun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-11 5:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-11 4:45 [PATCH] drivers/dax: Avoiding potential deadlock Pushkar Jambhlekar
2017-04-11 4:55 ` Dan Williams
2017-04-11 5:27 ` Pushkar Jambhlekar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.