diff for duplicates of <1491923975.2654.4.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 6408415..68a4ad0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -On Tue, 2017-04-11 at 16:31 +0200, Javier Gonz=E1lez wrote: +On Tue, 2017-04-11 at 16:31 +0200, Javier González wrote: > Changes since v4: > * Rebase on top of Matias' for-4.12/core > * Fix type implicit conversions reported by sparse (reported by Bart Van @@ -10,16 +10,15 @@ Hello Javier, Thanks for the quick respin. But have you already had a look at the diagnostics reported by smatch? Smatch reports e.g. -drivers/lightnvm/pblk-rb.c:783: pblk_rb_tear_down_check() error: we previou= -sly assumed 'rb->entries' could be null (see line 779) +drivers/lightnvm/pblk-rb.c:783: pblk_rb_tear_down_check() error: we previously assumed 'rb->entries' could be null (see line 779) on the following code: if (rb->entries) goto out; - for (i =3D 0; i < rb->nr_entries; i++) { - entry =3D &rb->entries[i]; + for (i = 0; i < rb->nr_entries; i++) { + entry = &rb->entries[i]; if (entry->data) goto out; @@ -28,4 +27,4 @@ on the following code: Is that "if (rb->entries)" check correct or should that perhaps been "if (!rb->entries)"? Smatch is available at http://repo.or.cz/w/smatch.git. -Bart.= +Bart. diff --git a/a/content_digest b/N1/content_digest index 98b34cd..1bbddf8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -9,7 +9,7 @@ " javier@cnexlabs.com <javier@cnexlabs.com>\0" "\00:1\0" "b\0" - "On Tue, 2017-04-11 at 16:31 +0200, Javier Gonz=E1lez wrote:\n" + "On Tue, 2017-04-11 at 16:31 +0200, Javier Gonz\303\241lez wrote:\n" "> Changes since v4:\n" "> * Rebase on top of Matias' for-4.12/core\n" "> * Fix type implicit conversions reported by sparse (reported by Bart Van\n" @@ -21,16 +21,15 @@ "Thanks for the quick respin. But have you already had a look at the\n" "diagnostics reported by smatch? Smatch reports e.g.\n" "\n" - "drivers/lightnvm/pblk-rb.c:783: pblk_rb_tear_down_check() error: we previou=\n" - "sly assumed 'rb->entries' could be null (see line 779)\n" + "drivers/lightnvm/pblk-rb.c:783: pblk_rb_tear_down_check() error: we previously assumed 'rb->entries' could be null (see line 779)\n" "\n" "on the following code:\n" "\n" "\tif (rb->entries)\n" "\t\tgoto out;\n" "\n" - "\tfor (i =3D 0; i < rb->nr_entries; i++) {\n" - "\t\tentry =3D &rb->entries[i];\n" + "\tfor (i = 0; i < rb->nr_entries; i++) {\n" + "\t\tentry = &rb->entries[i];\n" "\n" "\t\tif (entry->data)\n" "\t\t\tgoto out;\n" @@ -39,6 +38,6 @@ "Is that \"if (rb->entries)\" check correct or should that perhaps been\n" "\"if (!rb->entries)\"? Smatch is available at http://repo.or.cz/w/smatch.git.\n" "\n" - Bart.= + Bart. -7520e44986ee3d2560dbb267a5cd3cf9c76788194b8ad5dd3358eb3e598338cb +ed4c854b13d1d8b7e58c7e48321c71b013e5876fbda48a62c9ddcc69616db8de
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.