All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "mb@lightnvm.io" <mb@lightnvm.io>, "jg@lightnvm.io" <jg@lightnvm.io>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"javier@cnexlabs.com" <javier@cnexlabs.com>
Subject: Re: [PATCH v5] lightnvn: pblk
Date: Tue, 11 Apr 2017 15:19:36 +0000	[thread overview]
Message-ID: <1491923975.2654.4.camel@sandisk.com> (raw)
In-Reply-To: <1491921077-9377-1-git-send-email-javier@cnexlabs.com>

On Tue, 2017-04-11 at 16:31 +0200, Javier Gonz=E1lez wrote:
> Changes since v4:
> * Rebase on top of Matias' for-4.12/core
> * Fix type implicit conversions reported by sparse (reported by Bart Van
>   Assche)
> * Make error and debug statistics long atomic variables.

Hello Javier,

Thanks for the quick respin. But have you already had a look at the
diagnostics reported by smatch? Smatch reports e.g.

drivers/lightnvm/pblk-rb.c:783: pblk_rb_tear_down_check() error: we previou=
sly assumed 'rb->entries' could be null (see line 779)

on the following code:

	if (rb->entries)
		goto out;

	for (i =3D 0; i < rb->nr_entries; i++) {
		entry =3D &rb->entries[i];

		if (entry->data)
			goto out;
	}

Is that "if (rb->entries)" check correct or should that perhaps been
"if (!rb->entries)"? Smatch is available at http://repo.or.cz/w/smatch.git.

Bart.=

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "mb@lightnvm.io" <mb@lightnvm.io>, "jg@lightnvm.io" <jg@lightnvm.io>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"javier@cnexlabs.com" <javier@cnexlabs.com>
Subject: Re: [PATCH v5] lightnvn: pblk
Date: Tue, 11 Apr 2017 15:19:36 +0000	[thread overview]
Message-ID: <1491923975.2654.4.camel@sandisk.com> (raw)
In-Reply-To: <1491921077-9377-1-git-send-email-javier@cnexlabs.com>

On Tue, 2017-04-11 at 16:31 +0200, Javier González wrote:
> Changes since v4:
> * Rebase on top of Matias' for-4.12/core
> * Fix type implicit conversions reported by sparse (reported by Bart Van
>   Assche)
> * Make error and debug statistics long atomic variables.

Hello Javier,

Thanks for the quick respin. But have you already had a look at the
diagnostics reported by smatch? Smatch reports e.g.

drivers/lightnvm/pblk-rb.c:783: pblk_rb_tear_down_check() error: we previously assumed 'rb->entries' could be null (see line 779)

on the following code:

	if (rb->entries)
		goto out;

	for (i = 0; i < rb->nr_entries; i++) {
		entry = &rb->entries[i];

		if (entry->data)
			goto out;
	}

Is that "if (rb->entries)" check correct or should that perhaps been
"if (!rb->entries)"? Smatch is available at http://repo.or.cz/w/smatch.git.

Bart.

  parent reply	other threads:[~2017-04-11 15:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 14:31 [PATCH v5] lightnvn: pblk Javier González
2017-04-11 14:31 ` [PATCH v5] lightnvm: physical block device (pblk) target Javier González
2017-04-11 14:41   ` Matias Bjørling
2017-04-11 15:19 ` Bart Van Assche [this message]
2017-04-11 15:19   ` [PATCH v5] lightnvn: pblk Bart Van Assche
2017-04-11 22:13   ` Javier González
2017-04-11 22:23     ` Bart Van Assche
2017-04-11 22:23       ` Bart Van Assche
2017-04-12  8:04       ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491923975.2654.4.camel@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=javier@cnexlabs.com \
    --cc=jg@lightnvm.io \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.