[PATCH] [RFC] tcf-agent: Re-enable default features

[PATCH] [RFC] tcf-agent: Re-enable default features

[Gernot Hillier]

A number of features were disabled due to historic problems on ARM dating back
to tcf-agent 0.0+svnr1855 (from 2011). For us, these features do not only
compile perfectly for cortexa9hf, but are required for target debugging with
CDT in Xilinx Vivado SDK 2016.4.

Signed-off-by: Gernot Hillier <gernot.hillier@siemens.com>
---
 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
index e5e41f148e..035f2368d8 100644
--- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
+++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
@@ -35,12 +35,6 @@ MAKE_OS = "`echo ${TARGET_OS} | sed s,^linux.*,GNU/Linux,`"
 
 EXTRA_OEMAKE = "MACHINE=${MAKE_ARCH} OPSYS=${MAKE_OS} 'CC=${CC}' 'AR=${AR}'"
 
-# They don't build on ARM and we don't need them actually.
-CFLAGS += "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
-    -DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
-    -DSERVICE_StackTrace=0 -DSERVICE_Symbols=0 -DSERVICE_LineNumbers=0 \
-    -DSERVICE_Expressions=0"
-
 do_install() {
 	oe_runmake install INSTALLROOT=${D}
 	install -d ${D}${sysconfdir}/init.d/
-- 
2.12.0

Re: [PATCH] [RFC] tcf-agent: Re-enable default features

[Richard Purdie]

On Wed, 2017-04-12 at 16:44 +0200, Gernot Hillier wrote:
> A number of features were disabled due to historic problems on ARM
> dating back
> to tcf-agent 0.0+svnr1855 (from 2011). For us, these features do not
> only
> compile perfectly for cortexa9hf, but are required for target
> debugging with
> CDT in Xilinx Vivado SDK 2016.4.
> 
> Signed-off-by: Gernot Hillier <gernot.hillier@siemens.com>
> ---
>  meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 6 ------
>  1 file changed, 6 deletions(-)

Needs to be sent to the OE-Core list and breaks the build at least on
mips:

https://autobuilder.yocto.io/builders/nightly-mips-lsb/builds/229/steps/BuildImages/logs/stdio

Cheers,

Richard

Re: [PATCH] [RFC] tcf-agent: Re-enable default features

[Gernot Hillier]

On 12.04.2017 23:16, Richard Purdie wrote:
> On Wed, 2017-04-12 at 16:44 +0200, Gernot Hillier wrote:
>> A number of features were disabled due to historic problems on ARM
>> dating back
>> to tcf-agent 0.0+svnr1855 (from 2011). For us, these features do not
>> only
>> compile perfectly for cortexa9hf, but are required for target
>> debugging with
>> CDT in Xilinx Vivado SDK 2016.4.
>>
>> Signed-off-by: Gernot Hillier <gernot.hillier@siemens.com>
>> ---
>>  meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 6 ------
>>  1 file changed, 6 deletions(-)
> 
> Needs to be sent to the OE-Core list and breaks the build at least on
> mips:
> 
> https://autobuilder.yocto.io/builders/nightly-mips-lsb/builds/229/steps/BuildImages/logs/stdio

Thx for instructions & feeding this into your autobuilder!! I'll check
and fix for main architectures and come back to oe-core when ready.

-- 
Gernot
Siemens AG, Corporate Competence Center Embedded Linux