From: Johannes Berg <johannes@sipsolutions.net>
To: nicolas.dichtel@6wind.com, David Ahern <dsa@cumulusnetworks.com>,
Jiri Pirko <jiri@resnulli.us>, Pravin Shelar <pshelar@nicira.com>,
dev@openvswitch.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
pablo@netfilter.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Benc <jbenc@redhat.com>
Subject: Re: [PATCH 1/5] netlink: extended ACK reporting
Date: Thu, 13 Apr 2017 21:24:40 +0200 [thread overview]
Message-ID: <1492111480.29526.7.camel@sipsolutions.net> (raw)
In-Reply-To: <28b0d93a-7e96-f7eb-b140-afc9ad429c30@6wind.com> (sfid-20170413_160541_831386_A409D7A6)
On Thu, 2017-04-13 at 16:05 +0200, Nicolas Dichtel wrote:
> Sure. It was just to mention that attribute 0 exists somewhere.
> The other 0 attribute is OVS_TUNNEL_KEY_ATTR_ID.
That looks like some really awkward hand-grown parsing - with all these
"struct ovs_len_tbl" looking almost like a policy, but not using that
code?
Seems like something somebody should take a hard look at and see if it
can't use more standard infrastructure.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org,
David Ahern
<dsa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>,
Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>,
Pravin Shelar <pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>,
dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jamal Hadi Salim <jhs-jkUAjuhPggJWk0Htik3J/w@public.gmane.org>,
pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org,
Jiri Benc <jbenc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/5] netlink: extended ACK reporting
Date: Thu, 13 Apr 2017 21:24:40 +0200 [thread overview]
Message-ID: <1492111480.29526.7.camel@sipsolutions.net> (raw)
In-Reply-To: <28b0d93a-7e96-f7eb-b140-afc9ad429c30-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> (sfid-20170413_160541_831386_A409D7A6)
On Thu, 2017-04-13 at 16:05 +0200, Nicolas Dichtel wrote:
> Sure. It was just to mention that attribute 0 exists somewhere.
> The other 0 attribute is OVS_TUNNEL_KEY_ATTR_ID.
That looks like some really awkward hand-grown parsing - with all these
"struct ovs_len_tbl" looking almost like a policy, but not using that
code?
Seems like something somebody should take a hard look at and see if it
can't use more standard infrastructure.
johannes
next prev parent reply other threads:[~2017-04-13 19:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 17:48 [PATCH 0/5] extended netlink ACK reporting Johannes Berg
2017-04-08 17:48 ` Johannes Berg
2017-04-08 17:48 ` [PATCH 1/5] netlink: extended " Johannes Berg
2017-04-08 18:26 ` David Ahern
2017-04-08 18:34 ` Jiri Pirko
2017-04-08 18:37 ` Johannes Berg
2017-04-08 18:40 ` Jiri Pirko
2017-04-08 20:13 ` Johannes Berg
2017-04-08 20:13 ` Johannes Berg
2017-04-09 17:43 ` David Ahern
2017-04-09 17:43 ` David Ahern
2017-04-10 6:18 ` Johannes Berg
2017-04-13 13:27 ` Nicolas Dichtel
2017-04-13 13:27 ` Nicolas Dichtel
2017-04-13 13:29 ` Johannes Berg
2017-04-13 14:05 ` Nicolas Dichtel
2017-04-13 14:05 ` Nicolas Dichtel
2017-04-13 19:24 ` Johannes Berg [this message]
2017-04-13 19:24 ` Johannes Berg
[not found] ` <1492111480.29526.7.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-13 21:44 ` Joe Stringer
2017-04-18 9:41 ` Johannes Berg
2017-04-18 9:41 ` Johannes Berg
2017-04-18 23:46 ` Joe Stringer
2017-04-18 23:46 ` Joe Stringer
2017-04-16 14:40 ` second wave of netlink " Jamal Hadi Salim
2017-04-16 14:40 ` Jamal Hadi Salim
2017-04-16 14:45 ` David Ahern
2017-04-16 14:45 ` David Ahern
2017-04-16 14:48 ` Jamal Hadi Salim
2017-04-16 14:48 ` Jamal Hadi Salim
2017-04-16 14:50 ` David Ahern
2017-04-16 14:50 ` David Ahern
2017-04-16 16:55 ` David Ahern
2017-04-16 16:55 ` David Ahern
2017-04-08 18:36 ` [PATCH 1/5] netlink: " David Ahern
2017-04-08 18:36 ` David Ahern
2017-04-08 18:37 ` Johannes Berg
2017-04-08 18:37 ` Johannes Berg
2017-04-08 20:14 ` David Ahern
2017-04-08 17:48 ` [PATCH 2/5] genetlink: pass extended ACK report down Johannes Berg
2017-04-08 17:48 ` [PATCH 3/5] netlink: allow sending extended ACK with cookie on success Johannes Berg
2017-04-08 17:48 ` Johannes Berg
2017-04-08 17:48 ` [PATCH 4/5] netlink: pass extended ACK struct to parsing functions Johannes Berg
2017-04-08 18:50 ` David Ahern
2017-04-08 18:50 ` David Ahern
2017-04-08 20:15 ` Johannes Berg
2017-04-08 20:15 ` Johannes Berg
2017-04-08 17:49 ` [PATCH 5/5] netlink: pass extended ACK struct where available Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492111480.29526.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dev@openvswitch.org \
--cc=dsa@cumulusnetworks.com \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pablo@netfilter.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.