All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leonard Crestez <leonard.crestez-3arQi8VN3Tc@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Viresh Kumar
	<viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
	Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Robin Gong <yibin.gong-3arQi8VN3Tc@public.gmane.org>,
	Anson Huang <Anson.Huang-3arQi8VN3Tc@public.gmane.org>,
	Irina Tirdea <irina.tirdea-3arQi8VN3Tc@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
	Octavian Purdila <octavian.purdila-3arQi8VN3Tc@public.gmane.org>,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints
Date: Thu, 13 Apr 2017 23:46:15 +0300	[thread overview]
Message-ID: <1492116375.17723.15.camel@nxp.com> (raw)
In-Reply-To: <20170407112212.gzv3p7ldkh62657m-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

On Fri, 2017-04-07 at 12:22 +0100, Mark Brown wrote:
> On Fri, Apr 07, 2017 at 01:51:52PM +0300, Leonard Crestez wrote:

> > It currently seems to work how I expect but from your statement it's
> > not clear if it's entirely intentional.

> The current behaviour of bypassed regulators is intentional.

I did not mean to imply that there is something wrong with bypassed
regulators. I just wanted more information about how regulators (non-
bypassed) pick their voltage when consumers allow a range.

After some more reading through the code it seems that the driver
itself receives the range (either through set_voltage or map_voltage)
and gets to make the choice.

So it seems fine for my concerns, sorry to bother you.

--
Regards,
Leonard
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: leonard.crestez@nxp.com (Leonard Crestez)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 4/8] regulator: core: Check enabling bypass respects constraints
Date: Thu, 13 Apr 2017 23:46:15 +0300	[thread overview]
Message-ID: <1492116375.17723.15.camel@nxp.com> (raw)
In-Reply-To: <20170407112212.gzv3p7ldkh62657m@sirena.org.uk>

On Fri, 2017-04-07 at 12:22 +0100, Mark Brown wrote:
> On Fri, Apr 07, 2017 at 01:51:52PM +0300, Leonard Crestez wrote:

> > It currently seems to work how I expect but from your statement it's
> > not clear if it's entirely intentional.

> The current behaviour of bypassed regulators is intentional.

I did not mean to imply that there is something wrong with bypassed
regulators. I just wanted more information about how regulators (non-
bypassed) pick their voltage when consumers allow a range.

After some more reading through the code it seems that the driver
itself receives the range (either through set_voltage or map_voltage)
and gets to make the choice.

So it seems fine for my concerns, sorry to bother you.

--
Regards,
Leonard

WARNING: multiple messages have this Message-ID (diff)
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Mark Brown <broonie@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Shawn Guo <shawnguo@kernel.org>, Robin Gong <yibin.gong@nxp.com>,
	Anson Huang <Anson.Huang@nxp.com>,
	Irina Tirdea <irina.tirdea@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	"Octavian Purdila" <octavian.purdila@nxp.com>,
	<linux-pm@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints
Date: Thu, 13 Apr 2017 23:46:15 +0300	[thread overview]
Message-ID: <1492116375.17723.15.camel@nxp.com> (raw)
In-Reply-To: <20170407112212.gzv3p7ldkh62657m@sirena.org.uk>

On Fri, 2017-04-07 at 12:22 +0100, Mark Brown wrote:
> On Fri, Apr 07, 2017 at 01:51:52PM +0300, Leonard Crestez wrote:

> > It currently seems to work how I expect but from your statement it's
> > not clear if it's entirely intentional.

> The current behaviour of bypassed regulators is intentional.

I did not mean to imply that there is something wrong with bypassed
regulators. I just wanted more information about how regulators (non-
bypassed) pick their voltage when consumers allow a range.

After some more reading through the code it seems that the driver
itself receives the range (either through set_voltage or map_voltage)
and gets to make the choice.

So it seems fine for my concerns, sorry to bother you.

--
Regards,
Leonard

  parent reply	other threads:[~2017-04-13 20:46 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 16:53 [RFC 0/8] ARM: imx: Upstream fsl,ldo-bypass Leonard Crestez
2017-03-22 16:53 ` Leonard Crestez
2017-03-22 16:53 ` Leonard Crestez
2017-03-22 16:53 ` [RFC 1/8] ARM: imx: gpc: Do not print error message for EPROBE_DEFER Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 16:53 ` [RFC 2/8] cpufreq: imx6q: Fix handling EPROBE_DEFER from regulator Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
     [not found]   ` <7f2618363d43b30db29f5f8ae822df413392f99d.1490199005.git.leonard.crestez-3arQi8VN3Tc@public.gmane.org>
2017-03-23  4:33     ` Viresh Kumar
2017-03-23  4:33       ` Viresh Kumar
2017-03-23  4:33       ` Viresh Kumar
2017-03-22 16:53 ` [RFC 3/8] cpufreq: imx6q: Set max suspend_freq to avoid changes during suspend Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-23  4:34   ` Viresh Kumar
2017-03-23  4:34     ` Viresh Kumar
2017-03-28 20:03     ` Leonard Crestez
2017-03-28 20:03       ` Leonard Crestez
2017-03-28 20:03       ` Leonard Crestez
2017-03-28 20:50       ` Rafael J. Wysocki
2017-03-28 20:50         ` Rafael J. Wysocki
2017-03-28 20:50         ` Rafael J. Wysocki
2017-03-28 22:23         ` Rafael J. Wysocki
2017-03-28 22:23           ` Rafael J. Wysocki
2017-03-22 16:53 ` [RFC 4/8] regulator: core: Check enabling bypass respects constraints Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
     [not found]   ` <1edff9bc610969b0c53fa1080d5db021c8e00b2d.1490199005.git.leonard.crestez-3arQi8VN3Tc@public.gmane.org>
2017-03-24 12:52     ` Mark Brown
2017-03-24 12:52       ` Mark Brown
2017-03-24 12:52       ` Mark Brown
2017-03-28 12:39       ` Leonard Crestez
2017-03-28 12:39         ` Leonard Crestez
2017-03-28 12:39         ` Leonard Crestez
     [not found]         ` <1490704781.3546.57.camel-3arQi8VN3Tc@public.gmane.org>
2017-03-28 16:47           ` Mark Brown
2017-03-28 16:47             ` Mark Brown
2017-03-28 16:47             ` Mark Brown
2017-03-28 19:49             ` Leonard Crestez
2017-03-28 19:49               ` Leonard Crestez
2017-03-28 19:49               ` Leonard Crestez
     [not found]               ` <1490730595.15830.1.camel-3arQi8VN3Tc@public.gmane.org>
2017-04-06 18:52                 ` Mark Brown
2017-04-06 18:52                   ` Mark Brown
2017-04-06 18:52                   ` Mark Brown
     [not found]                   ` <20170406185202.uixxcv3dgucrddgc-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-04-07 10:51                     ` Leonard Crestez
2017-04-07 10:51                       ` Leonard Crestez
2017-04-07 10:51                       ` Leonard Crestez
2017-04-07 11:22                       ` Mark Brown
2017-04-07 11:22                         ` Mark Brown
     [not found]                         ` <20170407112212.gzv3p7ldkh62657m-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-04-13 20:46                           ` Leonard Crestez [this message]
2017-04-13 20:46                             ` Leonard Crestez
2017-04-13 20:46                             ` Leonard Crestez
2017-03-22 16:53 ` [RFC 5/8] regulator: anatop: fix min dropout for bypass mode Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-24 12:54   ` Mark Brown
2017-03-24 12:54     ` Mark Brown
2017-03-24 12:54     ` Mark Brown
2017-03-28 11:52     ` Leonard Crestez
2017-03-28 11:52       ` Leonard Crestez
2017-03-28 11:52       ` Leonard Crestez
2017-03-22 16:53 ` [RFC 6/8] regulator: core: Add regulator_is_bypass function Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
     [not found]   ` <e74c2f4d2b452cbe01aa2a48edde5c024212ffcb.1490199005.git.leonard.crestez-3arQi8VN3Tc@public.gmane.org>
2017-03-24 12:55     ` Mark Brown
2017-03-24 12:55       ` Mark Brown
2017-03-24 12:55       ` Mark Brown
2017-03-28 14:53       ` Leonard Crestez
2017-03-28 14:53         ` Leonard Crestez
2017-03-28 14:53         ` Leonard Crestez
2017-03-22 16:53 ` [RFC 7/8] cpufreq: imx6q: Initialize LDO bypass Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 17:09   ` Lucas Stach
2017-03-22 17:09     ` Lucas Stach
2017-03-22 17:09     ` Lucas Stach
     [not found]     ` <1490202585.29056.5.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-03-22 17:48       ` Leonard Crestez
2017-03-22 17:48         ` Leonard Crestez
2017-03-22 17:48         ` Leonard Crestez
2017-03-22 18:00         ` Lucas Stach
2017-03-22 18:00           ` Lucas Stach
2017-03-22 16:53 ` [RFC 8/8] ARM: dts: imx6qdl-sabresd: Enable fsl,ldo-bypass Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 16:53   ` Leonard Crestez
2017-03-22 17:13   ` Lucas Stach
2017-03-22 17:13     ` Lucas Stach
     [not found]     ` <1490202830.29056.8.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-03-29 13:32       ` Leonard Crestez
2017-03-29 13:32         ` Leonard Crestez
2017-03-29 13:32         ` Leonard Crestez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492116375.17723.15.camel@nxp.com \
    --to=leonard.crestez-3arqi8vn3tc@public.gmane.org \
    --cc=Anson.Huang-3arQi8VN3Tc@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
    --cc=irina.tirdea-3arQi8VN3Tc@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=octavian.purdila-3arQi8VN3Tc@public.gmane.org \
    --cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=yibin.gong-3arQi8VN3Tc@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.