All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kani, Toshimitsu" <toshi.kani-ZPxbGqLxI0U@public.gmane.org>
To: "dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org"
	<linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org>
Cc: "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/5] acpi, nfit: add support for acpi 6.1 dimm state flags
Date: Mon, 17 Apr 2017 17:28:56 +0000	[thread overview]
Message-ID: <1492450115.26622.3.camel@hpe.com> (raw)
In-Reply-To: <149218910195.3926.13927602427357940056.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Fri, 2017-04-14 at 09:58 -0700, Dan Williams wrote:
> Add support for the ACPI_NFIT_MEM_MAP_FAILED ("map_fail") and
> ACPI_NFIT_MEM_HEALTH_ENABLED ("smart_notify") health state flags. The
> "map_fail" flag identifies DIMMs that were not mapped into one or
> more physical address ranges. The "health_notify" flag indicates
> whether platform firmware will send notifications when there is new
> SMART health data to consume.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/acpi/nfit/core.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 53943d6f4214..05829de43b1d 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1246,12 +1246,14 @@ static ssize_t flags_show(struct device *dev,
>  {
>  	u16 flags = to_nfit_memdev(dev)->flags;
>  
> -	return sprintf(buf, "%s%s%s%s%s\n",
> +	return sprintf(buf, "%s%s%s%s%s%s%s\n",
>  		flags & ACPI_NFIT_MEM_SAVE_FAILED ? "save_fail " :
> "",
>  		flags & ACPI_NFIT_MEM_RESTORE_FAILED ? "restore_fail
> " : "",
>  		flags & ACPI_NFIT_MEM_FLUSH_FAILED ? "flush_fail " :
> "",
>  		flags & ACPI_NFIT_MEM_NOT_ARMED ? "not_armed " : "",
> -		flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event
> " : "");
> +		flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event
> " : "",
> +		flags & ACPI_NFIT_MEM_MAP_FAILED ? "map_fail " : "",
> +		flags & ACPI_NFIT_MEM_HEALTH_ENABLED ? "smart_notify
> " : "");

Thanks for the update!  The above change looks good, but we will also
need to make the same changes to the dev_info() in
acpi_nfit_register_dimms().

-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] acpi, nfit: add support for acpi 6.1 dimm state flags
Date: Mon, 17 Apr 2017 17:28:56 +0000	[thread overview]
Message-ID: <1492450115.26622.3.camel@hpe.com> (raw)
In-Reply-To: <149218910195.3926.13927602427357940056.stgit@dwillia2-desk3.amr.corp.intel.com>

On Fri, 2017-04-14 at 09:58 -0700, Dan Williams wrote:
> Add support for the ACPI_NFIT_MEM_MAP_FAILED ("map_fail") and
> ACPI_NFIT_MEM_HEALTH_ENABLED ("smart_notify") health state flags. The
> "map_fail" flag identifies DIMMs that were not mapped into one or
> more physical address ranges. The "health_notify" flag indicates
> whether platform firmware will send notifications when there is new
> SMART health data to consume.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/acpi/nfit/core.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 53943d6f4214..05829de43b1d 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1246,12 +1246,14 @@ static ssize_t flags_show(struct device *dev,
>  {
>  	u16 flags = to_nfit_memdev(dev)->flags;
>  
> -	return sprintf(buf, "%s%s%s%s%s\n",
> +	return sprintf(buf, "%s%s%s%s%s%s%s\n",
>  		flags & ACPI_NFIT_MEM_SAVE_FAILED ? "save_fail " :
> "",
>  		flags & ACPI_NFIT_MEM_RESTORE_FAILED ? "restore_fail
> " : "",
>  		flags & ACPI_NFIT_MEM_FLUSH_FAILED ? "flush_fail " :
> "",
>  		flags & ACPI_NFIT_MEM_NOT_ARMED ? "not_armed " : "",
> -		flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event
> " : "");
> +		flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event
> " : "",
> +		flags & ACPI_NFIT_MEM_MAP_FAILED ? "map_fail " : "",
> +		flags & ACPI_NFIT_MEM_HEALTH_ENABLED ? "smart_notify
> " : "");

Thanks for the update!  The above change looks good, but we will also
need to make the same changes to the dev_info() in
acpi_nfit_register_dimms().

-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Subject: Re: [PATCH 2/5] acpi, nfit: add support for acpi 6.1 dimm state flags
Date: Mon, 17 Apr 2017 17:28:56 +0000	[thread overview]
Message-ID: <1492450115.26622.3.camel@hpe.com> (raw)
In-Reply-To: <149218910195.3926.13927602427357940056.stgit@dwillia2-desk3.amr.corp.intel.com>

On Fri, 2017-04-14 at 09:58 -0700, Dan Williams wrote:
> Add support for the ACPI_NFIT_MEM_MAP_FAILED ("map_fail") and
> ACPI_NFIT_MEM_HEALTH_ENABLED ("smart_notify") health state flags. The
> "map_fail" flag identifies DIMMs that were not mapped into one or
> more physical address ranges. The "health_notify" flag indicates
> whether platform firmware will send notifications when there is new
> SMART health data to consume.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/acpi/nfit/core.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 53943d6f4214..05829de43b1d 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1246,12 +1246,14 @@ static ssize_t flags_show(struct device *dev,
>  {
>  	u16 flags = to_nfit_memdev(dev)->flags;
>  
> -	return sprintf(buf, "%s%s%s%s%s\n",
> +	return sprintf(buf, "%s%s%s%s%s%s%s\n",
>  		flags & ACPI_NFIT_MEM_SAVE_FAILED ? "save_fail " :
> "",
>  		flags & ACPI_NFIT_MEM_RESTORE_FAILED ? "restore_fail
> " : "",
>  		flags & ACPI_NFIT_MEM_FLUSH_FAILED ? "flush_fail " :
> "",
>  		flags & ACPI_NFIT_MEM_NOT_ARMED ? "not_armed " : "",
> -		flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event
> " : "");
> +		flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event
> " : "",
> +		flags & ACPI_NFIT_MEM_MAP_FAILED ? "map_fail " : "",
> +		flags & ACPI_NFIT_MEM_HEALTH_ENABLED ? "smart_notify
> " : "");

Thanks for the update!  The above change looks good, but we will also
need to make the same changes to the dev_info() in
acpi_nfit_register_dimms().

-Toshi

  parent reply	other threads:[~2017-04-17 17:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 16:58 [PATCH 0/5] libnvdimm: acpi updates and a revert Dan Williams
2017-04-14 16:58 ` Dan Williams
2017-04-14 16:58 ` [PATCH 2/5] acpi, nfit: add support for acpi 6.1 dimm state flags Dan Williams
2017-04-14 16:58   ` Dan Williams
2017-04-14 16:58   ` Dan Williams
     [not found]   ` <149218910195.3926.13927602427357940056.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-17 17:28     ` Kani, Toshimitsu [this message]
2017-04-17 17:28       ` Kani, Toshimitsu
2017-04-17 17:28       ` Kani, Toshimitsu
     [not found] ` <149218909065.3926.1234846095650907678.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-14 16:58   ` [PATCH 1/5] Revert "libnvdimm: band aid btt vs clear poison locking" Dan Williams
2017-04-14 16:58     ` Dan Williams
2017-04-14 16:58     ` Dan Williams
2017-04-14 16:58   ` [PATCH 3/5] tools/testing/nvdimm: test acpi 6.1 health state flags Dan Williams
2017-04-14 16:58     ` Dan Williams
2017-04-14 16:58     ` Dan Williams
2017-04-14 16:58   ` [PATCH 4/5] acpi, nfit: support "map failed" dimms Dan Williams
2017-04-14 16:58     ` Dan Williams
2017-04-14 16:58     ` Dan Williams
2017-04-17 18:16     ` Kani, Toshimitsu
2017-04-17 18:16       ` Kani, Toshimitsu
2017-04-17 18:16       ` Kani, Toshimitsu
2017-04-14 16:58   ` [PATCH 5/5] acpi, nfit: limit ->flush_probe() to initialization work Dan Williams
2017-04-14 16:58     ` Dan Williams
2017-04-14 16:58     ` Dan Williams
     [not found]     ` <149218911796.3926.17292323458849061393.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-14 17:30       ` Dan Williams
2017-04-14 17:30         ` Dan Williams
2017-04-14 17:30         ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492450115.26622.3.camel@hpe.com \
    --to=toshi.kani-zpxbgqlxi0u@public.gmane.org \
    --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.