From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>,
surenderpolsani <surenderpolsani@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging : rtl8188eu : remove void function return
Date: Tue, 18 Apr 2017 05:03:09 -0700 [thread overview]
Message-ID: <1492516989.8661.36.camel@perches.com> (raw)
In-Reply-To: <20170418115249.GD17911@kroah.com>
On Tue, 2017-04-18 at 13:52 +0200, Greg KH wrote:
> On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote:
> > kernel coding style doesn't allow the return statement
> > in void function.
> >
> > Signed-off-by: surenderpolsani <surenderpolsani@gmail.com>
>
> I need a "real" name here, and in the from line please. Use what you
> use to sign documents.
You'll also need a patch that compiles properly.
void foo(void)
{
goto bar;
bar:
}
doesn't compile with gcc.
This patch removes the required statement after the
label immediately before the function end.
It could be replaced by just a semicolon which is
done a few places in the kernel or just left as-is.
next prev parent reply other threads:[~2017-04-18 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 6:27 [PATCH] staging : rtl8188eu : remove void function return surenderpolsani
2017-04-18 11:52 ` Greg KH
2017-04-18 12:03 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-04-21 3:54 surenderpolsani
2017-04-28 10:28 ` Greg KH
2017-05-03 5:59 Surender Polsani
2017-05-03 10:46 ` Dan Carpenter
2017-05-03 11:21 Surender Polsani
2017-05-03 11:24 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492516989.8661.36.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=surenderpolsani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.