All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lubomir Rintel <lkundrak@v3.sk>
To: Jose Abreu <Jose.Abreu@synopsys.com>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module
Date: Wed, 19 Apr 2017 18:14:21 +0200	[thread overview]
Message-ID: <1492618461.28092.18.camel@v3.sk> (raw)
In-Reply-To: <2e39b000-bf25-6447-b53b-047401041f4e@synopsys.com>

On Wed, 2017-04-19 at 17:12 +0100, Jose Abreu wrote:
> Hi Lubomir,
> 
> 
> On 18-04-2017 18:15, Mark Brown wrote:
> > On Tue, Apr 18, 2017 at 06:13:30PM +0200, Lubomir Rintel wrote:
> > 
> > > I don't think designware_pcm is a separate driver. It looks
> > > tightly
> > > coupled with designware_i2s: you can either disable
> > > designware_pcm
> > > altogether at build time or always load it together with
> > > designware_i2s.
> > 
> > Yes, they're closely coupled but we might still want them both as a
> > module.
> 
> Thanks for the patch but I agree with Mark.
> 
> For the record you can add "MODULE_LICENSE(“Dual MIT/GPL”)".

Sorry if I'm missing something; but I still fail to understand why is
that a good idea.

What is the point of having a pair of modules that depend on each other
and can only be loaded together?

> Best regards,
> Jose Miguel Abreu

Lubo
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Lubomir Rintel <lkundrak@v3.sk>
To: Jose Abreu <Jose.Abreu@synopsys.com>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module
Date: Wed, 19 Apr 2017 18:14:21 +0200	[thread overview]
Message-ID: <1492618461.28092.18.camel@v3.sk> (raw)
In-Reply-To: <2e39b000-bf25-6447-b53b-047401041f4e@synopsys.com>

On Wed, 2017-04-19 at 17:12 +0100, Jose Abreu wrote:
> Hi Lubomir,
> 
> 
> On 18-04-2017 18:15, Mark Brown wrote:
> > On Tue, Apr 18, 2017 at 06:13:30PM +0200, Lubomir Rintel wrote:
> > 
> > > I don't think designware_pcm is a separate driver. It looks
> > > tightly
> > > coupled with designware_i2s: you can either disable
> > > designware_pcm
> > > altogether at build time or always load it together with
> > > designware_i2s.
> > 
> > Yes, they're closely coupled but we might still want them both as a
> > module.
> 
> Thanks for the patch but I agree with Mark.
> 
> For the record you can add "MODULE_LICENSE(“Dual MIT/GPL”)".

Sorry if I'm missing something; but I still fail to understand why is
that a good idea.

What is the point of having a pair of modules that depend on each other
and can only be loaded together?

> Best regards,
> Jose Miguel Abreu

Lubo

  reply	other threads:[~2017-04-19 16:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 10:59 [PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel
2017-04-18 10:59 ` Lubomir Rintel
2017-04-18 15:18 ` Mark Brown
2017-04-18 16:13   ` Lubomir Rintel
2017-04-18 16:13     ` Lubomir Rintel
2017-04-18 17:15     ` Mark Brown
2017-04-18 17:15       ` Mark Brown
2017-04-19 16:12       ` Jose Abreu
2017-04-19 16:12         ` Jose Abreu
2017-04-19 16:14         ` Lubomir Rintel [this message]
2017-04-19 16:14           ` Lubomir Rintel
2017-04-19 16:48           ` Jose Abreu
2017-04-19 16:48             ` Jose Abreu
2017-04-20 19:46             ` Mark Brown
2017-04-20 19:46               ` Mark Brown
2017-04-20 20:24               ` Takashi Iwai
2017-04-20 20:24                 ` [alsa-devel] " Takashi Iwai
2017-04-20 20:25                 ` Mark Brown
2017-04-20 20:25                   ` [alsa-devel] " Mark Brown
2017-04-21 10:34                 ` Jose Abreu
2017-04-21 10:34                   ` [alsa-devel] " Jose Abreu
2017-04-21 10:39                   ` Takashi Iwai
2017-04-21 10:39                     ` [alsa-devel] " Takashi Iwai
2017-04-21 10:49                     ` Mark Brown
2017-04-27 18:49                       ` Jose Abreu
2017-04-27 18:49                         ` [alsa-devel] " Jose Abreu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492618461.28092.18.camel@v3.sk \
    --to=lkundrak@v3.sk \
    --cc=Jose.Abreu@synopsys.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.