* [PATCH linux dev-4.7 v5 0/2] enable gpio-keys
@ 2017-04-21 3:19 Brad Bishop
2017-04-21 3:19 ` [PATCH linux dev-4.7 v5 1/2] ARM: configs: aspeed: Enable keyboard-gpio Brad Bishop
2017-04-21 3:19 ` [PATCH linux dev-4.7 v5 2/2] ARM: dts: Enable checkstop and cooling gpio keys Brad Bishop
0 siblings, 2 replies; 7+ messages in thread
From: Brad Bishop @ 2017-04-21 3:19 UTC (permalink / raw)
To: openbmc, joel, andrew
v5:
Revert back to a single device.
v4:
Describe GPIO function in device path.
v3:
Drop phandle and flags from linux,code.
Assign gpios to their own evdev.
v2:
Use gpio numbers for keycodes.
Brad Bishop (2):
ARM: configs: aspeed: Enable keyboard-gpio
ARM: dts: Enable checkstop and cooling gpio keys
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 16 ++++++++++++++++
arch/arm/configs/aspeed_g4_defconfig | 8 +++++++-
arch/arm/configs/aspeed_g5_defconfig | 8 +++++++-
3 files changed, 30 insertions(+), 2 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH linux dev-4.7 v5 1/2] ARM: configs: aspeed: Enable keyboard-gpio
2017-04-21 3:19 [PATCH linux dev-4.7 v5 0/2] enable gpio-keys Brad Bishop
@ 2017-04-21 3:19 ` Brad Bishop
2017-04-21 3:40 ` Andrew Jeffery
2017-04-21 3:19 ` [PATCH linux dev-4.7 v5 2/2] ARM: dts: Enable checkstop and cooling gpio keys Brad Bishop
1 sibling, 1 reply; 7+ messages in thread
From: Brad Bishop @ 2017-04-21 3:19 UTC (permalink / raw)
To: openbmc, joel, andrew
Some OpenBMC systems will be using keyboard-gpio so enable it
in our configs.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
---
arch/arm/configs/aspeed_g4_defconfig | 8 +++++++-
arch/arm/configs/aspeed_g5_defconfig | 8 +++++++-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/arch/arm/configs/aspeed_g4_defconfig b/arch/arm/configs/aspeed_g4_defconfig
index 552297b..4350f67 100644
--- a/arch/arm/configs/aspeed_g4_defconfig
+++ b/arch/arm/configs/aspeed_g4_defconfig
@@ -103,7 +103,12 @@ CONFIG_FTGMAC100=y
CONFIG_BROADCOM_PHY=y
CONFIG_REALTEK_PHY=y
# CONFIG_WLAN is not set
-# CONFIG_INPUT is not set
+# CONFIG_INPUT_LEDS is not set
+# CONFIG_INPUT_MOUSEDEV is not set
+CONFIG_INPUT_EVDEV=y
+# CONFIG_KEYBOARD_ATKBD is not set
+CONFIG_KEYBOARD_GPIO=y
+# CONFIG_INPUT_MOUSE is not set
# CONFIG_SERIO is not set
# CONFIG_VT is not set
# CONFIG_LEGACY_PTYS is not set
@@ -138,6 +143,7 @@ CONFIG_SENSORS_ADM1275=y
CONFIG_SENSORS_LM25066=y
CONFIG_SENSORS_UCD9000=y
CONFIG_SENSORS_TMP421=y
+# CONFIG_HID is not set
# CONFIG_USB_SUPPORT is not set
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=y
diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig
index c5e7295..b6b3ca0 100644
--- a/arch/arm/configs/aspeed_g5_defconfig
+++ b/arch/arm/configs/aspeed_g5_defconfig
@@ -102,7 +102,12 @@ CONFIG_FTGMAC100=y
CONFIG_BROADCOM_PHY=y
CONFIG_REALTEK_PHY=y
# CONFIG_WLAN is not set
-# CONFIG_INPUT is not set
+# CONFIG_INPUT_LEDS is not set
+# CONFIG_INPUT_MOUSEDEV is not set
+CONFIG_INPUT_EVDEV=y
+# CONFIG_KEYBOARD_ATKBD is not set
+CONFIG_KEYBOARD_GPIO=y
+# CONFIG_INPUT_MOUSE is not set
# CONFIG_SERIO is not set
# CONFIG_VT is not set
# CONFIG_LEGACY_PTYS is not set
@@ -135,6 +140,7 @@ CONFIG_PMBUS=y
CONFIG_SENSORS_LM25066=y
CONFIG_SENSORS_UCD9000=y
CONFIG_SENSORS_TMP421=y
+# CONFIG_HID is not set
# CONFIG_USB_SUPPORT is not set
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=y
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-4.7 v5 1/2] ARM: configs: aspeed: Enable keyboard-gpio
2017-04-21 3:19 ` [PATCH linux dev-4.7 v5 1/2] ARM: configs: aspeed: Enable keyboard-gpio Brad Bishop
@ 2017-04-21 3:40 ` Andrew Jeffery
2017-04-21 3:45 ` Joel Stanley
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Jeffery @ 2017-04-21 3:40 UTC (permalink / raw)
To: Brad Bishop, openbmc, joel
[-- Attachment #1: Type: text/plain, Size: 2371 bytes --]
On Thu, 2017-04-20 at 23:19 -0400, Brad Bishop wrote:
> Some OpenBMC systems will be using keyboard-gpio so enable it
> in our configs.
>
> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Acked-by: Andrew Jeffery <andrew@aj.id.au>
In the future please add the tags given for previous patch revisions if
there hasn't been significant change :)
> ---
> arch/arm/configs/aspeed_g4_defconfig | 8 +++++++-
> arch/arm/configs/aspeed_g5_defconfig | 8 +++++++-
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/configs/aspeed_g4_defconfig b/arch/arm/configs/aspeed_g4_defconfig
> index 552297b..4350f67 100644
> --- a/arch/arm/configs/aspeed_g4_defconfig
> +++ b/arch/arm/configs/aspeed_g4_defconfig
> @@ -103,7 +103,12 @@ CONFIG_FTGMAC100=y
> CONFIG_BROADCOM_PHY=y
> CONFIG_REALTEK_PHY=y
> # CONFIG_WLAN is not set
> -# CONFIG_INPUT is not set
> +# CONFIG_INPUT_LEDS is not set
> +# CONFIG_INPUT_MOUSEDEV is not set
> +CONFIG_INPUT_EVDEV=y
> +# CONFIG_KEYBOARD_ATKBD is not set
> +CONFIG_KEYBOARD_GPIO=y
> +# CONFIG_INPUT_MOUSE is not set
> # CONFIG_SERIO is not set
> # CONFIG_VT is not set
> # CONFIG_LEGACY_PTYS is not set
> @@ -138,6 +143,7 @@ CONFIG_SENSORS_ADM1275=y
> CONFIG_SENSORS_LM25066=y
> CONFIG_SENSORS_UCD9000=y
> CONFIG_SENSORS_TMP421=y
> +# CONFIG_HID is not set
> # CONFIG_USB_SUPPORT is not set
> CONFIG_NEW_LEDS=y
> CONFIG_LEDS_CLASS=y
> diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig
> index c5e7295..b6b3ca0 100644
> --- a/arch/arm/configs/aspeed_g5_defconfig
> +++ b/arch/arm/configs/aspeed_g5_defconfig
> @@ -102,7 +102,12 @@ CONFIG_FTGMAC100=y
> CONFIG_BROADCOM_PHY=y
> CONFIG_REALTEK_PHY=y
> # CONFIG_WLAN is not set
> -# CONFIG_INPUT is not set
> +# CONFIG_INPUT_LEDS is not set
> +# CONFIG_INPUT_MOUSEDEV is not set
> +CONFIG_INPUT_EVDEV=y
> +# CONFIG_KEYBOARD_ATKBD is not set
> +CONFIG_KEYBOARD_GPIO=y
> +# CONFIG_INPUT_MOUSE is not set
> # CONFIG_SERIO is not set
> # CONFIG_VT is not set
> # CONFIG_LEGACY_PTYS is not set
> @@ -135,6 +140,7 @@ CONFIG_PMBUS=y
> CONFIG_SENSORS_LM25066=y
> CONFIG_SENSORS_UCD9000=y
> CONFIG_SENSORS_TMP421=y
> +# CONFIG_HID is not set
> # CONFIG_USB_SUPPORT is not set
> CONFIG_NEW_LEDS=y
> CONFIG_LEDS_CLASS=y
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-4.7 v5 1/2] ARM: configs: aspeed: Enable keyboard-gpio
2017-04-21 3:40 ` Andrew Jeffery
@ 2017-04-21 3:45 ` Joel Stanley
0 siblings, 0 replies; 7+ messages in thread
From: Joel Stanley @ 2017-04-21 3:45 UTC (permalink / raw)
To: Andrew Jeffery; +Cc: Brad Bishop, OpenBMC Maillist
On Fri, Apr 21, 2017 at 1:10 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> On Thu, 2017-04-20 at 23:19 -0400, Brad Bishop wrote:
>> Some OpenBMC systems will be using keyboard-gpio so enable it
>> in our configs.
>>
>> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
>
> Acked-by: Andrew Jeffery <andrew@aj.id.au>
Merged to dev-4.7.
Cheers,
Joel
>
> In the future please add the tags given for previous patch revisions if
> there hasn't been significant change :)
>
>> ---
>> arch/arm/configs/aspeed_g4_defconfig | 8 +++++++-
>> arch/arm/configs/aspeed_g5_defconfig | 8 +++++++-
>> 2 files changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/configs/aspeed_g4_defconfig b/arch/arm/configs/aspeed_g4_defconfig
>> index 552297b..4350f67 100644
>> --- a/arch/arm/configs/aspeed_g4_defconfig
>> +++ b/arch/arm/configs/aspeed_g4_defconfig
>> @@ -103,7 +103,12 @@ CONFIG_FTGMAC100=y
>> CONFIG_BROADCOM_PHY=y
>> CONFIG_REALTEK_PHY=y
>> # CONFIG_WLAN is not set
>> -# CONFIG_INPUT is not set
>> +# CONFIG_INPUT_LEDS is not set
>> +# CONFIG_INPUT_MOUSEDEV is not set
>> +CONFIG_INPUT_EVDEV=y
>> +# CONFIG_KEYBOARD_ATKBD is not set
>> +CONFIG_KEYBOARD_GPIO=y
>> +# CONFIG_INPUT_MOUSE is not set
>> # CONFIG_SERIO is not set
>> # CONFIG_VT is not set
>> # CONFIG_LEGACY_PTYS is not set
>> @@ -138,6 +143,7 @@ CONFIG_SENSORS_ADM1275=y
>> CONFIG_SENSORS_LM25066=y
>> CONFIG_SENSORS_UCD9000=y
>> CONFIG_SENSORS_TMP421=y
>> +# CONFIG_HID is not set
>> # CONFIG_USB_SUPPORT is not set
>> CONFIG_NEW_LEDS=y
>> CONFIG_LEDS_CLASS=y
>> diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig
>> index c5e7295..b6b3ca0 100644
>> --- a/arch/arm/configs/aspeed_g5_defconfig
>> +++ b/arch/arm/configs/aspeed_g5_defconfig
>> @@ -102,7 +102,12 @@ CONFIG_FTGMAC100=y
>> CONFIG_BROADCOM_PHY=y
>> CONFIG_REALTEK_PHY=y
>> # CONFIG_WLAN is not set
>> -# CONFIG_INPUT is not set
>> +# CONFIG_INPUT_LEDS is not set
>> +# CONFIG_INPUT_MOUSEDEV is not set
>> +CONFIG_INPUT_EVDEV=y
>> +# CONFIG_KEYBOARD_ATKBD is not set
>> +CONFIG_KEYBOARD_GPIO=y
>> +# CONFIG_INPUT_MOUSE is not set
>> # CONFIG_SERIO is not set
>> # CONFIG_VT is not set
>> # CONFIG_LEGACY_PTYS is not set
>> @@ -135,6 +140,7 @@ CONFIG_PMBUS=y
>> CONFIG_SENSORS_LM25066=y
>> CONFIG_SENSORS_UCD9000=y
>> CONFIG_SENSORS_TMP421=y
>> +# CONFIG_HID is not set
>> # CONFIG_USB_SUPPORT is not set
>> CONFIG_NEW_LEDS=y
>> CONFIG_LEDS_CLASS=y
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH linux dev-4.7 v5 2/2] ARM: dts: Enable checkstop and cooling gpio keys
2017-04-21 3:19 [PATCH linux dev-4.7 v5 0/2] enable gpio-keys Brad Bishop
2017-04-21 3:19 ` [PATCH linux dev-4.7 v5 1/2] ARM: configs: aspeed: Enable keyboard-gpio Brad Bishop
@ 2017-04-21 3:19 ` Brad Bishop
2017-04-21 3:42 ` Andrew Jeffery
1 sibling, 1 reply; 7+ messages in thread
From: Brad Bishop @ 2017-04-21 3:19 UTC (permalink / raw)
To: openbmc, joel, andrew
Enable gpio-keys events for the checkstop and water/air cooled
gpios for use by applications on the Witherspoon system.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
---
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
index e3a7b77..236696a 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
@@ -31,6 +31,22 @@
};
};
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ air-water {
+ label = "air-water";
+ gpios = <&gpio ASPEED_GPIO(B, 5) GPIO_ACTIVE_LOW>;
+ linux,code = <ASPEED_GPIO(B, 5)>;
+ };
+
+ checkstop {
+ label = "checkstop";
+ gpios = <&gpio ASPEED_GPIO(J, 2) GPIO_ACTIVE_LOW>;
+ linux,code = <ASPEED_GPIO(J, 2)>;
+ };
+ };
+
leds {
compatible = "gpio-leds";
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH linux dev-4.7 v5 2/2] ARM: dts: Enable checkstop and cooling gpio keys
2017-04-21 3:19 ` [PATCH linux dev-4.7 v5 2/2] ARM: dts: Enable checkstop and cooling gpio keys Brad Bishop
@ 2017-04-21 3:42 ` Andrew Jeffery
2017-04-21 3:45 ` Joel Stanley
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Jeffery @ 2017-04-21 3:42 UTC (permalink / raw)
To: Brad Bishop, openbmc, joel
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On Thu, 2017-04-20 at 23:19 -0400, Brad Bishop wrote:
> Enable gpio-keys events for the checkstop and water/air cooled
> gpios for use by applications on the Witherspoon system.
>
> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Flip flop ;)
Acked-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index e3a7b77..236696a 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -31,6 +31,22 @@
> > };
> > };
>
> > + gpio-keys {
> > + compatible = "gpio-keys";
> +
> > + air-water {
> > + label = "air-water";
> > + gpios = <&gpio ASPEED_GPIO(B, 5) GPIO_ACTIVE_LOW>;
> > + linux,code = <ASPEED_GPIO(B, 5)>;
> > + };
> +
> > + checkstop {
> > + label = "checkstop";
> > + gpios = <&gpio ASPEED_GPIO(J, 2) GPIO_ACTIVE_LOW>;
> > + linux,code = <ASPEED_GPIO(J, 2)>;
> > + };
> > + };
> +
> > leds {
> > compatible = "gpio-leds";
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH linux dev-4.7 v5 2/2] ARM: dts: Enable checkstop and cooling gpio keys
2017-04-21 3:42 ` Andrew Jeffery
@ 2017-04-21 3:45 ` Joel Stanley
0 siblings, 0 replies; 7+ messages in thread
From: Joel Stanley @ 2017-04-21 3:45 UTC (permalink / raw)
To: Andrew Jeffery; +Cc: Brad Bishop, OpenBMC Maillist
On Fri, Apr 21, 2017 at 1:12 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> On Thu, 2017-04-20 at 23:19 -0400, Brad Bishop wrote:
>> Enable gpio-keys events for the checkstop and water/air cooled
>> gpios for use by applications on the Witherspoon system.
>>
>> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
>
> Flip flop ;)
>
> Acked-by: Andrew Jeffery <andrew@aj.id.au>
The bike shed is green.
Merged to dev-4.7. Thanks for your patience Brad.
Cheers,
Joel
>
>> ---
>> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
>> index e3a7b77..236696a 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
>> @@ -31,6 +31,22 @@
>> > };
>> > };
>>
>> > + gpio-keys {
>> > + compatible = "gpio-keys";
>> +
>> > + air-water {
>> > + label = "air-water";
>> > + gpios = <&gpio ASPEED_GPIO(B, 5) GPIO_ACTIVE_LOW>;
>> > + linux,code = <ASPEED_GPIO(B, 5)>;
>> > + };
>> +
>> > + checkstop {
>> > + label = "checkstop";
>> > + gpios = <&gpio ASPEED_GPIO(J, 2) GPIO_ACTIVE_LOW>;
>> > + linux,code = <ASPEED_GPIO(J, 2)>;
>> > + };
>> > + };
>> +
>> > leds {
>> > compatible = "gpio-leds";
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-21 3:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-21 3:19 [PATCH linux dev-4.7 v5 0/2] enable gpio-keys Brad Bishop
2017-04-21 3:19 ` [PATCH linux dev-4.7 v5 1/2] ARM: configs: aspeed: Enable keyboard-gpio Brad Bishop
2017-04-21 3:40 ` Andrew Jeffery
2017-04-21 3:45 ` Joel Stanley
2017-04-21 3:19 ` [PATCH linux dev-4.7 v5 2/2] ARM: dts: Enable checkstop and cooling gpio keys Brad Bishop
2017-04-21 3:42 ` Andrew Jeffery
2017-04-21 3:45 ` Joel Stanley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.