From: Tim Chen <tim.c.chen@linux.intel.com>
To: "Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tim Chen <tim.c.chen@intel.com>, Rik van Riel <riel@redhat.com>,
Hugh Dickins <hughd@google.com>, Shaohua Li <shli@kernel.org>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH -mm] mm, swap: Fix swap space leak in error path of swap_free_entries()
Date: Fri, 21 Apr 2017 09:10:12 -0700 [thread overview]
Message-ID: <1492791012.3209.2.camel@linux.intel.com> (raw)
In-Reply-To: <20170421124739.24534-1-ying.huang@intel.com>
On Fri, 2017-04-21 at 20:47 +0800, Huang, Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
>
> In swapcache_free_entries(), if swap_info_get_cont() return NULL,
> something wrong occurs for the swap entry.A A But we should still
> continue to free the following swap entries in the array instead of
> skip them to avoid swap space leak.A A This is just problem in error
> path, where system may be in an inconsistent state, but it is still
> good to fix it.
>
Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Cc: Tim Chen <tim.c.chen@intel.com>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Shaohua Li <shli@kernel.org>
> Cc: Minchan Kim <minchan@kernel.org>
> ---
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Tim Chen <tim.c.chen@linux.intel.com>
To: "Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tim Chen <tim.c.chen@intel.com>, Rik van Riel <riel@redhat.com>,
Hugh Dickins <hughd@google.com>, Shaohua Li <shli@kernel.org>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH -mm] mm, swap: Fix swap space leak in error path of swap_free_entries()
Date: Fri, 21 Apr 2017 09:10:12 -0700 [thread overview]
Message-ID: <1492791012.3209.2.camel@linux.intel.com> (raw)
In-Reply-To: <20170421124739.24534-1-ying.huang@intel.com>
On Fri, 2017-04-21 at 20:47 +0800, Huang, Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
>
> In swapcache_free_entries(), if swap_info_get_cont() return NULL,
> something wrong occurs for the swap entry. But we should still
> continue to free the following swap entries in the array instead of
> skip them to avoid swap space leak. This is just problem in error
> path, where system may be in an inconsistent state, but it is still
> good to fix it.
>
Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Cc: Tim Chen <tim.c.chen@intel.com>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Shaohua Li <shli@kernel.org>
> Cc: Minchan Kim <minchan@kernel.org>
> ---
next prev parent reply other threads:[~2017-04-21 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 12:47 [PATCH -mm] mm, swap: Fix swap space leak in error path of swap_free_entries() Huang, Ying
2017-04-21 12:47 ` Huang, Ying
2017-04-21 16:10 ` Tim Chen [this message]
2017-04-21 16:10 ` Tim Chen
2017-04-25 21:37 ` Andrew Morton
2017-04-25 21:37 ` Andrew Morton
2017-04-25 22:05 ` Tim Chen
2017-04-25 22:05 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492791012.3209.2.camel@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.