From: Joe Perches <joe@perches.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Matt Mackall <mpm@selenic.com>,
Shannon Nelson <shannon.nelson@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()
Date: Fri, 21 Apr 2017 18:22:49 +0000 [thread overview]
Message-ID: <1492798969.30293.28.camel@perches.com> (raw)
In-Reply-To: <20170421113641.GA14100@gondor.apana.org.au>
On Fri, 2017-04-21 at 19:36 +0800, Herbert Xu wrote:
> On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Wed, 19 Apr 2017 10:50:04 +0200
> >
> > The script "checkpatch.pl" pointed information out like the following.
> >
> > WARNING: quoted string split across lines
> >
> > Thus fix the affected source code places.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>
> This patch doesn't seem to add any value so I'm not taking it.
Your choice.
The general reason to merge strings is in CodingStyle
2) Breaking long lines and strings
[]
never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Matt Mackall <mpm@selenic.com>,
Shannon Nelson <shannon.nelson@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()
Date: Fri, 21 Apr 2017 11:22:49 -0700 [thread overview]
Message-ID: <1492798969.30293.28.camel@perches.com> (raw)
In-Reply-To: <20170421113641.GA14100@gondor.apana.org.au>
On Fri, 2017-04-21 at 19:36 +0800, Herbert Xu wrote:
> On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Wed, 19 Apr 2017 10:50:04 +0200
> >
> > The script "checkpatch.pl" pointed information out like the following.
> >
> > WARNING: quoted string split across lines
> >
> > Thus fix the affected source code places.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>
> This patch doesn't seem to add any value so I'm not taking it.
Your choice.
The general reason to merge strings is in CodingStyle
2) Breaking long lines and strings
[]
never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.
next prev parent reply other threads:[~2017-04-21 18:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 9:08 [PATCH 0/2] n2rng: Fine-tuning for n2rng_probe() SF Markus Elfring
2017-04-19 9:08 ` SF Markus Elfring
2017-04-19 9:10 ` [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe() SF Markus Elfring
2017-04-19 9:10 ` SF Markus Elfring
2017-04-19 15:24 ` Shannon Nelson
2017-04-19 15:24 ` Shannon Nelson
2017-04-21 13:16 ` Herbert Xu
2017-04-21 13:16 ` Herbert Xu
2017-04-19 9:11 ` [PATCH 2/2] n2rng: Combine substrings for two messages " SF Markus Elfring
2017-04-19 9:11 ` SF Markus Elfring
2017-04-19 15:24 ` Shannon Nelson
2017-04-19 15:24 ` Shannon Nelson
2017-04-21 11:36 ` Herbert Xu
2017-04-21 11:36 ` Herbert Xu
2017-04-21 14:53 ` David Miller
2017-04-21 14:53 ` David Miller
2017-04-21 18:22 ` Joe Perches [this message]
2017-04-21 18:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492798969.30293.28.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=shannon.nelson@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.