From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"scott.bauer@intel.com" <scott.bauer@intel.com>
Cc: "hch@lst.de" <hch@lst.de>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"tj@kernel.org" <tj@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: BUG: KASAN: use-after-free in scsi_exit_rq
Date: Fri, 21 Apr 2017 21:49:17 +0000 [thread overview]
Message-ID: <1492811357.2499.9.camel@sandisk.com> (raw)
In-Reply-To: <20170420211849.GB7387@sbauer-Z170X-UD5>
On Thu, 2017-04-20 at 15:18 -0600, Scott Bauer wrote:
> [ 642.638860] BUG: KASAN: use-after-free in scsi_exit_rq+0xf3/0x120 at a=
ddr ffff8802b7fedf00
> [ 642.639362] Read of size 1 by task rcuos/5/53
> [ 642.639713] CPU: 7 PID: 53 Comm: rcuos/6 Not tainted 4.11.0-rc5+ #13
> [ 642.640170] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIO=
S rel-1.7.5-0-ge51488c-20140602_164612-nilsson.home.kraxel.org 04/01/2014
> [ 642.640923] Call Trace:
> [ 642.641080] dump_stack+0x63/0x8f
> [ 642.641289] kasan_object_err+0x21/0x70
> [ 642.641531] kasan_report.part.1+0x231/0x500
> [ 642.641823] ? scsi_exit_rq+0xf3/0x120
> [ 642.642054] ? _raw_spin_unlock_irqrestore+0xe/0x10
> [ 642.642353] ? free_percpu+0x1b7/0x340
> [ 642.642586] ? put_task_stack+0x117/0x2b0
> [ 642.642837] __asan_report_load1_noabort+0x2e/0x30
> [ 642.643138] scsi_exit_rq+0xf3/0x120
> [ 642.643366] free_request_size+0x44/0x60
> [ 642.643614] mempool_destroy.part.6+0x9b/0x150
> [ 642.643899] ? kasan_slab_free+0x87/0xb0
> [ 642.644152] mempool_destroy+0x13/0x20
> [ 642.644394] blk_exit_rl+0x36/0x40
> [ 642.644614] blkg_free+0x146/0x200
> [ 642.644836] __blkg_release_rcu+0x121/0x220
> [ 642.645112] rcu_nocb_kthread+0x61f/0xca0
> [ 642.645376] ? get_state_synchronize_rcu+0x20/0x20
> [ 642.645690] ? pci_mmcfg_check_reserved+0x110/0x110
> [ 642.646011] kthread+0x298/0x390
> [ 642.646224] ? get_state_synchronize_rcu+0x20/0x20
> [ 642.646535] ? kthread_park+0x160/0x160
> [ 642.646787] ret_from_fork+0x2c/0x40
I'm not familiar with cgroups but seeing this makes me wonder whether it wo=
uld
be possible to move the blk_exit_rl() calls from blk_release_queue() into
blk_cleanup_queue()? The SCSI core frees a SCSI host after blk_cleanup_queu=
e()
has finished for all associated SCSI devices. This is why I think that call=
ing
blk_exit_rl() earlier would be sufficient to avoid that scsi_exit_rq()
dereferences a SCSI host pointer after it has been freed.
Bart.=
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"scott.bauer@intel.com" <scott.bauer@intel.com>
Cc: "hch@lst.de" <hch@lst.de>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"tj@kernel.org" <tj@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: BUG: KASAN: use-after-free in scsi_exit_rq
Date: Fri, 21 Apr 2017 21:49:17 +0000 [thread overview]
Message-ID: <1492811357.2499.9.camel@sandisk.com> (raw)
In-Reply-To: <20170420211849.GB7387@sbauer-Z170X-UD5>
On Thu, 2017-04-20 at 15:18 -0600, Scott Bauer wrote:
> [ 642.638860] BUG: KASAN: use-after-free in scsi_exit_rq+0xf3/0x120 at addr ffff8802b7fedf00
> [ 642.639362] Read of size 1 by task rcuos/5/53
> [ 642.639713] CPU: 7 PID: 53 Comm: rcuos/6 Not tainted 4.11.0-rc5+ #13
> [ 642.640170] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.7.5-0-ge51488c-20140602_164612-nilsson.home.kraxel.org 04/01/2014
> [ 642.640923] Call Trace:
> [ 642.641080] dump_stack+0x63/0x8f
> [ 642.641289] kasan_object_err+0x21/0x70
> [ 642.641531] kasan_report.part.1+0x231/0x500
> [ 642.641823] ? scsi_exit_rq+0xf3/0x120
> [ 642.642054] ? _raw_spin_unlock_irqrestore+0xe/0x10
> [ 642.642353] ? free_percpu+0x1b7/0x340
> [ 642.642586] ? put_task_stack+0x117/0x2b0
> [ 642.642837] __asan_report_load1_noabort+0x2e/0x30
> [ 642.643138] scsi_exit_rq+0xf3/0x120
> [ 642.643366] free_request_size+0x44/0x60
> [ 642.643614] mempool_destroy.part.6+0x9b/0x150
> [ 642.643899] ? kasan_slab_free+0x87/0xb0
> [ 642.644152] mempool_destroy+0x13/0x20
> [ 642.644394] blk_exit_rl+0x36/0x40
> [ 642.644614] blkg_free+0x146/0x200
> [ 642.644836] __blkg_release_rcu+0x121/0x220
> [ 642.645112] rcu_nocb_kthread+0x61f/0xca0
> [ 642.645376] ? get_state_synchronize_rcu+0x20/0x20
> [ 642.645690] ? pci_mmcfg_check_reserved+0x110/0x110
> [ 642.646011] kthread+0x298/0x390
> [ 642.646224] ? get_state_synchronize_rcu+0x20/0x20
> [ 642.646535] ? kthread_park+0x160/0x160
> [ 642.646787] ret_from_fork+0x2c/0x40
I'm not familiar with cgroups but seeing this makes me wonder whether it would
be possible to move the blk_exit_rl() calls from blk_release_queue() into
blk_cleanup_queue()? The SCSI core frees a SCSI host after blk_cleanup_queue()
has finished for all associated SCSI devices. This is why I think that calling
blk_exit_rl() earlier would be sufficient to avoid that scsi_exit_rq()
dereferences a SCSI host pointer after it has been freed.
Bart.
next prev parent reply other threads:[~2017-04-21 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 21:18 BUG: KASAN: use-after-free in scsi_exit_rq Scott Bauer
2017-04-21 21:49 ` Bart Van Assche [this message]
2017-04-21 21:49 ` Bart Van Assche
2017-04-28 21:46 ` tj
2017-05-02 14:41 ` Jan Kara
2017-05-02 17:39 ` Bart Van Assche
2017-05-02 17:39 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492811357.2499.9.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=scott.bauer@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.