From: Heiko Stuebner <heiko@sntech.de>
To: Caesar Wang <wxt@rock-chips.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
dianders@chromium.org, briannorris@google.com,
smbarber@google.com, linux-rockchip@lists.infradead.org,
huangtao@rock-chips.com, eddie.cai@rock-chips.com,
David Wu <david.wu@rock-chips.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: rockchip: fix pull setting error for rk3399
Date: Wed, 11 May 2016 09:11 +0200 [thread overview]
Message-ID: <1493162.roERW60dFE@phil> (raw)
In-Reply-To: <1462937968-4952-1-git-send-email-wxt@rock-chips.com>
Am Mittwoch, 11. Mai 2016, 11:39:28 schrieb Caesar Wang:
> From: David Wu <david.wu@rock-chips.com>
>
> This patch fixes the pinctrl pull bias setting, since the pull up/down
> setting is the contrary for gpio0(just the gpio0a and gpio0b) and
> gpio2(just the gpio2c and gpio2d).
>
> From the TRM said, the gpio0a pull polarity setting:
> gpio0a_p
> GPIO0A PE/PS programmation section, every
> GPIO bit corresponding to 2bits[PS:PE]
> 2'b00: Z(Normal operation);
> 2'b11: weak 1(pull-up);
> 2'b01: weak 0(pull-down);
> 2'b10: Z(Normal operation);
This could mention gpio2c and gpio2d as well, as the code now does.
Otherwise the patch looks good and I also compared with the TRM, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] pinctrl: rockchip: fix pull setting error for rk3399
Date: Wed, 11 May 2016 09:11 +0200 [thread overview]
Message-ID: <1493162.roERW60dFE@phil> (raw)
In-Reply-To: <1462937968-4952-1-git-send-email-wxt@rock-chips.com>
Am Mittwoch, 11. Mai 2016, 11:39:28 schrieb Caesar Wang:
> From: David Wu <david.wu@rock-chips.com>
>
> This patch fixes the pinctrl pull bias setting, since the pull up/down
> setting is the contrary for gpio0(just the gpio0a and gpio0b) and
> gpio2(just the gpio2c and gpio2d).
>
> From the TRM said, the gpio0a pull polarity setting:
> gpio0a_p
> GPIO0A PE/PS programmation section, every
> GPIO bit corresponding to 2bits[PS:PE]
> 2'b00: Z(Normal operation);
> 2'b11: weak 1(pull-up);
> 2'b01: weak 0(pull-down);
> 2'b10: Z(Normal operation);
This could mention gpio2c and gpio2d as well, as the code now does.
Otherwise the patch looks good and I also compared with the TRM, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2016-05-11 7:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 3:39 [PATCH v2] pinctrl: rockchip: fix pull setting error for rk3399 Caesar Wang
2016-05-11 3:39 ` Caesar Wang
2016-05-11 3:39 ` Caesar Wang
2016-05-11 4:00 ` Doug Anderson
2016-05-11 4:00 ` Doug Anderson
2016-05-11 7:11 ` Heiko Stuebner [this message]
2016-05-11 7:11 ` Heiko Stuebner
2016-05-11 8:44 ` Linus Walleij
2016-05-11 8:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493162.roERW60dFE@phil \
--to=heiko@sntech.de \
--cc=briannorris@google.com \
--cc=david.wu@rock-chips.com \
--cc=dianders@chromium.org \
--cc=eddie.cai@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=smbarber@google.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.