From: Trond Myklebust <trondmy@primarydata.com>
To: "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
Trond Myklebust <trondmy@primarydata.com>,
"fabf@skynet.be" <fabf@skynet.be>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH V2 linux-next] nfs: kmap can't fail
Date: Wed, 26 Apr 2017 19:05:02 +0000 [thread overview]
Message-ID: <1493233499.2326.1.camel@primarydata.com> (raw)
In-Reply-To: <20170426184516.21784-1-fabf@skynet.be>
T24gV2VkLCAyMDE3LTA0LTI2IGF0IDIwOjQ1ICswMjAwLCBGYWJpYW4gRnJlZGVyaWNrIHdyb3Rl
Og0KPiBSZW1vdmUgTlVMTCB0ZXN0IG9uIGttYXAoKQ0KPiANCj4gU2lnbmVkLW9mZi1ieTogRmFi
aWFuIEZyZWRlcmljayA8ZmFiZkBza3luZXQuYmU+DQo+IC0tLQ0KPiBWMjogUmVtb3ZlIHB0ciBh
bmQgcmV0dXJuIGttYXAocGFnZSkgZGlyZWN0bHkNCj4gKFN1Z2dlc3RlZCBieSBBbm5hIFNjaHVt
YWtlcikNCj4gDQo+IMKgZnMvbmZzL2Rpci5jIHwgNiArLS0tLS0NCj4gwqAxIGZpbGUgY2hhbmdl
ZCwgMSBpbnNlcnRpb24oKyksIDUgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZnMv
bmZzL2Rpci5jIGIvZnMvbmZzL2Rpci5jDQo+IGluZGV4IDNhMTg4Y2IuLjEyZWQ4MDZiIDEwMDY0
NA0KPiAtLS0gYS9mcy9uZnMvZGlyLmMNCj4gKysrIGIvZnMvbmZzL2Rpci5jDQo+IEBAIC0xNzUs
MTMgKzE3NSw5IEBAIHR5cGVkZWYgc3RydWN0IHsNCj4gwqBzdGF0aWMNCj4gwqBzdHJ1Y3QgbmZz
X2NhY2hlX2FycmF5ICpuZnNfcmVhZGRpcl9nZXRfYXJyYXkoc3RydWN0IHBhZ2UgKnBhZ2UpDQo+
IMKgew0KPiAtCXZvaWQgKnB0cjsNCj4gwqAJaWYgKHBhZ2UgPT0gTlVMTCkNCj4gwqAJCXJldHVy
biBFUlJfUFRSKC1FSU8pOw0KPiAtCXB0ciA9IGttYXAocGFnZSk7DQo+IC0JaWYgKHB0ciA9PSBO
VUxMKQ0KPiAtCQlyZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsNCj4gLQlyZXR1cm4gcHRyOw0KPiAr
CXJldHVybiBrbWFwKHBhZ2UpOw0KPiDCoH0NCj4gwqANCj4gwqBzdGF0aWMNCg0KVGhlcmUgc2Vl
bXMgbGl0dGxlIHZhbHVlIGluIGhhdmluZyBhIHdyYXBwZXIgdG8ga21hcC4uLiBDYW4gd2UgcGVy
aGFwcw0KaW5zdGVhZCBqdXN0IGdldCByaWQgb2YgYm90aCBuZnNfcmVhZGRpcl9nZXRfYXJyYXkg
YW5kDQpuZnNfcmVhZGRpcl9yZWxlYXNlX2FycmF5Pw0KDQotLSANClRyb25kIE15a2xlYnVzdA0K
TGludXggTkZTIGNsaWVudCBtYWludGFpbmVyLCBQcmltYXJ5RGF0YQ0KdHJvbmQubXlrbGVidXN0
QHByaW1hcnlkYXRhLmNvbQ0K
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy@primarydata.com>
To: "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
Trond Myklebust <trondmy@primarydata.com>,
"fabf@skynet.be" <fabf@skynet.be>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH V2 linux-next] nfs: kmap can't fail
Date: Wed, 26 Apr 2017 19:05:02 +0000 [thread overview]
Message-ID: <1493233499.2326.1.camel@primarydata.com> (raw)
In-Reply-To: <20170426184516.21784-1-fabf@skynet.be>
On Wed, 2017-04-26 at 20:45 +0200, Fabian Frederick wrote:
> Remove NULL test on kmap()
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> V2: Remove ptr and return kmap(page) directly
> (Suggested by Anna Schumaker)
>
> fs/nfs/dir.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 3a188cb..12ed806b 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -175,13 +175,9 @@ typedef struct {
> static
> struct nfs_cache_array *nfs_readdir_get_array(struct page *page)
> {
> - void *ptr;
> if (page == NULL)
> return ERR_PTR(-EIO);
> - ptr = kmap(page);
> - if (ptr == NULL)
> - return ERR_PTR(-ENOMEM);
> - return ptr;
> + return kmap(page);
> }
>
> static
There seems little value in having a wrapper to kmap... Can we perhaps
instead just get rid of both nfs_readdir_get_array and
nfs_readdir_release_array?
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2017-04-26 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 18:45 [PATCH V2 linux-next] nfs: kmap can't fail Fabian Frederick
2017-04-26 19:05 ` Trond Myklebust [this message]
2017-04-26 19:05 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493233499.2326.1.camel@primarydata.com \
--to=trondmy@primarydata.com \
--cc=anna.schumaker@netapp.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.