diff for duplicates of <1493334676.30844.5.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index fd5afb3..0cdb685 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,19 +1,27 @@ -T24gVGh1LCAyMDE3LTA0LTI3IGF0IDE0OjQ2IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ -IENvbW1pdCA5OWU2NjA4YzllNzQgImJsb2NrOiBBZGQgYmFkYmxvY2sgbWFuYWdlbWVudCBmb3Ig -Z2VuZGlza3MiDQo+IGFsbG93ZWQgZm9yIGRyaXZlcnMgbGlrZSBwbWVtIGFuZCBzb2Z0d2FyZS1y -YWlkIHRvIGFkdmVydGlzZSBhIGxpc3Qgb2YNCj4gYmFkIG1lZGlhIGFyZWFzLiBIb3dldmVyLCBp -dCBpbmFkdmVydGVudGx5IGFkZGVkIGEgJ2JhZGJsb2NrcycgdG8gYWxsDQo+IGJsb2NrIGRldmlj -ZXMuIExldHMgY2xlYW4gdGhpcyB1cCBieSBoYXZpbmcgdGhlICdiYWRibG9ja3MnIGF0dHJpYnV0 -ZQ0KPiBub3QgYmUgdmlzaWJsZSB3aGVuIHRoZSBkcml2ZXIgaGFzIG5vdCBwb3B1bGF0ZWQgYSAn -c3RydWN0IGJhZGJsb2NrcycNCj4gaW5zdGFuY2UgaW4gdGhlIGdlbmRpc2suDQo+IA0KPiBDYzog -SmVucyBBeGJvZSA8YXhib2VAZmIuY29tPg0KPiBDYzogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBs -c3QuZGU+DQo+IENjOiBNYXJ0aW4gSy4gUGV0ZXJzZW4gPG1hcnRpbi5wZXRlcnNlbkBvcmFjbGUu -Y29tPg0KPiBSZXBvcnRlZC1ieTogVmlzaGFsIFZlcm1hIDx2aXNoYWwubC52ZXJtYUBpbnRlbC5j -b20+DQo+IFNpZ25lZC1vZmYtYnk6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwu -Y29tPg0KPiAtLS0NCj4gwqBibG9jay9nZW5oZC5jIHzCoMKgwqAxMSArKysrKysrKysrKw0KPiDC -oDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspDQo+IA0KVGVzdGVkIHRoYXQgdGhpcyBy -ZW1vdmVzIHRoZSBiYWRibG9ja3MgYXR0cmlidXRlIGZvciBibG9jayBkZXZpY2VzIHRoYXQNCmRv -bid0IHVzZSB0aGVtOg0KDQokIGNhdCAvc3lzL2Jsb2NrL3BtZW02L2JhZGJsb2Nrc8KgDQo2MTU3 -NiA4DQoNCiQgY2F0IC9zeXMvYmxvY2svdmRhL2JhZGJsb2Nrc8KgDQpjYXQ6IC9zeXMvYmxvY2sv -dmRhL2JhZGJsb2NrczogTm8gc3VjaCBmaWxlIG9yIGRpcmVjdG9yeQ0KDQpUZXN0ZWQtYnk6IFZp -c2hhbCBWZXJtYSA8dmlzaGFsLmwudmVybWFAaW50ZWwuY29tPg== +On Thu, 2017-04-27 at 14:46 -0700, Dan Williams wrote: +> Commit 99e6608c9e74 "block: Add badblock management for gendisks" +> allowed for drivers like pmem and software-raid to advertise a list of +> bad media areas. However, it inadvertently added a 'badblocks' to all +> block devices. Lets clean this up by having the 'badblocks' attribute +> not be visible when the driver has not populated a 'struct badblocks' +> instance in the gendisk. +> +> Cc: Jens Axboe <axboe@fb.com> +> Cc: Christoph Hellwig <hch@lst.de> +> Cc: Martin K. Petersen <martin.petersen@oracle.com> +> Reported-by: Vishal Verma <vishal.l.verma@intel.com> +> Signed-off-by: Dan Williams <dan.j.williams@intel.com> +> --- +> block/genhd.c | 11 +++++++++++ +> 1 file changed, 11 insertions(+) +> +Tested that this removes the badblocks attribute for block devices that +don't use them: + +$ cat /sys/block/pmem6/badblocks +61576 8 + +$ cat /sys/block/vda/badblocks +cat: /sys/block/vda/badblocks: No such file or directory + +Tested-by: Vishal Verma <vishal.l.verma@intel.com> diff --git a/a/content_digest b/N1/content_digest index ac77401..03ef990 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -11,24 +11,32 @@ " martin.petersen@oracle.com <martin.petersen@oracle.com>\0" "\00:1\0" "b\0" - "T24gVGh1LCAyMDE3LTA0LTI3IGF0IDE0OjQ2IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+\n" - "IENvbW1pdCA5OWU2NjA4YzllNzQgImJsb2NrOiBBZGQgYmFkYmxvY2sgbWFuYWdlbWVudCBmb3Ig\n" - "Z2VuZGlza3MiDQo+IGFsbG93ZWQgZm9yIGRyaXZlcnMgbGlrZSBwbWVtIGFuZCBzb2Z0d2FyZS1y\n" - "YWlkIHRvIGFkdmVydGlzZSBhIGxpc3Qgb2YNCj4gYmFkIG1lZGlhIGFyZWFzLiBIb3dldmVyLCBp\n" - "dCBpbmFkdmVydGVudGx5IGFkZGVkIGEgJ2JhZGJsb2NrcycgdG8gYWxsDQo+IGJsb2NrIGRldmlj\n" - "ZXMuIExldHMgY2xlYW4gdGhpcyB1cCBieSBoYXZpbmcgdGhlICdiYWRibG9ja3MnIGF0dHJpYnV0\n" - "ZQ0KPiBub3QgYmUgdmlzaWJsZSB3aGVuIHRoZSBkcml2ZXIgaGFzIG5vdCBwb3B1bGF0ZWQgYSAn\n" - "c3RydWN0IGJhZGJsb2NrcycNCj4gaW5zdGFuY2UgaW4gdGhlIGdlbmRpc2suDQo+IA0KPiBDYzog\n" - "SmVucyBBeGJvZSA8YXhib2VAZmIuY29tPg0KPiBDYzogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBs\n" - "c3QuZGU+DQo+IENjOiBNYXJ0aW4gSy4gUGV0ZXJzZW4gPG1hcnRpbi5wZXRlcnNlbkBvcmFjbGUu\n" - "Y29tPg0KPiBSZXBvcnRlZC1ieTogVmlzaGFsIFZlcm1hIDx2aXNoYWwubC52ZXJtYUBpbnRlbC5j\n" - "b20+DQo+IFNpZ25lZC1vZmYtYnk6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwu\n" - "Y29tPg0KPiAtLS0NCj4gwqBibG9jay9nZW5oZC5jIHzCoMKgwqAxMSArKysrKysrKysrKw0KPiDC\n" - "oDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspDQo+IA0KVGVzdGVkIHRoYXQgdGhpcyBy\n" - "ZW1vdmVzIHRoZSBiYWRibG9ja3MgYXR0cmlidXRlIGZvciBibG9jayBkZXZpY2VzIHRoYXQNCmRv\n" - "bid0IHVzZSB0aGVtOg0KDQokIGNhdCAvc3lzL2Jsb2NrL3BtZW02L2JhZGJsb2Nrc8KgDQo2MTU3\n" - "NiA4DQoNCiQgY2F0IC9zeXMvYmxvY2svdmRhL2JhZGJsb2Nrc8KgDQpjYXQ6IC9zeXMvYmxvY2sv\n" - "dmRhL2JhZGJsb2NrczogTm8gc3VjaCBmaWxlIG9yIGRpcmVjdG9yeQ0KDQpUZXN0ZWQtYnk6IFZp\n" - c2hhbCBWZXJtYSA8dmlzaGFsLmwudmVybWFAaW50ZWwuY29tPg== + "On Thu, 2017-04-27 at 14:46 -0700, Dan Williams wrote:\n" + "> Commit 99e6608c9e74 \"block: Add badblock management for gendisks\"\n" + "> allowed for drivers like pmem and software-raid to advertise a list of\n" + "> bad media areas. However, it inadvertently added a 'badblocks' to all\n" + "> block devices. Lets clean this up by having the 'badblocks' attribute\n" + "> not be visible when the driver has not populated a 'struct badblocks'\n" + "> instance in the gendisk.\n" + "> \n" + "> Cc: Jens Axboe <axboe@fb.com>\n" + "> Cc: Christoph Hellwig <hch@lst.de>\n" + "> Cc: Martin K. Petersen <martin.petersen@oracle.com>\n" + "> Reported-by: Vishal Verma <vishal.l.verma@intel.com>\n" + "> Signed-off-by: Dan Williams <dan.j.williams@intel.com>\n" + "> ---\n" + "> \302\240block/genhd.c |\302\240\302\240\302\24011 +++++++++++\n" + "> \302\2401 file changed, 11 insertions(+)\n" + "> \n" + "Tested that this removes the badblocks attribute for block devices that\n" + "don't use them:\n" + "\n" + "$ cat /sys/block/pmem6/badblocks\302\240\n" + "61576 8\n" + "\n" + "$ cat /sys/block/vda/badblocks\302\240\n" + "cat: /sys/block/vda/badblocks: No such file or directory\n" + "\n" + Tested-by: Vishal Verma <vishal.l.verma@intel.com> -7706675f3299ad7d01c89da2dc86c729b2ab9d9ba40ffc1279d81f58a60570a1 +e4c2e919b1ebc83ecfa1f2915c665aa8d6556d9c3a3e307481feb855304ee1d8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.