From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"axboe@fb.com" <axboe@fb.com>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH] block: hide badblocks attribute by default
Date: Thu, 27 Apr 2017 23:12:38 +0000 [thread overview]
Message-ID: <1493334676.30844.5.camel@intel.com> (raw)
In-Reply-To: <149332958627.40858.3562179022452904734.stgit@dwillia2-desk3.amr.corp.intel.com>
T24gVGh1LCAyMDE3LTA0LTI3IGF0IDE0OjQ2IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+
IENvbW1pdCA5OWU2NjA4YzllNzQgImJsb2NrOiBBZGQgYmFkYmxvY2sgbWFuYWdlbWVudCBmb3Ig
Z2VuZGlza3MiDQo+IGFsbG93ZWQgZm9yIGRyaXZlcnMgbGlrZSBwbWVtIGFuZCBzb2Z0d2FyZS1y
YWlkIHRvIGFkdmVydGlzZSBhIGxpc3Qgb2YNCj4gYmFkIG1lZGlhIGFyZWFzLiBIb3dldmVyLCBp
dCBpbmFkdmVydGVudGx5IGFkZGVkIGEgJ2JhZGJsb2NrcycgdG8gYWxsDQo+IGJsb2NrIGRldmlj
ZXMuIExldHMgY2xlYW4gdGhpcyB1cCBieSBoYXZpbmcgdGhlICdiYWRibG9ja3MnIGF0dHJpYnV0
ZQ0KPiBub3QgYmUgdmlzaWJsZSB3aGVuIHRoZSBkcml2ZXIgaGFzIG5vdCBwb3B1bGF0ZWQgYSAn
c3RydWN0IGJhZGJsb2NrcycNCj4gaW5zdGFuY2UgaW4gdGhlIGdlbmRpc2suDQo+IA0KPiBDYzog
SmVucyBBeGJvZSA8YXhib2VAZmIuY29tPg0KPiBDYzogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBs
c3QuZGU+DQo+IENjOiBNYXJ0aW4gSy4gUGV0ZXJzZW4gPG1hcnRpbi5wZXRlcnNlbkBvcmFjbGUu
Y29tPg0KPiBSZXBvcnRlZC1ieTogVmlzaGFsIFZlcm1hIDx2aXNoYWwubC52ZXJtYUBpbnRlbC5j
b20+DQo+IFNpZ25lZC1vZmYtYnk6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwu
Y29tPg0KPiAtLS0NCj4gwqBibG9jay9nZW5oZC5jIHzCoMKgwqAxMSArKysrKysrKysrKw0KPiDC
oDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspDQo+IA0KVGVzdGVkIHRoYXQgdGhpcyBy
ZW1vdmVzIHRoZSBiYWRibG9ja3MgYXR0cmlidXRlIGZvciBibG9jayBkZXZpY2VzIHRoYXQNCmRv
bid0IHVzZSB0aGVtOg0KDQokIGNhdCAvc3lzL2Jsb2NrL3BtZW02L2JhZGJsb2Nrc8KgDQo2MTU3
NiA4DQoNCiQgY2F0IC9zeXMvYmxvY2svdmRhL2JhZGJsb2Nrc8KgDQpjYXQ6IC9zeXMvYmxvY2sv
dmRhL2JhZGJsb2NrczogTm8gc3VjaCBmaWxlIG9yIGRpcmVjdG9yeQ0KDQpUZXN0ZWQtYnk6IFZp
c2hhbCBWZXJtYSA8dmlzaGFsLmwudmVybWFAaW50ZWwuY29tPg==
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"axboe@fb.com" <axboe@fb.com>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH] block: hide badblocks attribute by default
Date: Thu, 27 Apr 2017 23:12:38 +0000 [thread overview]
Message-ID: <1493334676.30844.5.camel@intel.com> (raw)
In-Reply-To: <149332958627.40858.3562179022452904734.stgit@dwillia2-desk3.amr.corp.intel.com>
On Thu, 2017-04-27 at 14:46 -0700, Dan Williams wrote:
> Commit 99e6608c9e74 "block: Add badblock management for gendisks"
> allowed for drivers like pmem and software-raid to advertise a list of
> bad media areas. However, it inadvertently added a 'badblocks' to all
> block devices. Lets clean this up by having the 'badblocks' attribute
> not be visible when the driver has not populated a 'struct badblocks'
> instance in the gendisk.
>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Reported-by: Vishal Verma <vishal.l.verma@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> block/genhd.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
Tested that this removes the badblocks attribute for block devices that
don't use them:
$ cat /sys/block/pmem6/badblocks
61576 8
$ cat /sys/block/vda/badblocks
cat: /sys/block/vda/badblocks: No such file or directory
Tested-by: Vishal Verma <vishal.l.verma@intel.com>
next prev parent reply other threads:[~2017-04-27 23:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 21:46 [PATCH] block: hide badblocks attribute by default Dan Williams
2017-04-27 23:12 ` Verma, Vishal L [this message]
2017-04-27 23:12 ` Verma, Vishal L
2017-04-28 14:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493334676.30844.5.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.