From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
Cc: Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bjorn Andersson
<bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Baron <jbaron-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup
Date: Fri, 28 Apr 2017 14:49:03 -0700 [thread overview]
Message-ID: <1493416143.1873.13.camel@perches.com> (raw)
In-Reply-To: <149341493336.35578.13631055553267152302.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote:
> More than one driver has worked around the fact that
> print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build.
No it doesn't. builds work fine. Output is restricted.
> Provide a dynamic_hex_dump() so that drivers that want the extra debugging to be
> turned off in the CONFIG_DYNAMIC_DEBUG=n can use dynamic_hex_dump()
> directly.
I think the concept is unnecessary
.
Just use print_hex_dump with KERN_DEBUG.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-acpi@vger.kernel.org, Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup
Date: Fri, 28 Apr 2017 14:49:03 -0700 [thread overview]
Message-ID: <1493416143.1873.13.camel@perches.com> (raw)
In-Reply-To: <149341493336.35578.13631055553267152302.stgit@dwillia2-desk3.amr.corp.intel.com>
On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote:
> More than one driver has worked around the fact that
> print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build.
No it doesn't. builds work fine. Output is restricted.
> Provide a dynamic_hex_dump() so that drivers that want the extra debugging to be
> turned off in the CONFIG_DYNAMIC_DEBUG=n can use dynamic_hex_dump()
> directly.
I think the concept is unnecessary
.
Just use print_hex_dump with KERN_DEBUG.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-acpi@vger.kernel.org, Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup
Date: Fri, 28 Apr 2017 14:49:03 -0700 [thread overview]
Message-ID: <1493416143.1873.13.camel@perches.com> (raw)
In-Reply-To: <149341493336.35578.13631055553267152302.stgit@dwillia2-desk3.amr.corp.intel.com>
On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote:
> More than one driver has worked around the fact that
> print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build.
No it doesn't. builds work fine. Output is restricted.
> Provide a dynamic_hex_dump() so that drivers that want the extra debugging to be
> turned off in the CONFIG_DYNAMIC_DEBUG=n can use dynamic_hex_dump()
> directly.
I think the concept is unnecessary
.
Just use print_hex_dump with KERN_DEBUG.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@ml01.01.org
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-acpi@vger.kernel.org, Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup
Date: Fri, 28 Apr 2017 14:49:03 -0700 [thread overview]
Message-ID: <1493416143.1873.13.camel@perches.com> (raw)
In-Reply-To: <149341493336.35578.13631055553267152302.stgit@dwillia2-desk3.amr.corp.intel.com>
On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote:
> More than one driver has worked around the fact that
> print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build.
No it doesn't. builds work fine. Output is restricted.
> Provide a dynamic_hex_dump() so that drivers that want the extra debugging to be
> turned off in the CONFIG_DYNAMIC_DEBUG=n can use dynamic_hex_dump()
> directly.
I think the concept is unnecessary
.
Just use print_hex_dump with KERN_DEBUG.
next prev parent reply other threads:[~2017-04-28 21:49 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 21:28 [PATCH 0/3] dynamic_hex_dump cleanup Dan Williams
2017-04-28 21:28 ` Dan Williams
2017-04-28 21:28 ` Dan Williams
[not found] ` <149341493336.35578.13631055553267152302.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-28 21:28 ` [PATCH 1/3] printk: provide generic dynamic_hex_dump fallback Dan Williams
2017-04-28 21:28 ` Dan Williams
2017-04-28 21:28 ` Dan Williams
2017-04-28 21:28 ` Dan Williams
2017-04-28 21:29 ` [PATCH 2/3] virtio, rpmsg: switch to dynamic_hex_dump() Dan Williams
2017-04-28 21:29 ` Dan Williams
2017-04-28 21:29 ` Dan Williams
2017-04-28 21:29 ` Dan Williams
[not found] ` <149341494418.35578.561981766577089185.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-29 8:46 ` kbuild test robot
2017-04-29 8:46 ` kbuild test robot
2017-04-29 8:46 ` kbuild test robot
2017-04-29 8:46 ` kbuild test robot
2017-04-28 21:29 ` [PATCH 3/3] acpi, nfit: kill ACPI_NFIT_DEBUG, " Dan Williams
2017-04-28 21:29 ` Dan Williams
2017-04-28 21:29 ` Dan Williams
2017-04-28 21:29 ` Dan Williams
[not found] ` <149341494933.35578.4269653029034926839.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-28 23:48 ` [PATCH v2] acpi, nfit: kill ACPI_NFIT_DEBUG Dan Williams
2017-04-28 23:48 ` Dan Williams
2017-04-28 23:48 ` Dan Williams
2017-04-28 21:49 ` Joe Perches [this message]
2017-04-28 21:49 ` [PATCH 0/3] dynamic_hex_dump cleanup Joe Perches
2017-04-28 21:49 ` Joe Perches
2017-04-28 21:49 ` Joe Perches
2017-04-28 21:52 ` Dan Williams
2017-04-28 21:52 ` Dan Williams
2017-04-28 21:52 ` Dan Williams
[not found] ` <CAPcyv4iJvjJTd7M5_5saopTvKPStC=sYqq++FbE_qFJwpqmASw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 22:07 ` Joe Perches
2017-04-28 22:07 ` Joe Perches
2017-04-28 22:07 ` Joe Perches
2017-04-28 22:07 ` Joe Perches
[not found] ` <1493417230.1873.15.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-04-28 22:14 ` Dan Williams
2017-04-28 22:14 ` Dan Williams
2017-04-28 22:14 ` Dan Williams
2017-04-28 22:14 ` Dan Williams
2017-04-28 22:19 ` Dan Williams
2017-04-28 22:19 ` Dan Williams
2017-04-28 22:19 ` Dan Williams
[not found] ` <CAPcyv4jzMfd8TrFcX0GR+6iz0SaJyO5NzzswrEVm-kNVfgrQFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 22:31 ` Joe Perches
2017-04-28 22:31 ` Joe Perches
2017-04-28 22:31 ` Joe Perches
2017-04-28 22:31 ` Joe Perches
[not found] ` <1493418714.1873.18.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-04-28 22:59 ` Dan Williams
2017-04-28 22:59 ` Dan Williams
2017-04-28 22:59 ` Dan Williams
2017-04-28 22:59 ` Dan Williams
[not found] ` <CAPcyv4hDC1f9xRJJyDK09ezF7Q=qz+fvku5qFP_FCrS2xh=zUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 23:04 ` Joe Perches
2017-04-28 23:04 ` Joe Perches
2017-04-28 23:04 ` Joe Perches
2017-04-28 23:04 ` Joe Perches
[not found] ` <1493420656.1873.22.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-04-28 23:12 ` Dan Williams
2017-04-28 23:12 ` Dan Williams
2017-04-28 23:12 ` Dan Williams
2017-04-28 23:12 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493416143.1873.13.camel@perches.com \
--to=joe-6d6dil74uinbdgjk7y7tuq@public.gmane.org \
--cc=bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jbaron-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.