[PATCH] scripts/oe-selftest: avoid deprecated imp.reload function

[PATCH] scripts/oe-selftest: avoid deprecated imp.reload function

[leonardo.sandoval.gonzalez]

From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>

As explained in [1], the module function imp.reload has been deprecated for
importlib.reload, so use the latter instead.

[1] https://docs.python.org/3/library/imp.html#imp.reload

Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
 scripts/oe-selftest | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/oe-selftest b/scripts/oe-selftest
index 52366b1c8de..bbc161e649b 100755
--- a/scripts/oe-selftest
+++ b/scripts/oe-selftest
@@ -35,7 +35,7 @@ import time as t
 import re
 import fnmatch
 import collections
-import imp
+import importlib
 
 sys.path.insert(0, os.path.dirname(os.path.realpath(__file__)) + '/lib')
 import scriptpath
@@ -497,7 +497,7 @@ def main():
     bbpath = get_bb_var('BBPATH').split(':')
     layer_libdirs = [p for p in (os.path.join(l, 'lib') for l in bbpath) if os.path.exists(p)]
     sys.path.extend(layer_libdirs)
-    imp.reload(oeqa.selftest)
+    importlib.reload(oeqa.selftest)
 
     # act like bitbake and enforce en_US.UTF-8 locale
     os.environ["LC_ALL"] = "en_US.UTF-8"
-- 
2.12.0

Re: [PATCH] scripts/oe-selftest: avoid deprecated imp.reload function

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

On 2 May 2017 at 18:37, <leonardo.sandoval.gonzalez@linux.intel.com> wrote:

> As explained in [1], the module function imp.reload has been deprecated for
> importlib.reload, so use the latter instead.
>

$ oe-selftest -r package
2017-05-04 17:40:10,352 - selftest - INFO - Running bitbake -e to get BBPATH
Traceback (most recent call last):
  File "/home/ross/Yocto/poky/scripts/oe-selftest", line 806, in <module>
    ret = main()
  File "/home/ross/Yocto/poky/scripts/oe-selftest", line 500, in main
    importlib.reload(oeqa.selftest)
UnboundLocalError: local variable 'importlib' referenced before assignment

Ross

[-- Attachment #2: Type: text/html, Size: 1457 bytes --]

Re: [PATCH] scripts/oe-selftest: avoid deprecated imp.reload function

[Leonardo Sandoval]

On Thu, 2017-05-04 at 17:41 +0100, Burton, Ross wrote:
> 
> On 2 May 2017 at 18:37, <leonardo.sandoval.gonzalez@linux.intel.com>
> wrote:
>         As explained in [1], the module function imp.reload has been
>         deprecated for
>         importlib.reload, so use the latter instead.
>         
> 
> $ oe-selftest -r package
> 2017-05-04 17:40:10,352 - selftest - INFO - Running bitbake -e to get
> BBPATH
> Traceback (most recent call last):
>   File "/home/ross/Yocto/poky/scripts/oe-selftest", line 806, in
> <module>
>     ret = main()
>   File "/home/ross/Yocto/poky/scripts/oe-selftest", line 500, in main
>     importlib.reload(oeqa.selftest)
> UnboundLocalError: local variable 'importlib' referenced before
> assignment
> 
I saw the error also. The strange thing is that the import importlib has
global scope but the interpreter does not have it visible at the 'main'
function. any idea? will send a v2 once I figure out the latter.

Leo

> 
> Ross

Re: [PATCH] scripts/oe-selftest: avoid deprecated imp.reload function

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

On 4 May 2017 at 18:26, Leonardo Sandoval <
leonardo.sandoval.gonzalez@linux.intel.com> wrote:

> I saw the error also. The strange thing is that the import importlib has
> global scope but the interpreter does not have it visible at the 'main'
> function. any idea? will send a v2 once I figure out the latter.
>

I had a ten second look before mailing and decided that it was sufficiently
weird to let you figure it out ;)

Ross

[-- Attachment #2: Type: text/html, Size: 881 bytes --]