[infiniband-core] question about arguments position

[infiniband-core] question about arguments position

[Gustavo A. R. Silva]

Hello everybody,

While looking into Coverity ID 1351047 I ran into the following piece  
of code at drivers/infiniband/core/verbs.c:496:

ret = rdma_addr_find_l2_eth_by_grh(&dgid, &sgid,
                                    ah_attr->dmac,
                                    wc->wc_flags & IB_WC_WITH_VLAN ?
                                    NULL : &vlan_id,
                                    &if_index, &hoplimit);


The issue here is that the position of arguments in the call to  
rdma_addr_find_l2_eth_by_grh() function do not match the order of the  
parameters:

&dgid is passed to sgid
&sgid is passed to dgid

This is the function prototype:

int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid,
				 const union ib_gid *dgid,
				 u8 *dmac, u16 *vlan_id, int *if_index,
				 int *hoplimit)

My question here is if this is intentional?

In case it is not, I will send a patch to fix it. But first it would  
be great to hear any comment about it.

Thank you
--
Gustavo A. R. Silva

RE: [infiniband-core] question about arguments position

[Parav Pandit]

Hi,

> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-
> owner@vger.kernel.org] On Behalf Of Gustavo A. R. Silva
> Sent: Thursday, May 4, 2017 12:42 PM
> To: Doug Ledford <dledford@redhat.com>; Sean Hefty
> <sean.hefty@intel.com>; Hal Rosenstock <hal.rosenstock@gmail.com>; Sagi
> Grimberg <sagi@rimberg.me>; Bart Van Assche
> <bart.vanassche@sandisk.com>; Steve Wise <swise@opengridcomputing.com>;
> Leon Romanovsky <leonro@mellanox.com>; Yishai Hadas
> <yishaih@mellanox.com>; Moni Shoua <monis@mellanox.com>
> Cc: linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [infiniband-core] question about arguments position
> 
> 
> Hello everybody,
> 
> While looking into Coverity ID 1351047 I ran into the following piece of code at
> drivers/infiniband/core/verbs.c:496:
> 
> ret = rdma_addr_find_l2_eth_by_grh(&dgid, &sgid,
>                                     ah_attr->dmac,
>                                     wc->wc_flags & IB_WC_WITH_VLAN ?
>                                     NULL : &vlan_id,
>                                     &if_index, &hoplimit);
> 
> 
> The issue here is that the position of arguments in the call to
> rdma_addr_find_l2_eth_by_grh() function do not match the order of the
> parameters:
> 
> &dgid is passed to sgid
> &sgid is passed to dgid
> 
> This is the function prototype:
> 
> int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid,
> 				 const union ib_gid *dgid,
> 				 u8 *dmac, u16 *vlan_id, int *if_index,
> 				 int *hoplimit)
> 
> My question here is if this is intentional?
> 
Yes. ib_init_ah_from_wc() creates ah from the incoming packet.
Incoming packet has dgid of the receiver node on which this code is getting executed
And sgid contains the GID of the sender.

When resolving mac address of destination, you use arrived dgid as sgid.
And use sgid as dgid because sgid contains destinations GID whom to respond to.

RE: [infiniband-core] question about arguments position

[Parav Pandit]

Hi,

> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-
> owner@vger.kernel.org] On Behalf Of Gustavo A. R. Silva
> Sent: Thursday, May 4, 2017 12:42 PM
> To: Doug Ledford <dledford@redhat.com>; Sean Hefty
> <sean.hefty@intel.com>; Hal Rosenstock <hal.rosenstock@gmail.com>; Sagi
> Grimberg <sagi@rimberg.me>; Bart Van Assche
> <bart.vanassche@sandisk.com>; Steve Wise <swise@opengridcomputing.com>;
> Leon Romanovsky <leonro@mellanox.com>; Yishai Hadas
> <yishaih@mellanox.com>; Moni Shoua <monis@mellanox.com>
> Cc: linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [infiniband-core] question about arguments position
> 
> 
> Hello everybody,
> 
> While looking into Coverity ID 1351047 I ran into the following piece of code at
> drivers/infiniband/core/verbs.c:496:
> 
> ret = rdma_addr_find_l2_eth_by_grh(&dgid, &sgid,
>                                     ah_attr->dmac,
>                                     wc->wc_flags & IB_WC_WITH_VLAN ?
>                                     NULL : &vlan_id,
>                                     &if_index, &hoplimit);
> 
> 
> The issue here is that the position of arguments in the call to
> rdma_addr_find_l2_eth_by_grh() function do not match the order of the
> parameters:
> 
> &dgid is passed to sgid
> &sgid is passed to dgid
> 
> This is the function prototype:
> 
> int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid,
> 				 const union ib_gid *dgid,
> 				 u8 *dmac, u16 *vlan_id, int *if_index,
> 				 int *hoplimit)
> 
> My question here is if this is intentional?
> 
Yes. ib_init_ah_from_wc() creates ah from the incoming packet.
Incoming packet has dgid of the receiver node on which this code is getting executed
And sgid contains the GID of the sender.

When resolving mac address of destination, you use arrived dgid as sgid.
And use sgid as dgid because sgid contains destinations GID whom to respond to.

Re: [infiniband-core] question about arguments position

[Doug Ledford]

On Thu, 2017-05-04 at 21:52 +0000, Parav Pandit wrote:
> Hi,
> 
> > 
> > -----Original Message-----
> > From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
> > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Gustavo A. R. Silva
> > Sent: Thursday, May 4, 2017 12:42 PM
> > To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>; Sean Hefty
> > <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>; Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>;
> > Sagi
> > Grimberg <sagi-TmH2Wj2nsNJBDLzU/O5InQ@public.gmane.org>; Bart Van Assche
> > <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>; Steve Wise <swise@opengridcomputing.c
> > om>;
> > Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>; Yishai Hadas
> > <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>; Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Subject: [infiniband-core] question about arguments position
> > 
> > 
> > Hello everybody,
> > 
> > While looking into Coverity ID 1351047 I ran into the following
> > piece of code at
> > drivers/infiniband/core/verbs.c:496:
> > 
> > ret = rdma_addr_find_l2_eth_by_grh(&dgid, &sgid,
> >                                     ah_attr->dmac,
> >                                     wc->wc_flags & IB_WC_WITH_VLAN
> > ?
> >                                     NULL : &vlan_id,
> >                                     &if_index, &hoplimit);
> > 
> > 
> > The issue here is that the position of arguments in the call to
> > rdma_addr_find_l2_eth_by_grh() function do not match the order of
> > the
> > parameters:
> > 
> > &dgid is passed to sgid
> > &sgid is passed to dgid
> > 
> > This is the function prototype:
> > 
> > int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid,
> > 				 const union ib_gid *dgid,
> > 				 u8 *dmac, u16 *vlan_id, int *if_index,
> > 				 int *hoplimit)
> > 
> > My question here is if this is intentional?
> > 
> Yes. ib_init_ah_from_wc() creates ah from the incoming packet.
> Incoming packet has dgid of the receiver node on which this code is
> getting executed
> And sgid contains the GID of the sender.
> 
> When resolving mac address of destination, you use arrived dgid as
> sgid.
> And use sgid as dgid because sgid contains destinations GID whom to
> respond to.

A patch to add a comment and forestall future questions here might be a
good addition.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [infiniband-core] question about arguments position

[Doug Ledford]

On Thu, 2017-05-04 at 21:52 +0000, Parav Pandit wrote:
> Hi,
> 
> > 
> > -----Original Message-----
> > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-
> > owner@vger.kernel.org] On Behalf Of Gustavo A. R. Silva
> > Sent: Thursday, May 4, 2017 12:42 PM
> > To: Doug Ledford <dledford@redhat.com>; Sean Hefty
> > <sean.hefty@intel.com>; Hal Rosenstock <hal.rosenstock@gmail.com>;
> > Sagi
> > Grimberg <sagi@rimberg.me>; Bart Van Assche
> > <bart.vanassche@sandisk.com>; Steve Wise <swise@opengridcomputing.c
> > om>;
> > Leon Romanovsky <leonro@mellanox.com>; Yishai Hadas
> > <yishaih@mellanox.com>; Moni Shoua <monis@mellanox.com>
> > Cc: linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: [infiniband-core] question about arguments position
> > 
> > 
> > Hello everybody,
> > 
> > While looking into Coverity ID 1351047 I ran into the following
> > piece of code at
> > drivers/infiniband/core/verbs.c:496:
> > 
> > ret = rdma_addr_find_l2_eth_by_grh(&dgid, &sgid,
> >                                     ah_attr->dmac,
> >                                     wc->wc_flags & IB_WC_WITH_VLAN
> > ?
> >                                     NULL : &vlan_id,
> >                                     &if_index, &hoplimit);
> > 
> > 
> > The issue here is that the position of arguments in the call to
> > rdma_addr_find_l2_eth_by_grh() function do not match the order of
> > the
> > parameters:
> > 
> > &dgid is passed to sgid
> > &sgid is passed to dgid
> > 
> > This is the function prototype:
> > 
> > int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid,
> > 				 const union ib_gid *dgid,
> > 				 u8 *dmac, u16 *vlan_id, int *if_index,
> > 				 int *hoplimit)
> > 
> > My question here is if this is intentional?
> > 
> Yes. ib_init_ah_from_wc() creates ah from the incoming packet.
> Incoming packet has dgid of the receiver node on which this code is
> getting executed
> And sgid contains the GID of the sender.
> 
> When resolving mac address of destination, you use arrived dgid as
> sgid.
> And use sgid as dgid because sgid contains destinations GID whom to
> respond to.

A patch to add a comment and forestall future questions here might be a
good addition.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Re: [infiniband-core] question about arguments position

[Gustavo A. R. Silva]

Hi Parav and Doug,

Quoting Doug Ledford <dledford@redhat.com>:

> On Thu, 2017-05-04 at 21:52 +0000, Parav Pandit wrote:
>> Hi,
>>
>> >
>> > -----Original Message-----
>> > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-
>> > owner@vger.kernel.org] On Behalf Of Gustavo A. R. Silva
>> > Sent: Thursday, May 4, 2017 12:42 PM
>> > To: Doug Ledford <dledford@redhat.com>; Sean Hefty
>> > <sean.hefty@intel.com>; Hal Rosenstock <hal.rosenstock@gmail.com>;
>> > Sagi
>> > Grimberg <sagi@rimberg.me>; Bart Van Assche
>> > <bart.vanassche@sandisk.com>; Steve Wise <swise@opengridcomputing.c
>> > om>;
>> > Leon Romanovsky <leonro@mellanox.com>; Yishai Hadas
>> > <yishaih@mellanox.com>; Moni Shoua <monis@mellanox.com>
>> > Cc: linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
>> > Subject: [infiniband-core] question about arguments position
>> >
>> >
>> > Hello everybody,
>> >
>> > While looking into Coverity ID 1351047 I ran into the following
>> > piece of code at
>> > drivers/infiniband/core/verbs.c:496:
>> >
>> > ret = rdma_addr_find_l2_eth_by_grh(&dgid, &sgid,
>> >                                     ah_attr->dmac,
>> >                                     wc->wc_flags & IB_WC_WITH_VLAN
>> > ?
>> >                                     NULL : &vlan_id,
>> >                                     &if_index, &hoplimit);
>> >
>> >
>> > The issue here is that the position of arguments in the call to
>> > rdma_addr_find_l2_eth_by_grh() function do not match the order of
>> > the
>> > parameters:
>> >
>> > &dgid is passed to sgid
>> > &sgid is passed to dgid
>> >
>> > This is the function prototype:
>> >
>> > int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid,
>> > 				 const union ib_gid *dgid,
>> > 				 u8 *dmac, u16 *vlan_id, int *if_index,
>> > 				 int *hoplimit)
>> >
>> > My question here is if this is intentional?
>> >
>> Yes. ib_init_ah_from_wc() creates ah from the incoming packet.
>> Incoming packet has dgid of the receiver node on which this code is
>> getting executed
>> And sgid contains the GID of the sender.
>>
>> When resolving mac address of destination, you use arrived dgid as
>> sgid.
>> And use sgid as dgid because sgid contains destinations GID whom to
>> respond to.
>
> A patch to add a comment and forestall future questions here might be a
> good addition.
>

In the case of Coverity, I already triaged and documented this issue.  
So people can ignore it in the future.

Regarding the code comments, what about the following patch based on  
Parav's comments:

diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 85ed505..38864ea 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -450,6 +450,19 @@ int ib_get_gids_from_rdma_hdr(const union  
rdma_network_hdr *hdr,
  }
  EXPORT_SYMBOL(ib_get_gids_from_rdma_hdr);

+/*
+ * This function creates ah from the incoming packet.
+ * Incoming packet has dgid of the receiver node on which this code is
+ * getting executed and, sgid contains the GID of the sender.
+ *
+ * When resolving mac address of destination, the arrived dgid is used
+ * as sgid and, sgid is used as dgid because sgid contains destinations
+ * GID whom to respond to.
+ *
+ * This is why when calling rdma_addr_find_l2_eth_by_grh() function, the
+ * position of arguments dgid and sgid do not match the order of the
+ * parameters.
+ */
  int ib_init_ah_from_wc(struct ib_device *device, u8 port_num,
                        const struct ib_wc *wc, const struct ib_grh *grh,
                        struct ib_ah_attr *ah_attr)

Thanks for clarifying
--
Gustavo A. R. Silva