From: Jeff Layton <jlayton@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [RFC xfstests PATCH] xfstests: add a writeback error handling test
Date: Tue, 09 May 2017 11:33:03 -0400 [thread overview]
Message-ID: <1494343983.2659.7.camel@redhat.com> (raw)
In-Reply-To: <20170424150019.GA3288@infradead.org>
On Mon, 2017-04-24 at 08:00 -0700, Christoph Hellwig wrote:
> On Mon, Apr 24, 2017 at 09:45:51AM -0400, Jeff Layton wrote:
> > With the patch series above, ext4 now passes. xfs and btrfs end up in
> > r/o mode after the test. xfs returns -EIO at that point though, and
> > btrfs returns -EROFS. What behavior we actually want there, I'm not
> > certain. We might be able to mitigate that by putting the journals on a
> > separate device?
>
> This looks like XFS shut down because of a permanent write error from
> dm-error. Which seems like the expected behavior.
Oops, didn't see this message earlier...
Yeah, that's entirely reasonable when there is a write error to the
journal. The latest version of this uses $SCRATCH_LOGDEV to put the
journal on a different device, and with that I get the expected behavior
from xfs.
Thanks,
--
Jeff Layton <jlayton@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-mm@kvack.org, jfs-discussion@lists.sourceforge.net,
linux-xfs@vger.kernel.org, cluster-devel@redhat.com,
linux-f2fs-devel@lists.sourceforge.net,
v9fs-developer@lists.sourceforge.net, osd-dev@open-osd.org,
linux-nilfs@vger.kernel.org, linux-block@vger.kernel.org,
dhowells@redhat.com, akpm@linux-foundation.org,
ross.zwisler@linux.intel.com, mawilcox@microsoft.com,
jack@suse.com, viro@zeniv.linux.org.uk, corbet@lwn.net,
neilb@suse.de, clm@fb.com, tytso@mit.edu, axboe@kernel.dk
Subject: Re: [RFC xfstests PATCH] xfstests: add a writeback error handling test
Date: Tue, 09 May 2017 11:33:03 -0400 [thread overview]
Message-ID: <1494343983.2659.7.camel@redhat.com> (raw)
In-Reply-To: <20170424150019.GA3288@infradead.org>
On Mon, 2017-04-24 at 08:00 -0700, Christoph Hellwig wrote:
> On Mon, Apr 24, 2017 at 09:45:51AM -0400, Jeff Layton wrote:
> > With the patch series above, ext4 now passes. xfs and btrfs end up in
> > r/o mode after the test. xfs returns -EIO at that point though, and
> > btrfs returns -EROFS. What behavior we actually want there, I'm not
> > certain. We might be able to mitigate that by putting the journals on a
> > separate device?
>
> This looks like XFS shut down because of a permanent write error from
> dm-error. Which seems like the expected behavior.
Oops, didn't see this message earlier...
Yeah, that's entirely reasonable when there is a write error to the
journal. The latest version of this uses $SCRATCH_LOGDEV to put the
journal on a different device, and with that I get the expected behavior
from xfs.
Thanks,
--
Jeff Layton <jlayton@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-mm@kvack.org, jfs-discussion@lists.sourceforge.net,
linux-xfs@vger.kernel.org, cluster-devel@redhat.com,
linux-f2fs-devel@lists.sourceforge.net,
v9fs-developer@lists.sourceforge.net, osd-dev@open-osd.org,
linux-nilfs@vger.kernel.org, linux-block@vger.kernel.org,
dhowells@redhat.com, akpm@linux-foundation.org,
ross.zwisler@linux.intel.com, mawilcox@microsoft.com,
jack@suse.com, viro@zeniv.linux.org.uk, corbet@lwn.net,
neilb@suse.de, clm@fb.com, tytso@mit.edu, axboe@kernel.dk
Subject: Re: [RFC xfstests PATCH] xfstests: add a writeback error handling test
Date: Tue, 09 May 2017 11:33:03 -0400 [thread overview]
Message-ID: <1494343983.2659.7.camel@redhat.com> (raw)
In-Reply-To: <20170424150019.GA3288@infradead.org>
On Mon, 2017-04-24 at 08:00 -0700, Christoph Hellwig wrote:
> On Mon, Apr 24, 2017 at 09:45:51AM -0400, Jeff Layton wrote:
> > With the patch series above, ext4 now passes. xfs and btrfs end up in
> > r/o mode after the test. xfs returns -EIO at that point though, and
> > btrfs returns -EROFS. What behavior we actually want there, I'm not
> > certain. We might be able to mitigate that by putting the journals on a
> > separate device?
>
> This looks like XFS shut down because of a permanent write error from
> dm-error. Which seems like the expected behavior.
Oops, didn't see this message earlier...
Yeah, that's entirely reasonable when there is a write error to the
journal. The latest version of this uses $SCRATCH_LOGDEV to put the
journal on a different device, and with that I get the expected behavior
from xfs.
Thanks,
--
Jeff Layton <jlayton@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-05-09 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 13:45 [Cluster-devel] [RFC xfstests PATCH] xfstests: add a writeback error handling test Jeff Layton
2017-04-24 13:45 ` Jeff Layton
2017-04-24 13:45 ` Jeff Layton
2017-04-24 13:45 ` Jeff Layton
2017-04-24 15:00 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:00 ` Christoph Hellwig
2017-04-24 15:00 ` Christoph Hellwig
2017-05-09 15:33 ` Jeff Layton [this message]
2017-05-09 15:33 ` Jeff Layton
2017-05-09 15:33 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494343983.2659.7.camel@redhat.com \
--to=jlayton@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.